Fix dialyzer warnings

Author: scrogson

lib/oauth2/client.ex

@@ -29,7 +29,7 @@ defmodule OAuth2.Client do
       response = OAuth2.Client.post!(client, "/some/other/resources", %{foo: "bar"})
   """
 
-  alias OAuth2.{AccessToken, Client, Error, Request}
+  alias OAuth2.{AccessToken, Client, Error, Response, Request}
 
   @type authorize_url :: binary
   @type body          :: any

lib/oauth2/error.ex

@@ -1,7 +1,13 @@
 defmodule OAuth2.Error do
+  @moduledoc false
+
+  @type t :: %__MODULE__{
+    reason: binary
+  }
+
   defexception [:reason]
+
   def message(%__MODULE__{reason: :econnrefused}), do: "Connection refused"
   def message(%__MODULE__{reason: reason}) when is_binary(reason), do: reason
   def message(%__MODULE__{reason: reason}), do: inspect reason
 end
-

lib/oauth2/request.ex

@@ -10,7 +10,8 @@ defmodule OAuth2.Request do
   @doc """
   Makes a request of given type to the given URL using the `OAuth2.AccessToken`.
   """
-  @spec request(atom, Client.t, binary, body, Client.headers, Keyword.t) :: {:ok, Response.t} | {:error, Error.t}
+  @spec request(atom, Client.t, binary, body, Client.headers, Keyword.t)
+    :: {:ok, Response.t} | {:error, Response.t} | {:error, Error.t}
   def request(method, %Client{} = client, url, body, headers, opts) do
     url = client |> process_url(url) |> process_params(opts[:params])
     headers = req_headers(client, headers) |> Enum.uniq
@@ -38,12 +39,12 @@ defmodule OAuth2.Request do
   An `OAuth2.Error` exception is raised if the request results in an
   error tuple (`{:error, reason}`).
   """
-  @spec request!(atom, Client.t, binary, body, Client.headers, Keyword.t) :: Response.t | Error.t
+  @spec request!(atom, Client.t, binary, body, Client.headers, Keyword.t) :: Response.t
   def request!(method, %Client{} = client, url, body, headers, opts) do
     case request(method, client, url, body, headers, opts) do
       {:ok, resp} ->
         resp
-      {:error, %{status_code: code, headers: headers, body: body}} ->
+      {:error, %Response{status_code: code, headers: headers, body: body}} ->
         raise %Error{reason: """
         Server responded with status: #{code}
 

lib/oauth2/strategy.ex

@@ -78,7 +78,7 @@ defmodule OAuth2.Strategy do
         |> merge_params(params)
       end
   """
-  @callback authorize_url(Client.t, OAuth2.params) :: Client.t
+  @callback authorize_url(Client.t, Client.params) :: Client.t
 
   @doc """
   Builds the URL to token endpoint.
@@ -96,7 +96,7 @@ defmodule OAuth2.Strategy do
         |> put_headers(headers)
       end
   """
-  @callback get_token(Client.t, OAuth2.params, OAuth2.headers) :: Client.t
+  @callback get_token(Client.t, Client.params, Client.headers) :: Client.t
 
   defmacro __using__(_) do
     quote do

mix.exs

@@ -1,7 +1,7 @@
 defmodule OAuth2.Mixfile do
   use Mix.Project
 
-  @version "0.9.0"
+  @version "0.9.1"
 
   def project do
     [app: :oauth2,
@@ -31,9 +31,9 @@ defmodule OAuth2.Mixfile do
 
      # Test dependencies
      {:poison, "~> 3.0", only: :test},
-     {:bypass, "~> 0.5", only: :test},
+     {:bypass, "~> 0.6", only: :test},
      {:excoveralls, "~> 0.5", only: :test},
-     {:dialyxir, "~> 0.4", only: [:dev], runtime: false},
+     {:dialyxir, "~> 0.5", only: [:dev], runtime: false},
 
      # Docs dependencies
      {:ex_doc, "~> 0.14", only: :dev}]

mix.lock

@@ -1,8 +1,8 @@
-%{"bypass": {:hex, :bypass, "0.5.1", "cf3e8a4d376ee1dcd89bf362dfaf1f4bf4a6e19895f52fdc2bafbd8207ce435f", [:mix], [{:cowboy, "~> 1.0", [hex: :cowboy, optional: false]}, {:plug, "~> 1.0", [hex: :plug, optional: false]}]},
+%{"bypass": {:hex, :bypass, "0.6.0", "fd0a8004fada4464e2ba98497755310b892a097f2fd975f4f787cf264066a335", [:mix], [{:cowboy, "~> 1.0", [hex: :cowboy, optional: false]}, {:plug, "~> 1.0", [hex: :plug, optional: false]}]},
   "certifi": {:hex, :certifi, "1.0.0", "1c787a85b1855ba354f0b8920392c19aa1d06b0ee1362f9141279620a5be2039", [:rebar3], []},
-  "cowboy": {:hex, :cowboy, "1.0.4", "a324a8df9f2316c833a470d918aaf73ae894278b8aa6226ce7a9bf699388f878", [:make, :rebar], [{:cowlib, "~> 1.0.0", [hex: :cowlib, optional: false]}, {:ranch, "~> 1.0", [hex: :ranch, optional: false]}]},
+  "cowboy": {:hex, :cowboy, "1.1.2", "61ac29ea970389a88eca5a65601460162d370a70018afe6f949a29dca91f3bb0", [:rebar3], [{:cowlib, "~> 1.0.2", [hex: :cowlib, optional: false]}, {:ranch, "~> 1.3.2", [hex: :ranch, optional: false]}]},
   "cowlib": {:hex, :cowlib, "1.0.2", "9d769a1d062c9c3ac753096f868ca121e2730b9a377de23dec0f7e08b1df84ee", [:make], []},
-  "dialyxir": {:hex, :dialyxir, "0.4.4", "e93ff4affc5f9e78b70dc7bec7b07da44ae1ed3fef38e7113568dd30ad7b01d3", [:mix], []},
+  "dialyxir": {:hex, :dialyxir, "0.5.0", "5bc543f9c28ecd51b99cc1a685a3c2a1a93216990347f259406a910cf048d1d7", [:mix], []},
   "earmark": {:hex, :earmark, "1.1.0", "8c2bf85d725050a92042bc1edf362621004d43ca6241c756f39612084e95487f", [:mix], []},
   "ex_doc": {:hex, :ex_doc, "0.14.5", "c0433c8117e948404d93ca69411dd575ec6be39b47802e81ca8d91017a0cf83c", [:mix], [{:earmark, "~> 1.0", [hex: :earmark, optional: false]}]},
   "excoveralls": {:hex, :excoveralls, "0.6.1", "9e946b6db84dba592f47632157ecd135a46384b98a430fd16007dc910c70348b", [:mix], [{:exjsx, "~> 3.0", [hex: :exjsx, optional: false]}, {:hackney, ">= 0.12.0", [hex: :hackney, optional: false]}]},
@@ -11,9 +11,9 @@
   "idna": {:hex, :idna, "4.0.0", "10aaa9f79d0b12cf0def53038547855b91144f1bfcc0ec73494f38bb7b9c4961", [:rebar3], []},
   "jsx": {:hex, :jsx, "2.8.1", "1453b4eb3615acb3e2cd0a105d27e6761e2ed2e501ac0b390f5bbec497669846", [:mix, :rebar3], []},
   "metrics": {:hex, :metrics, "1.0.1", "25f094dea2cda98213cecc3aeff09e940299d950904393b2a29d191c346a8486", [:rebar3], []},
-  "mime": {:hex, :mime, "1.0.1", "05c393850524767d13a53627df71beeebb016205eb43bfbd92d14d24ec7a1b51", [:mix], []},
+  "mime": {:hex, :mime, "1.1.0", "01c1d6f4083d8aa5c7b8c246ade95139620ef8effb009edde934e0ec3b28090a", [:mix], []},
   "mimerl": {:hex, :mimerl, "1.0.2", "993f9b0e084083405ed8252b99460c4f0563e41729ab42d9074fd5e52439be88", [:rebar3], []},
-  "plug": {:hex, :plug, "1.3.0", "6e2b01afc5db3fd011ca4a16efd9cb424528c157c30a44a0186bcc92c7b2e8f3", [:mix], [{:cowboy, "~> 1.0.1 or ~> 1.1", [hex: :cowboy, optional: true]}, {:mime, "~> 1.0", [hex: :mime, optional: false]}]},
+  "plug": {:hex, :plug, "1.3.3", "d9be189924379b4e9d470caef87380d09549aea1ceafe6a0d41292c8c317c923", [:mix], [{:cowboy, "~> 1.0.1 or ~> 1.1", [hex: :cowboy, optional: true]}, {:mime, "~> 1.0", [hex: :mime, optional: false]}]},
   "poison": {:hex, :poison, "3.1.0", "d9eb636610e096f86f25d9a46f35a9facac35609a7591b3be3326e99a0484665", [:mix], []},
-  "ranch": {:hex, :ranch, "1.2.1", "a6fb992c10f2187b46ffd17ce398ddf8a54f691b81768f9ef5f461ea7e28c762", [:make], []},
+  "ranch": {:hex, :ranch, "1.3.2", "e4965a144dc9fbe70e5c077c65e73c57165416a901bd02ea899cfd95aa890986", [:rebar3], []},
   "ssl_verify_fun": {:hex, :ssl_verify_fun, "1.1.1", "28a4d65b7f59893bc2c7de786dec1e1555bd742d336043fe644ae956c3497fbe", [:make, :rebar], []}}

test/oauth2/client_test.exs

@@ -38,9 +38,9 @@ defmodule OAuth2.ClientTest do
       send_resp(conn, 200, ~s({"access_token":"test1234"}))
     end
 
-    assert {:ok, client} = Client.get_token(client, [code: "code1234"], [{"Accept", "application/json"}])
+    assert {:ok, client} = Client.get_token(client, [code: "code1234"], [{"accept", "application/json"}])
     assert client.token.access_token == "test1234"
-    assert %Client{} = Client.get_token!(client, [code: "code1234"], [{"Accept", "application/json"}])
+    assert %Client{} = Client.get_token!(client, [code: "code1234"], [{"accept", "application/json"}])
   end
 
   test "get_token, get_token! when `:token_method` is `:get`", %{client: client, server: server} do