Skip to content

Commit d405133

Browse files
committed
add feedbackMenuForegroundColor for menu button colors
1 parent ac0d6f3 commit d405133

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

feedback/lib/src/controls_column.dart

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ class ControlsColumn extends StatelessWidget {
5454
children: <Widget>[
5555
IconButton(
5656
key: const ValueKey<String>('close_controls_column'),
57-
icon: const Icon(Icons.close),
57+
icon: Icon(Icons.close,
58+
color: FeedbackTheme.of(context).feedbackMenuForegroundColor),
5859
onPressed: onCloseFeedback,
5960
),
6061
_ColumnDivider(),
@@ -86,12 +87,14 @@ class ControlsColumn extends StatelessWidget {
8687
),
8788
IconButton(
8889
key: const ValueKey<String>('undo_button'),
89-
icon: const Icon(Icons.undo),
90+
icon: Icon(Icons.undo,
91+
color: FeedbackTheme.of(context).feedbackMenuForegroundColor),
9092
onPressed: isNavigatingActive ? null : onUndo,
9193
),
9294
IconButton(
9395
key: const ValueKey<String>('clear_button'),
94-
icon: const Icon(Icons.delete),
96+
icon: Icon(Icons.delete,
97+
color: FeedbackTheme.of(context).feedbackMenuForegroundColor),
9598
onPressed: isNavigatingActive ? null : onClearDrawing,
9699
),
97100
for (final color in colors)

feedback/lib/src/theme/feedback_theme.dart

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ class FeedbackThemeData {
3636
{this.background = Colors.grey,
3737
this.feedbackSheetColor = _lightGrey,
3838
this.feedbackMenuBackgroundColor = _lightGrey,
39+
this.feedbackMenuForegroundColor = Colors.black,
3940
this.feedbackSheetHeight = .25,
4041
this.activeFeedbackModeColor = _blue,
4142
this.drawColors = _defaultDrawColors,
@@ -70,6 +71,8 @@ class FeedbackThemeData {
7071
background: Colors.grey.shade700,
7172
dragHandleColor: Colors.white38,
7273
feedbackSheetColor: _darkGrey,
74+
feedbackMenuBackgroundColor: _darkGrey,
75+
feedbackMenuForegroundColor: Colors.white,
7376
bottomSheetDescriptionStyle: const TextStyle(
7477
color: Colors.white,
7578
),
@@ -83,6 +86,8 @@ class FeedbackThemeData {
8386
background: Colors.grey,
8487
dragHandleColor: Colors.black26,
8588
feedbackSheetColor: _lightGrey,
89+
feedbackMenuBackgroundColor: _lightGrey,
90+
feedbackMenuForegroundColor: Colors.black,
8691
bottomSheetDescriptionStyle: _defaultBottomSheetDescriptionStyle,
8792
sheetIsDraggable: sheetIsDraggable,
8893
brightness: Brightness.light,
@@ -102,6 +107,10 @@ class FeedbackThemeData {
102107
/// in the feedback menu.
103108
final Color feedbackMenuBackgroundColor;
104109

110+
/// The foreground color of the column containing the action buttons (Trash, Undo, ModeButtons)
111+
/// in the feedback menu.
112+
final Color feedbackMenuForegroundColor;
113+
105114
/// The height of the bottom sheet as a fraction of the screen height.
106115
///
107116
/// Values between .2 and .3 are usually ideal.

0 commit comments

Comments
 (0)