Issue #1292 link/unlink items with version relationship by kuchtiak-ufal · Pull Request #1304 · ufal/clarin-dspace

kuchtiak-ufal · 2026-01-13T15:28:13Z

Implementation of the process script that implements two actions:

Link: links 2 items into the versioning relationship
Unlink: unlinks the (last) item from its versioning history

Limitations:

The item-version-linker process can only be started by admin user

Two items can be linked when

the (right) item is not associated with any existing versioning history
the (left) item is either not associated with any existing versioning history, or it represents the last version of items in some existing versioning history

Item can be unlinked when:

item is associated with some existing versioning history, and represents the last version it this versioning history

Notes

In case there are only two items in a versioning history, and the last item is "unlinked", the entire versioning history is removed.

The script also sets/unsets the dc.relation.replaces and dc.relation.isreplacedby metadata on link/unlink actions.

Usage

usage: item-version-linker
 -h,--help             help
 -l,--link             link item with the previous item
 -u,--unlink           unlink item from the previous item in version history.
 -p,--previous <arg>   item handle, or UUID, of the previous (left) item that is intended to be linked with the (right) item (only required for link option)
 -i,--item <arg>       item handle, or UUID, of the (right) item that is intended to be linked/unlinked with/from the previous item (required for both link and unlink options)

Copilot

Pull request overview

This PR implements a new process script item-version-linker that allows administrators to manually link and unlink items in versioning relationships. The script provides two main actions: linking two items where the second becomes a new version of the first, and unlinking the last item from its versioning history.

Changes:

Adds new ItemVersionLinker script and configuration classes for managing item version relationships
Introduces deleteVersion() method to VersioningService to support unlinking operations
Fixes a bug in VersionHistoryServiceImpl.delete() that was deleting a new empty object instead of the passed parameter
Updates test configuration to include the new script and adjusts pagination in script repository tests

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
dspace/config/spring/rest/scripts.xml	Registers the new item-version-linker script configuration bean
dspace-api/src/test/data/dspaceFolder/config/spring/api/scripts.xml	Registers the script configuration for integration tests
dspace-server-webapp/src/test/java/org/dspace/app/rest/ScriptRestRepositoryIT.java	Adds pagination parameter to accommodate the additional script in test assertions
dspace-api/src/main/java/org/dspace/versioning/service/VersioningService.java	Adds new `deleteVersion()` method interface for removing versions without deleting items
dspace-api/src/main/java/org/dspace/versioning/VersioningServiceImpl.java	Implements the new `deleteVersion()` method
dspace-api/src/main/java/org/dspace/versioning/VersionHistoryServiceImpl.java	Fixes bug where wrong object was being deleted (was deleting new empty object instead of parameter)
dspace-api/src/main/java/org/dspace/administer/ItemVersionLinkerConfiguration.java	Defines configuration and CLI options for the item-version-linker script
dspace-api/src/main/java/org/dspace/administer/ItemVersionLinker.java	Implements the main script logic for linking/unlinking items in version relationships
dspace-api/src/test/java/org/dspace/administer/ItemVersionLinkerIT.java	Comprehensive integration tests covering link/unlink operations and error scenarios

dspace-api/src/main/java/org/dspace/administer/ItemVersionLinker.java

dspace-api/src/main/java/org/dspace/administer/ItemVersionLinkerConfiguration.java

…_relationship

…set dc.relation.replaces and dc.relation.isreplacedby

kosarko

overall looks good, just a few questions in the code and one regarding the issue #1292 itself. Where it says:

11234/1-5537 & 11234/1-6033 should be connected. Are there others? How do we find out?

Is there some mechanism available to search for these (I guess these here means items that have dc.relation.replaces and the thing this points to is in our repository but doesn't have dc.relation.isreplacedby) - if there's nothing (no process, curation, cli or a reasonable solr query) this is a separate task.

kosarko · 2026-01-22T15:49:31Z

dspace-api/src/test/java/org/dspace/administer/ItemVersionLinkerIT.java

+                "and its version is not the latest version in that history.", item1.getID()), getErrorMessage());
+        testDSpaceRunnableHandler.getErrorMessages().clear();
+
+        // linking item3 with item2 should fail since item2 is already part of other versioning history


Based on the comment, I don't see why this should fail. Is it about the order of the parameters? (item2, item3, admin) would succeed, right?

Right, the following version link item3(left) -> item2(right) cannot be establish as item2 is already connected to item1.

The (right) item to be linked cannot be part of any existing version history.

can you improve the comment a bit then?

Comment was changed (improved).

dspace-api/src/test/java/org/dspace/administer/ItemVersionLinkerIT.java

dspace-api/src/main/java/org/dspace/administer/ItemVersionLinker.java

kuchtiak-ufal · 2026-01-23T15:53:49Z

With regards to checking items with "dc.relation.replaces" and "dc.relation.isreplacedby".

Created new task: #1310 for this.

kosarko

few more comments...

…_relationship

tested with the production db dump on the items mentions in the issue (11234/1-5537). It was returning: ``` The script has started Item '11234/1-5537' has no handle assigned. ``` because it's dc.identifier.uri.*

port-pr · 2026-02-20T14:52:05Z

Backport branch created but failed to create PR.
Request to create PR rejected with status 403.

Please create the PR manually:

Create PR via GitHub UI

Or via GitHub CLI:

gh pr create --repo dataquest-dev/dspace --base dtq-dev --head ufal:backport-1304-to-dtq-dev --title "[Port dtq-dev] Issue #1292 link/unlink items with version relationship" --body "Port of #1304 by @kuchtiak-ufal to `dtq-dev`."

(see action log for full error response)

* Issue 1292: script to allow link two items into version relationship * implement link and unlink actions * ItemVersionLinkerIT test * improve ItemVersionLinkerIT, fix ScriptRestRepositoryIT * resolve Copilot comments: Part 1 * resolve Copilot comments - part 2 * improve test to be more realistic * improve options description * better call of itemService.clearMetadata() * clear correctly dc.relation.replaces and dc.relation.isreplacedby * use dc.identifier.uri metadata value rather than item.getHandle() to set dc.relation.replaces and dc.relation.isreplacedby * code-cleanup * PR comments * resolve PR comments (O. Kosarko) * add also as a cli script * Use Item.ANY instead of null tested with the production db dump on the items mentions in the issue (11234/1-5537). It was returning: ``` The script has started Item '11234/1-5537' has no handle assigned. ``` because it's dc.identifier.uri.* --------- Co-authored-by: Ondřej Košarko <kosarko@ufal.mff.cuni.cz> Co-authored-by: Ondřej Košarko <ko_ok@centrum.cz> (cherry picked from commit 903b35a)

kuchtiak-ufal added 2 commits January 12, 2026 09:22

Issue 1292: script to allow link two items into version relationship

043631a

implement link and unlink actions

1843e49

kuchtiak-ufal mentioned this pull request Jan 13, 2026

Link two items as a version #1292

Closed

kuchtiak-ufal added 2 commits January 14, 2026 17:02

ItemVersionLinkerIT test

6ae189c

improve ItemVersionLinkerIT, fix ScriptRestRepositoryIT

9b8c63d

kuchtiak-ufal requested review from Copilot and kosarko January 15, 2026 14:18

Copilot started reviewing on behalf of kuchtiak-ufal January 15, 2026 14:19 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

kuchtiak-ufal added 8 commits January 15, 2026 16:55

resolve Copilot comments: Part 1

92a2b7e

resolve Copilot comments - part 2

6fc890b

improve test to be more realistic

740e771

Merge branch 'clarin-v7' into issue_#1292_link_two_items_with_version…

4eaca45

…_relationship

improve options description

0bc0888

better call of itemService.clearMetadata()

2b103a7

clear correctly dc.relation.replaces and dc.relation.isreplacedby

9cffa9f

use dc.identifier.uri metadata value rather than item.getHandle() to …

67e08eb

…set dc.relation.replaces and dc.relation.isreplacedby

kosarko self-assigned this Jan 22, 2026

code-cleanup

e67e27d

kosarko linked an issue Jan 22, 2026 that may be closed by this pull request

Link two items as a version #1292

Closed

kosarko requested changes Jan 22, 2026

View reviewed changes

PR comments

6fef522

kosarko requested changes Jan 30, 2026

View reviewed changes

kuchtiak-ufal and others added 5 commits February 2, 2026 09:52

Merge branch 'clarin-v7' into issue_#1292_link_two_items_with_version…

0ca15cd

…_relationship

resolve PR comments (O. Kosarko)

f83806a

Merge branch 'clarin-v7' into issue_#1292_link_two_items_with_version…

edc2527

…_relationship

add also as a cli script

318c4d5

Use Item.ANY instead of null

55a89f2

tested with the production db dump on the items mentions in the issue (11234/1-5537). It was returning: ``` The script has started Item '11234/1-5537' has no handle assigned. ``` because it's dc.identifier.uri.*

kosarko added the port to dtq-dev label Feb 20, 2026

kosarko merged commit 903b35a into clarin-v7 Feb 20, 2026
10 checks passed

kosarko mentioned this pull request Feb 20, 2026

[Port to dtq-dev] Issue ufal/clarin-dspace#1292 link/unlink items with version relationship dataquest-dev/DSpace#1253

Open

Conversation

kuchtiak-ufal commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Limitations:

Notes

Usage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kosarko left a comment

Choose a reason for hiding this comment

Uh oh!

kosarko Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

kuchtiak-ufal Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kosarko Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

kuchtiak-ufal Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kuchtiak-ufal commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kosarko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

port-pr bot commented Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

kuchtiak-ufal commented Jan 13, 2026 •

edited

Loading

kuchtiak-ufal Jan 23, 2026 •

edited

Loading

kuchtiak-ufal commented Jan 23, 2026 •

edited

Loading