chore(test): Remove noimplicitany file in favor of testing downstream projects for specific typescript versions

christopherthielen · christopherthielen · commit 5a0959298537 · 2018-01-01T11:17:02.000-08:00
diff --git a/downstream_projects.json b/downstream_projects.json
@@ -1,3 +1,7 @@
 {
-  "sample-app-angular": "https://github.com/ui-router/sample-app-angular.git"
+  "sample-app-angular": "https://github.com/ui-router/sample-app-angular.git",
+  "typescript2.3": "./test/ts/typescript2.3",
+  "typescript2.4": "./test/ts/typescript2.4",
+  "typescript2.5": "./test/ts/typescript2.5",
+  "typescript2.6": "./test/ts/typescript2.6"
 }
diff --git a/package.json b/package.json
@@ -12,7 +12,6 @@
     "release": "release --deps @uirouter/core",
     "test": "karma start",
     "test:downstream": "npm run build && test_downstream_projects",
-    "noimplicitany": "tsc --noEmit --noImplicitAny --skipLibCheck --moduleResolution node --target es6 test/noimplicitany.ts",
     "debug": "karma start --singleRun=false --autoWatch=true --autoWatchInterval=1 --browsers=Chrome",
     "package": "npm run build",
     "docs": "typedoc --tsconfig tsconfig.typedoc.json --readme README.md --name '@uirouter/angular' --theme node_modules/ui-router-typedoc-themes/bin/default --out _doc --internal-aliases internal,coreapi,ng2api --external-aliases internalapi,external --navigation-label-globals @uirouter/angular",
diff --git a/test/noimplicitany.ts b/test/noimplicitany.ts
diff --git a/test/ts/typescript2.3/index.ts b/test/ts/typescript2.3/index.ts
@@ -0,0 +1,2 @@
+import { UIRouter } from '@uirouter/angular';
+console.log(UIRouter);
diff --git a/test/ts/typescript2.3/package.json b/test/ts/typescript2.3/package.json
@@ -0,0 +1,15 @@
+{
+  "name": "@uirouter/angular-test-typescript2.3",
+  "version": "1.0.0",
+  "description": "Test against Typescript 2.3",
+  "scripts": {
+    "test": "tsc"
+  },
+  "author": "",
+  "license": "MIT",
+  "dependencies": {
+    "@uirouter/angular": "latest",
+    "typescript": "2.3"
+  },
+  "devDependencies": {}
+}
diff --git a/test/ts/typescript2.3/tsconfig.json b/test/ts/typescript2.3/tsconfig.json
@@ -0,0 +1,12 @@
+{
+  "compilerOptions": {
+    "moduleResolution": "node",
+    "module": "commonjs",
+    "lib": [ "es6", "dom" ],
+    "noImplicitAny": true,
+    "noEmit": true,
+    "target": "es5",
+    "typeRoots": ["node_modules/@types"]
+  },
+  "files": [ "index.ts" ]
+}
diff --git a/test/ts/typescript2.4/index.ts b/test/ts/typescript2.4/index.ts
@@ -0,0 +1,2 @@
+import { UIRouter } from '@uirouter/angular';
+console.log(UIRouter);
diff --git a/test/ts/typescript2.4/package.json b/test/ts/typescript2.4/package.json
@@ -0,0 +1,15 @@
+{
+  "name": "@uirouter/angular-test-typescript2.4",
+  "version": "1.0.0",
+  "description": "Test against Typescript 2.4",
+  "scripts": {
+    "test": "tsc"
+  },
+  "author": "",
+  "license": "MIT",
+  "dependencies": {
+    "@uirouter/angular": "latest",
+    "typescript": "2.4"
+  },
+  "devDependencies": {}
+}
diff --git a/test/ts/typescript2.4/tsconfig.json b/test/ts/typescript2.4/tsconfig.json
@@ -0,0 +1,12 @@
+{
+  "compilerOptions": {
+    "moduleResolution": "node",
+    "module": "commonjs",
+    "lib": [ "es6", "dom" ],
+    "noImplicitAny": true,
+    "noEmit": true,
+    "target": "es5",
+    "typeRoots": ["node_modules/@types"]
+  },
+  "files": [ "index.ts" ]
+}
diff --git a/test/ts/typescript2.5/index.ts b/test/ts/typescript2.5/index.ts
@@ -0,0 +1,2 @@
+import { UIRouter } from '@uirouter/angular';
+console.log(UIRouter);
diff --git a/test/ts/typescript2.5/package.json b/test/ts/typescript2.5/package.json
@@ -0,0 +1,15 @@
+{
+  "name": "@uirouter/angular-test-typescript2.5",
+  "version": "1.0.0",
+  "description": "Test against Typescript 2.5",
+  "scripts": {
+    "test": "tsc"
+  },
+  "author": "",
+  "license": "MIT",
+  "dependencies": {
+    "@uirouter/angular": "latest",
+    "typescript": "2.5"
+  },
+  "devDependencies": {}
+}
diff --git a/test/ts/typescript2.5/tsconfig.json b/test/ts/typescript2.5/tsconfig.json
@@ -0,0 +1,12 @@
+{
+  "compilerOptions": {
+    "moduleResolution": "node",
+    "module": "commonjs",
+    "lib": [ "es6", "dom" ],
+    "noImplicitAny": true,
+    "noEmit": true,
+    "target": "es5",
+    "typeRoots": ["node_modules/@types"]
+  },
+  "files": [ "index.ts" ]
+}
diff --git a/test/ts/typescript2.6/index.ts b/test/ts/typescript2.6/index.ts
@@ -0,0 +1,2 @@
+import { UIRouter } from '@uirouter/angular';
+console.log(UIRouter);
diff --git a/test/ts/typescript2.6/package.json b/test/ts/typescript2.6/package.json
@@ -0,0 +1,15 @@
+{
+  "name": "@uirouter/angular-test-typescript2.6",
+  "version": "1.0.0",
+  "description": "Test against Typescript 2.6",
+  "scripts": {
+    "test": "tsc"
+  },
+  "author": "",
+  "license": "MIT",
+  "dependencies": {
+    "@uirouter/angular": "latest",
+    "typescript": "2.6"
+  },
+  "devDependencies": {}
+}
diff --git a/test/ts/typescript2.6/tsconfig.json b/test/ts/typescript2.6/tsconfig.json
@@ -0,0 +1,12 @@
+{
+  "compilerOptions": {
+    "moduleResolution": "node",
+    "module": "commonjs",
+    "lib": [ "es6", "dom" ],
+    "noImplicitAny": true,
+    "noEmit": true,
+    "target": "es5",
+    "typeRoots": ["node_modules/@types"]
+  },
+  "files": [ "index.ts" ]
+}

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,7 @@`
`1`	`1`	`{`
`2`		`- "sample-app-angular": "https://github.com/ui-router/sample-app-angular.git"`
	`2`	`+ "sample-app-angular": "https://github.com/ui-router/sample-app-angular.git",`
	`3`	`+ "typescript2.3": "./test/ts/typescript2.3",`
	`4`	`+ "typescript2.4": "./test/ts/typescript2.4",`
	`5`	`+ "typescript2.5": "./test/ts/typescript2.5",`
	`6`	`+ "typescript2.6": "./test/ts/typescript2.6"`
`3`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+import { UIRouter } from '@uirouter/angular';`
	`2`	`+console.log(UIRouter);`