chore(tslint): lint the tests

Author: christopherthielen

test/matchers.ts

@@ -1,4 +1,4 @@
-import {equals} from "@uirouter/core";
+import { equals } from '@uirouter/core';
 declare var testablePromise;
 
 beforeEach(function() {
@@ -14,7 +14,7 @@ beforeEach(function() {
     toEqualValues: function() {
       return {
         compare: function(actual, expected) {
-          let pass = Object.keys(expected)
+          const pass = Object.keys(expected)
               .reduce((acc, key) => acc && equals(actual[key], expected[key]), true);
           return { pass };
         }
@@ -30,11 +30,11 @@ beforeEach(function() {
     toHaveClass: function() {
       return {
         compare: function(actual, clazz) {
-          var classes = Array.prototype.slice.call(actual[0].classList);
-          var pass = classes.indexOf(clazz) !== -1;
-          var message = pass ? undefined :  "Expected '" + (actual) + "' to have class '" + clazz + "'.";
+          const classes = Array.prototype.slice.call(actual[0].classList);
+          const pass = classes.indexOf(clazz) !== -1;
+          const message = pass ? undefined :  "Expected '" + (actual) + "' to have class '" + clazz + "'.";
 
-          return { pass: pass, message: message};
+          return { pass: pass, message: message };
         }
       };
     }

test/ngModule/foo/foo.module.ts

@@ -17,13 +17,13 @@ export const child2 = { name: 'foo.child2', url: '/child2', component: Child2Com
 
 @NgModule({
   declarations: [FooComponent, Child1Component, Child2Component],
-  imports: [UIRouterModule.forChild({ states: [ foo, child1, child2 ]})],
+  imports: [UIRouterModule.forChild({ states: [ foo, child1, child2 ] })],
 })
 export class FooModule {}
 
 @NgModule({
   declarations: [FooComponent, Child1Component, Child2Component],
-  imports: [UIRouterModule.forChild({ states: [ child1, child2, foo ]})],
+  imports: [UIRouterModule.forChild({ states: [ child1, child2, foo ] })],
 })
 export class FooModuleOutOfOrder {}
 

test/ngModule/lazyModule.spec.ts

@@ -6,25 +6,25 @@ import { NgModuleFactoryLoader, SystemJsNgModuleLoader } from '@angular/core';
 
 declare let System;
 
-let futureFoo = {
+const futureFoo = {
   name: 'foo.**',
   url: '/foo',
   loadChildren: () => System.import('./foo/foo.module').then(x => x.FooModule)
 };
 
-let futureBar = {
+const futureBar = {
   name: 'bar.**',
   url: '/bar',
   loadChildren: () => System.import('./foo/foo.module').then(x => x.FooModule)
 };
 
-let augment1 = {
+const augment1 = {
   name: 'augment1',
   url: '/augment1',
   loadChildren: () => System.import('./augment/augment.module').then(x => x.AugmentModule)
 };
 
-let augment2 = {
+const augment2 = {
   name: 'augment1.augment2',
   url: '/augment2',
 };
@@ -35,7 +35,7 @@ function configFn(router: UIRouter) {
 
 describe('lazy loading', () => {
   beforeEach(() => {
-    let routerModule = UIRouterModule.forRoot({ useHash: true, states: [], config: configFn });
+    const routerModule = UIRouterModule.forRoot({ useHash: true, states: [], config: configFn });
 
     TestBed.configureTestingModule({
       declarations: [],
@@ -47,7 +47,7 @@ describe('lazy loading', () => {
   });
 
   it('should lazy load a module', async(inject([UIRouter], (router: UIRouter) => {
-    let { stateRegistry, stateService, globals } = router;
+    const { stateRegistry, stateService, globals } = router;
     stateRegistry.register(futureFoo);
 
     const fixture = TestBed.createComponent(UIView);
@@ -68,14 +68,14 @@ describe('lazy loading', () => {
   })));
 
   it('should throw if no future state replacement is lazy loaded', async(inject([UIRouter], (router: UIRouter) => {
-    let { stateRegistry, stateService } = router;
+    const { stateRegistry, stateService } = router;
     stateService.defaultErrorHandler(() => null);
     stateRegistry.register(futureBar);
 
     const fixture = TestBed.createComponent(UIView);
     fixture.detectChanges();
 
-    let names = stateRegistry.get().map(state => state.name).sort();
+    const names = stateRegistry.get().map(state => state.name).sort();
     expect(names.length).toBe(2);
     expect(names).toEqual(['', 'bar.**']);
 
@@ -86,21 +86,21 @@ describe('lazy loading', () => {
   })));
 
   it('should support loadChildren on non-future state (manual state cleanup)', async(inject([UIRouter], (router: UIRouter) => {
-    let { stateRegistry, stateService } = router;
+    const { stateRegistry, stateService } = router;
     stateRegistry.register(augment1);
     stateRegistry.register(augment2);
 
     const fixture = TestBed.createComponent(UIView);
     fixture.detectChanges();
 
-    let names = stateRegistry.get().map(state => state.name).sort();
+    const names = stateRegistry.get().map(state => state.name).sort();
     expect(names).toEqual(['', 'augment1', 'augment1.augment2']);
 
     const wait = (delay) => new Promise(resolve => setTimeout(resolve, delay));
     stateService.go('augment1.augment2').then(() => {
       fixture.detectChanges();
       expect(stateService.current.name).toBe('augment1.augment2');
-      expect(fixture.debugElement.nativeElement.textContent.replace(/\s+/g, " ").trim()).toBe('Component 1 Component 2');
+      expect(fixture.debugElement.nativeElement.textContent.replace(/\s+/g, ' ').trim()).toBe('Component 1 Component 2');
     })
   })));
 

test/testUtils.ts

@@ -1,12 +1,12 @@
 import { forEach, map, omit, pick } from '@uirouter/core';
-import { DebugElement } from "@angular/core";
-let stateProps = ["resolve", "resolvePolicy", "data", "template", "templateUrl", "url", "name", "params"];
+import { DebugElement } from '@angular/core';
+const stateProps = ['resolve', 'resolvePolicy', 'data', 'template', 'templateUrl', 'url', 'name', 'params'];
 
 export function tree2Array(tree, inheritName) {
 
   function processState(parent, state, name) {
-    let substates = omit.apply(null, [state].concat(stateProps));
-    let thisState = pick.apply(null, [state].concat(stateProps));
+    const substates = omit.apply(null, [state].concat(stateProps));
+    const thisState = pick.apply(null, [state].concat(stateProps));
     thisState.name = name;
     if (!inheritName) thisState.parent = parent;
 
@@ -22,42 +22,9 @@ export function tree2Array(tree, inheritName) {
     return states;
   }
 
-  return processChildren("", tree);
-}
-
-export function PromiseResult(promise?) {
-  let self = this, _promise: Promise<any>;
-  let resolve, reject, complete;
-
-  this.setPromise = function(promise) {
-    if (_promise) {
-      throw new Error("Already have with'd a promise.");
-    }
-
-    let onfulfilled = (data) =>
-        resolve = data || true;
-    let onrejected = (err) =>
-        reject = err || true;
-    let done = () =>
-        complete = true;
-
-    _promise = promise;
-    _promise.then(onfulfilled)
-        .catch(onrejected)
-        .then(done, done);
-  };
-
-  this.get = () =>
-      ({ resolve: resolve, reject: reject, complete: complete });
-
-  this.called = () =>
-      map(self.get(), (val, key) => val !== undefined);
-
-  if (promise) {
-    this.setPromise(promise);
-  }
+  return processChildren('', tree);
 }
 
 export function clickOnElement(element: DebugElement, button = 0, metaKey = false, ctrlKey = false) {
-  element.triggerEventHandler('click', {button, metaKey, ctrlKey});
+  element.triggerEventHandler('click', { button, metaKey, ctrlKey });
 }

test/ts/typescript2.3/index.ts

@@ -1,2 +1,2 @@
 import { UIRouter } from '@uirouter/angular';
-console.log(UIRouter);
+console.log(UIRouter); // tslint:disable-line:no-console

test/ts/typescript2.4/index.ts

@@ -1,2 +1,2 @@
 import { UIRouter } from '@uirouter/angular';
-console.log(UIRouter);
+console.log(UIRouter); // tslint:disable-line:no-console

test/ts/typescript2.5/index.ts

@@ -1,2 +1,2 @@
 import { UIRouter } from '@uirouter/angular';
-console.log(UIRouter);
+console.log(UIRouter); // tslint:disable-line:no-console

test/ts/typescript2.6/index.ts

@@ -1,2 +1,2 @@
 import { UIRouter } from '@uirouter/angular';
-console.log(UIRouter);
+console.log(UIRouter); // tslint:disable-line:no-console

test/uiSref/uiSref.spec.ts

@@ -6,8 +6,8 @@ import { UIRouterModule } from '../../src/uiRouterNgModule';
 import { UISref } from '../../src/directives/uiSref';
 import { UIRouter, TargetState, TransitionOptions } from '@uirouter/core';
 import { Subject } from 'rxjs/Subject';
-import { Subscription } from "rxjs/Subscription";
-import { clickOnElement } from "../testUtils";
+import { Subscription } from 'rxjs/Subscription';
+import { clickOnElement } from '../testUtils';
 
 describe('uiSref', () => {
   @Component({
@@ -182,7 +182,7 @@ describe('uiSref', () => {
       });
 
       describe('when the uiSref is empty', () => {
-        it('should emit an empty target state event', () =>{
+        it('should emit an empty target state event', () => {
           expect(logger.length).toBe(1);
           expect(logger[0].name()).toBeNull();
         });

test/uiSrefStatus/uiSrefStatus.spec.ts

@@ -4,7 +4,7 @@ import { By } from '@angular/platform-browser';
 
 import { SrefStatus, UISrefStatus } from '../../src/directives/uiSrefStatus';
 import { UIRouterModule } from '../../src/uiRouterNgModule';
-import { clickOnElement } from "../testUtils";
+import { clickOnElement } from '../testUtils';
 
 describe('uiSrefStatus', () => {
   @Component({