Skip to content

Commit fcf7ee3

Browse files
Merge pull request #33 from aitboudad/location-config
[Ng2LocationConfig] get baseHref from LocationStrategy.
2 parents a17d6f2 + f8e234f commit fcf7ee3

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

src/location/locationConfig.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,24 @@
22
/** */
33

44
import { UIRouter, is, isDefined } from "ui-router-core";
5-
import { PlatformLocation, LocationStrategy, PathLocationStrategy } from "@angular/common";
5+
import { LocationStrategy, PathLocationStrategy } from "@angular/common";
66

77
export class Ng2LocationConfig {
88
private _isHtml5: boolean;
99
private _hashPrefix: string = "";
1010

11-
constructor(router: UIRouter, locationStrategy: LocationStrategy, public platformLocation: PlatformLocation) {
12-
this._isHtml5 = is(PathLocationStrategy)(locationStrategy);
11+
constructor(router: UIRouter, private _locationStrategy: LocationStrategy) {
12+
this._isHtml5 = is(PathLocationStrategy)(_locationStrategy);
1313
}
1414

1515
dispose() {}
1616
port = () => null as number;
1717
protocol = () => null as string;
1818
host = () => null as string;
19-
baseHref = () => this.platformLocation.getBaseHrefFromDOM();
19+
baseHref = () => this._locationStrategy.getBaseHref();
2020
html5Mode = () => this._isHtml5;
2121
hashPrefix = (newprefix?: string): string => {
22-
if(isDefined(newprefix)) {
22+
if (isDefined(newprefix)) {
2323
this._hashPrefix = newprefix;
2424
}
2525
return this._hashPrefix;

src/location/locationService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
/** @module ng2 */
22
/** */
33
import { UIRouter, BaseLocationServices, parseUrl } from "ui-router-core";
4-
import { PlatformLocation, LocationStrategy } from "@angular/common";
4+
import { LocationStrategy } from "@angular/common";
55

66
/** A `LocationServices` that uses the browser hash "#" to get/set the current location */
77
export class Ng2LocationServices extends BaseLocationServices {
8-
constructor(router: UIRouter, private _locationStrategy: LocationStrategy, private _platform: PlatformLocation) {
8+
constructor(router: UIRouter, private _locationStrategy: LocationStrategy) {
99
super(router, true);
10-
this._locationStrategy.onPopState(this._listener)
10+
this._locationStrategy.onPopState(this._listener);
1111
}
1212

1313
_get() {

src/providers.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ import { RootModule, StatesModule, UIROUTER_ROOT_MODULE, UIROUTER_MODULE_TOKEN }
9898
import { servicesPlugin, ServicesPlugin } from "ui-router-core";
9999
import { ng2LazyLoadBuilder } from "./statebuilders/lazyLoad";
100100
import { UIRouterRx } from "ui-router-rx";
101-
import { LocationStrategy, PlatformLocation } from "@angular/common";
101+
import { LocationStrategy } from "@angular/common";
102102
import { Ng2LocationServices } from "./location/locationService";
103103
import { Ng2LocationConfig } from "./location/locationConfig";
104104

@@ -108,7 +108,7 @@ import { Ng2LocationConfig } from "./location/locationConfig";
108108
* Creates a UIRouter instance and configures it for Angular 2, then invokes router bootstrap.
109109
* This function is used as an Angular 2 `useFactory` Provider.
110110
*/
111-
export function uiRouterFactory(locationStrategy: LocationStrategy, platformLocation: PlatformLocation, injector: Injector) {
111+
export function uiRouterFactory(locationStrategy: LocationStrategy, injector: Injector) {
112112
let rootModules: RootModule[] = injector.get(UIROUTER_ROOT_MODULE);
113113
let modules: StatesModule[] = injector.get(UIROUTER_MODULE_TOKEN);
114114

@@ -133,8 +133,8 @@ export function uiRouterFactory(locationStrategy: LocationStrategy, platformLoca
133133

134134

135135
// ----------------- Configure for ng2 -------------
136-
router.locationService = new Ng2LocationServices(router, locationStrategy, platformLocation);
137-
router.locationConfig = new Ng2LocationConfig(router, locationStrategy, platformLocation);
136+
router.locationService = new Ng2LocationServices(router, locationStrategy);
137+
router.locationConfig = new Ng2LocationConfig(router, locationStrategy);
138138

139139
// Apply ng2 ui-view handling code
140140
let viewConfigFactory = (path: PathNode[], config: Ng2ViewDeclaration) => new Ng2ViewConfig(path, config);
@@ -170,7 +170,7 @@ export function uiRouterFactory(locationStrategy: LocationStrategy, platformLoca
170170
export function parentUIViewInjectFactory(r: StateRegistry) { return { fqn: null, context: r.root() } as ParentUIViewInject; }
171171

172172
export const _UIROUTER_INSTANCE_PROVIDERS: Provider[] = [
173-
{ provide: UIRouter, useFactory: uiRouterFactory, deps: [LocationStrategy, PlatformLocation, Injector] },
173+
{ provide: UIRouter, useFactory: uiRouterFactory, deps: [LocationStrategy, Injector] },
174174
{ provide: UIView.PARENT_INJECT, useFactory: parentUIViewInjectFactory, deps: [StateRegistry]},
175175
];
176176

0 commit comments

Comments
 (0)