fix a bug in dedup

kaikalii · kaikalii · commit 2407d0c921fe · 2025-08-01T19:05:51.000-07:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/src/algorithm/monadic/mod.rs b/src/algorithm/monadic/mod.rs
@@ -1507,6 +1507,9 @@ impl<T: ArrayValue> Array<T> {
                 }
                 self.data.truncate(new_len * row_len);
             }
+        } else if self.element_count() == 0 && self.row_count() > 0 {
+            self.shape[0] = 1;
+            return Ok(());
         } else {
             let mut seen = HashSet::new();
             let mut deduped = CowSlice::new();
diff --git a/tests/optimized.ua b/tests/optimized.ua
@@ -344,6 +344,8 @@ F ← ⬚10(/+◌1⊞(×¯))
 ◌≡(⍆∘) ≡⊏⊙¤ ⊸(≡⍏ gen⊙0 ⊟100⧻) °△21_2
 ⍤⤙≍ 1 /↥ [NaN 1]
 ⍤⤙≍0 ⊗1 ⍆[1 1 1 1 1 1 1 1]
+⍤⤙≍ °△1_0 ◴ °△ 1_0
+⍤⤙≍ °△1_0 ◴ ↯ 1_0 [0]
 
 # Range start
 ⍤⤙≍ [1 2 3 4 5] ⇡₁5
diff --git a/todo.md b/todo.md
@@ -4,6 +4,7 @@
 - LSP optimizations
   - Fix rename
   - Fix goto references
+- `first group/partition` optimization
 - Sided `join`
 - `table` subscripts for rank selection
 - Mixed subscripts

Original file line number	Diff line number	Diff line change
`@@ -1507,6 +1507,9 @@ impl<T: ArrayValue> Array<T> {`
`1507`	`1507`	`}`
`1508`	`1508`	`self.data.truncate(new_len * row_len);`
`1509`	`1509`	`}`
	`1510`	`+ } else if self.element_count() == 0 && self.row_count() > 0 {`
	`1511`	`+ self.shape[0] = 1;`
	`1512`	`+ return Ok(());`
`1510`	`1513`	`} else {`
`1511`	`1514`	`let mut seen = HashSet::new();`
`1512`	`1515`	`let mut deduped = CowSlice::new();`