lint: fix clippy::default_trait_access

magistau · magistau · commit 3255c7146acf · 2025-08-05T22:07:53.000+03:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -18,7 +18,6 @@ print_stderr = "allow"
 dbg_macro = "warn"
 pedantic = {level = "warn", priority = -1}
 inline_always = "allow"  # TODO: benchmark inlines
-default_trait_access = "allow"  # 23
 format_push_string = "allow"  # 27
 missing_panics_doc = "allow"  # 37
 used_underscore_binding = "allow"  # 39
diff --git a/pad/editor/src/backend.rs b/pad/editor/src/backend.rs
@@ -70,7 +70,7 @@ pub fn delete_file(path: &PathBuf) {
 }
 
 thread_local! {
-    static BREAKPOINTS: RefCell<HashMap<u64, (u64, usize)>> = Default::default();
+    static BREAKPOINTS: RefCell<HashMap<u64, (u64, usize)>> = RefCell::default();
 }
 
 impl Default for WebBackend {
@@ -434,8 +434,8 @@ impl SysBackend for WebBackend {
     }
     fn load_git_module(&self, original_url: &str, target: GitTarget) -> Result<PathBuf, String> {
         thread_local! {
-            static CACHE: RefCell<HashMap<String, Result<String, String>>> = Default::default();
-            static WORKING: RefCell<HashSet<String>> = Default::default();
+            static CACHE: RefCell<HashMap<String, Result<String, String>>> = RefCell::default();
+            static WORKING: RefCell<HashSet<String>> = RefCell::default();
         }
 
         fn cache_url(url: &str, res: Result<String, String>) {
diff --git a/pad/editor/src/lib.rs b/pad/editor/src/lib.rs
@@ -131,7 +131,7 @@ pub fn Editor<'a>(
     let (fullscreen_enabled, set_fullscreen_enabled) = create_signal(false);
     let update_token_count = move |code: &str| {
         set_token_count.set(
-            lex(code, (), &mut Default::default())
+            lex(code, (), &mut uiua::Inputs::default())
                 .0
                 .into_iter()
                 .filter(|tok| {
diff --git a/site/src/markdown.rs b/site/src/markdown.rs
@@ -182,7 +182,7 @@ fn node_view<'a>(node: &'a AstNode<'a>) -> View {
             if block.literal.trim() == "LOGO" {
                 view!(<Editor example=LOGO/>).into_view()
             } else if (block.info.is_empty() || block.info.starts_with("uiua"))
-                && uiua::parse(&block.literal, (), &mut Default::default())
+                && uiua::parse(&block.literal, (), &mut Inputs::default())
                     .1
                     .is_empty()
             {
diff --git a/src/algorithm/ga.rs b/src/algorithm/ga.rs
@@ -9,8 +9,9 @@ use ecow::{eco_vec, EcoVec};
 use serde::*;
 
 use crate::{
-    algorithm::pervade::derive_new_shape, grid_fmt::GridFmt, is_default, Array, Boxed, Primitive,
-    Shape, Uiua, UiuaResult, Value,
+    algorithm::pervade::derive_new_shape,
+    grid_fmt::{GridFmt, GridFmtParams},
+    is_default, Array, Boxed, Primitive, Shape, Uiua, UiuaResult, Value,
 };
 
 macro_rules! ga_op {
@@ -1259,7 +1260,7 @@ pub fn unparse(spec: Spec, val: Value, env: &Uiua) -> UiuaResult<Value> {
             }
             let mask = mask_table[i];
             if n.abs() != 1.0 || mask == 0 {
-                let n_grid = n.abs().fmt_grid(Default::default());
+                let n_grid = n.abs().fmt_grid(GridFmtParams::default());
                 s.extend(n_grid.into_iter().next().unwrap());
             }
             if mask == 0 {
diff --git a/src/algorithm/groups.rs b/src/algorithm/groups.rs
@@ -7,7 +7,8 @@ use ecow::{eco_vec, EcoVec};
 
 use crate::{
     cowslice::CowSlice, get_ops, types::push_empty_rows_value, val_as_arr, Array, ArrayValue,
-    Boxed, Node, Ops, Primitive, ScalarNum, Shape, SigNode, Uiua, UiuaResult, Value,
+    Boxed, Node, Ops, PersistentMeta, Primitive, ScalarNum, Shape, SigNode, Uiua, UiuaResult,
+    Value,
 };
 
 use super::multi_output;
@@ -753,7 +754,7 @@ where
         .collect::<UiuaResult<_>>()?;
 
     if indices.shape == [0]
-        && push_empty_rows_value(&f, &values, false, &mut Default::default(), env)
+        && push_empty_rows_value(&f, &values, false, &mut PersistentMeta::default(), env)
     {
         return Ok(());
     }
diff --git a/src/algorithm/media.rs b/src/algorithm/media.rs
@@ -740,7 +740,7 @@ pub fn gif_bytes_to_value(bytes: &[u8]) -> Result<(f64, Value), gif::DecodingErr
     let first_frame = decoder.read_next_frame()?.unwrap();
     let gif_width = first_frame.width as usize;
     let gif_height = first_frame.height as usize;
-    let mut data: crate::cowslice::CowSlice<f64> = Default::default();
+    let mut data = crate::cowslice::CowSlice::new();
     let mut frame_count = 1;
     let mut delay_sum = first_frame.delay as f64 / 100.0;
     // Init frame data with the first frame
diff --git a/src/algorithm/pervade.rs b/src/algorithm/pervade.rs
@@ -8,6 +8,7 @@ use std::{
 use ecow::eco_vec;
 
 use crate::algorithm::validate_size;
+use crate::cowslice::CowSlice;
 use crate::fill::FillValue;
 use crate::{algorithm::loops::flip, array::*, Uiua, UiuaError, UiuaResult, Value};
 use crate::{Complex, Shape};
@@ -639,7 +640,7 @@ where
 
     if new_shape.contains(&0) {
         b.shape = new_shape;
-        b.data = Default::default();
+        b.data = CowSlice::new();
     } else if new_shape == b.shape {
         // The existing array can be used
         if a.shape == b.shape {
diff --git a/src/compile/binding.rs b/src/compile/binding.rs
@@ -476,7 +476,7 @@ impl Compiler {
                         sig,
                         explicit: binding.signature.is_some(),
                         inline: false,
-                        set_inverses: Default::default(),
+                        set_inverses: SetInverses::default(),
                     },
                 );
             }
diff --git a/src/compile/invert/un.rs b/src/compile/invert/un.rs
@@ -33,7 +33,7 @@ pub fn un_inverse(input: &[Node], asm: &Assembly) -> InversionResult<Node> {
     }
 
     thread_local! {
-        static CACHE: RefCell<HashMap<u64, InversionResult<Node>>> = Default::default();
+        static CACHE: RefCell<HashMap<u64, InversionResult<Node>>> = RefCell::default();
     }
     let mut hasher = DefaultHasher::new();
     for node in input {
@@ -95,7 +95,7 @@ fn anti_inverse(input: &[Node], asm: &Assembly, for_un: bool) -> InversionResult
         return generic();
     }
     thread_local! {
-        static CACHE: RefCell<HashMap<u64, InversionResult<Node>>> = Default::default();
+        static CACHE: RefCell<HashMap<u64, InversionResult<Node>>> = RefCell::default();
     }
     let mut hasher = DefaultHasher::new();
     for node in input {
@@ -445,7 +445,7 @@ inverse!(BothPat, input, asm, Both, span, [f], {
     let inv = f.un_inverse(asm)?;
     Ok((
         input,
-        ImplMod(UnBothImpl(Default::default()), eco_vec![inv], span),
+        ImplMod(UnBothImpl(Subscript::default()), eco_vec![inv], span),
     ))
 });
 
diff --git a/src/compile/invert/under.rs b/src/compile/invert/under.rs
@@ -39,7 +39,7 @@ fn under_inverse(
 
     type Key = (u64, Signature, bool);
     thread_local! {
-        static CACHE: RefCell<HashMap<Key, InversionResult<(Node, Node)>>> = Default::default();
+        static CACHE: RefCell<HashMap<Key, InversionResult<(Node, Node)>>> = RefCell::default();
     }
     let mut hasher = DefaultHasher::new();
     for node in input {
@@ -416,7 +416,7 @@ under!(BothPat, input, g_sig, inverse, asm, {
         (input, None)
     };
     let (sub, args, span, input) = match input {
-        [Mod(Both, args, span), input @ ..] => (Default::default(), args, span, input),
+        [Mod(Both, args, span), input @ ..] => (Subscript::default(), args, span, input),
         [ImplMod(BothImpl(sub), args, span), input @ ..] => (*sub, args, span, input),
         _ => return generic(),
     };
diff --git a/src/compile/mod.rs b/src/compile/mod.rs
@@ -2051,7 +2051,7 @@ impl Compiler {
                     sig,
                     explicit: func.signature.is_some(),
                     inline: true,
-                    set_inverses: Default::default(),
+                    set_inverses: SetInverses::default(),
                 },
             );
         }
diff --git a/src/compile/modifier.rs b/src/compile/modifier.rs
@@ -1491,7 +1491,7 @@ impl Compiler {
             let sig = self.sig_of(&root, &mac.func.span)?;
             let code_mac = CodeMacro {
                 root: SigNode::new(sig, root),
-                names: Default::default(),
+                names: IndexMap::new(),
             };
             self.code_macro(None, span, operands, code_mac)?
         } else {
diff --git a/src/main.rs b/src/main.rs
@@ -28,9 +28,9 @@ use uiua::{
     format::{format_file, format_str, FormatConfig, FormatConfigSource},
     lex,
     lsp::BindingDocsKind,
-    parse, print_stack, Assembly, CodeSpan, Compiler, NativeSys, PreEvalMode, PrimClass, PrimDoc,
-    PrimDocFragment, PrimDocLine, Primitive, RunMode, SafeSys, SpanKind, Spans, Subscript, Token,
-    Uiua, UiuaError, UiuaErrorKind, UiuaResult, CONSTANTS,
+    parse, print_stack, Assembly, CodeSpan, Compiler, Inputs, NativeSys, PreEvalMode, PrimClass,
+    PrimDoc, PrimDocFragment, PrimDocLine, Primitive, RunMode, SafeSys, SpanKind, Spans, Subscript,
+    Token, Uiua, UiuaError, UiuaErrorKind, UiuaResult, CONSTANTS,
 };
 
 static PRESSED_CTRL_C: AtomicBool = AtomicBool::new(false);
@@ -232,7 +232,7 @@ fn main() {
                         exit(1);
                     }
                 };
-                let mut inputs = Default::default();
+                let mut inputs = Inputs::default();
                 let (items, errors, _) = parse(&input, &path, &mut inputs);
                 if !errors.is_empty() {
                     eprintln!(
@@ -1473,7 +1473,7 @@ fn find(path: Option<PathBuf>, text: String, raw: bool) -> UiuaResult {
                 }
             }
             Needle::Prim(prim) => {
-                let (tokens, ..) = lex(&contents, (), &mut Default::default());
+                let (tokens, ..) = lex(&contents, (), &mut Inputs::default());
                 for tok in tokens {
                     let Token::Glyph(prim2) = &tok.value else {
                         continue;
diff --git a/src/run.rs b/src/run.rs
@@ -140,8 +140,8 @@ struct ThisThread {
 impl Default for ThisThread {
     fn default() -> Self {
         Self {
-            parent: Default::default(),
-            children: Default::default(),
+            parent: None,
+            children: HashMap::new(),
             next_child_id: 1,
         }
     }
diff --git a/src/sys/native.rs b/src/sys/native.rs
@@ -226,7 +226,7 @@ impl Default for GlobalNativeSys {
             audio_time_socket: parking_lot::Mutex::new(None),
             colored_errors: DashMap::new(),
             #[cfg(feature = "ffi")]
-            ffi: Default::default(),
+            ffi: crate::FfiState::default(),
             #[cfg(all(feature = "gif", feature = "invoke"))]
             gifs_child: parking_lot::Mutex::new(None),
         }
diff --git a/src/window.rs b/src/window.rs
@@ -1,4 +1,5 @@
 use std::{
+    collections::HashMap,
     env::current_exe,
     fs,
     io::{ErrorKind, Read, Write},
@@ -200,7 +201,7 @@ struct Cache {
     ppp: f32,
     image_scale: f32,
     #[cfg(feature = "audio")]
-    samples_map: std::collections::HashMap<usize, bool>,
+    samples_map: HashMap<usize, bool>,
     last_frame: Instant,
     errors: Vec<String>,
 }
@@ -273,7 +274,7 @@ impl App {
                 ppp,
                 image_scale: 1.0,
                 #[cfg(feature = "audio")]
-                samples_map: Default::default(),
+                samples_map: HashMap::new(),
                 last_frame: Instant::now(),
                 errors: Vec::new(),
             },

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ pub fn delete_file(path: &PathBuf) {`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`thread_local! {`
`73`		`- static BREAKPOINTS: RefCell<HashMap<u64, (u64, usize)>> = Default::default();`
	`73`	`+ static BREAKPOINTS: RefCell<HashMap<u64, (u64, usize)>> = RefCell::default();`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`impl Default for WebBackend {`
`@@ -434,8 +434,8 @@ impl SysBackend for WebBackend {`
`434`	`434`	`}`
`435`	`435`	`fn load_git_module(&self, original_url: &str, target: GitTarget) -> Result<PathBuf, String> {`
`436`	`436`	`thread_local! {`
`437`		`- static CACHE: RefCell<HashMap<String, Result<String, String>>> = Default::default();`
`438`		`- static WORKING: RefCell<HashSet<String>> = Default::default();`
	`437`	`+ static CACHE: RefCell<HashMap<String, Result<String, String>>> = RefCell::default();`
	`438`	`+ static WORKING: RefCell<HashSet<String>> = RefCell::default();`
`439`	`439`	`}`
`440`	`440`
`441`	`441`	`fn cache_url(url: &str, res: Result<String, String>) {`
Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ fn node_view<'a>(node: &'a AstNode<'a>) -> View {`
`182`	`182`	`if block.literal.trim() == "LOGO" {`
`183`	`183`	`view!(<Editor example=LOGO/>).into_view()`
`184`	`184`	`} else if (block.info.is_empty() \|\| block.info.starts_with("uiua"))`
`185`		`- && uiua::parse(&block.literal, (), &mut Default::default())`
	`185`	`+ && uiua::parse(&block.literal, (), &mut Inputs::default())`
`186`	`186`	`.1`
`187`	`187`	`.is_empty()`
`188`	`188`	`{`
Original file line number	Diff line number	Diff line change
`@@ -476,7 +476,7 @@ impl Compiler {`
`476`	`476`	`sig,`
`477`	`477`	`explicit: binding.signature.is_some(),`
`478`	`478`	`inline: false,`
`479`		`- set_inverses: Default::default(),`
	`479`	`+ set_inverses: SetInverses::default(),`
`480`	`480`	`},`
`481`	`481`	`);`
`482`	`482`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ pub fn un_inverse(input: &[Node], asm: &Assembly) -> InversionResult<Node> {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`thread_local! {`
`36`		`- static CACHE: RefCell<HashMap<u64, InversionResult<Node>>> = Default::default();`
	`36`	`+ static CACHE: RefCell<HashMap<u64, InversionResult<Node>>> = RefCell::default();`
`37`	`37`	`}`
`38`	`38`	`let mut hasher = DefaultHasher::new();`
`39`	`39`	`for node in input {`
`@@ -95,7 +95,7 @@ fn anti_inverse(input: &[Node], asm: &Assembly, for_un: bool) -> InversionResult`
`95`	`95`	`return generic();`
`96`	`96`	`}`
`97`	`97`	`thread_local! {`
`98`		`- static CACHE: RefCell<HashMap<u64, InversionResult<Node>>> = Default::default();`
	`98`	`+ static CACHE: RefCell<HashMap<u64, InversionResult<Node>>> = RefCell::default();`
`99`	`99`	`}`
`100`	`100`	`let mut hasher = DefaultHasher::new();`
`101`	`101`	`for node in input {`
`@@ -445,7 +445,7 @@ inverse!(BothPat, input, asm, Both, span, [f], {`
`445`	`445`	`let inv = f.un_inverse(asm)?;`
`446`	`446`	`Ok((`
`447`	`447`	`input,`
`448`		`- ImplMod(UnBothImpl(Default::default()), eco_vec![inv], span),`
	`448`	`+ ImplMod(UnBothImpl(Subscript::default()), eco_vec![inv], span),`
`449`	`449`	`))`
`450`	`450`	`});`
`451`	`451`