fix a stack overflow with circular module references

Author: kaikalii

site/primitives.json

@@ -257,6 +257,12 @@
     "class": "StdIO",
     "description": "Read a line from stdin"
   },
+  "&seek": {
+    "args": 2,
+    "outputs": 0,
+    "class": "Stream",
+    "description": "Moves to a absolute position in the file under the stream."
+  },
   "&sl": {
     "args": 1,
     "outputs": 0,
@@ -335,12 +341,6 @@
     "class": "Stream",
     "description": "Write an array to a stream"
   },
-  "&sb": {
-    "args": 2,
-    "outputs": 0,
-    "class": "Stream",
-    "description": "Goes to the position in a stream"
-  },
   "above": {
     "glyph": "◠",
     "outputs": 1,
@@ -1483,4 +1483,4 @@
     "class": "Encoding",
     "description": "Encode an array into XLSX bytes"
   }
-}
+}

src/compile/binding.rs

@@ -72,11 +72,12 @@ impl Compiler {
                 _ => None,
             }) {
                 if let Ok(Some((path_locals, local))) = self.ref_local(r) {
-                    let is_noadic_function = match &self.asm.bindings[local.index].kind {
-                        BindingKind::Func(f) if f.sig.args() == 0 => true,
-                        _ => false,
+                    let allow_alias = match &self.asm.bindings[local.index].kind {
+                        BindingKind::Func(f) if f.sig.args() == 0 => false,
+                        BindingKind::Scope(_) => false,
+                        _ => true,
                     };
-                    if !is_noadic_function {
+                    if allow_alias {
                         self.validate_local(&r.name.value, local, &r.name.span);
                         (self.code_meta.global_references)
                             .insert(binding.name.span.clone(), local.index);
@@ -303,13 +304,13 @@ impl Compiler {
         let in_function = self
             .scopes()
             .any(|sc| matches!(sc.kind, ScopeKind::Function));
+        let no_code_words = binding.words.iter().all(|w| !w.value.is_code());
         self.current_bindings.push(CurrentBinding {
             name: name.clone(),
             signature: binding.signature.as_ref().map(|s| s.value),
             recurses: 0,
             global_index: local.index,
         });
-        let no_code_words = binding.words.iter().all(|w| !w.value.is_code());
 
         // Compile the words
         let (_, mut node) = self.in_scope(ScopeKind::Binding, |comp| {
@@ -514,6 +515,7 @@ impl Compiler {
             }
             ModuleKind::Test => (ScopeKind::Test, None),
         };
+        // Compile items
         let (module, ()) = self.in_scope(scope_kind, |comp| {
             comp.items(m.items, ItemCompMode::TopLevel)?;
             comp.end_enum()?;

src/compile/mod.rs

@@ -192,7 +192,7 @@ impl AsMut<Assembly> for Compiler {
     }
 }
 
-#[derive(Clone)]
+#[derive(Debug, Clone)]
 struct CurrentBinding {
     name: Ident,
     signature: Option<Signature>,

tests/data_defs.ua

@@ -111,3 +111,9 @@ M! ← F^0
 
 ~F {A ← 0|B ← 0|C ← 0|D ← 0} ∘
 ⍤⤙≍ {2 3 4 1} F D:1 ⊓A:C: 2 B:3 4
+
+┌─╴A
+  Call ← +1
+  B    ← A
+└─╴
+⍤⤙≍ 6 A~B 5

tests_special/error.ua

@@ -172,4 +172,8 @@ M~G
 └─╴
 M 5
 
-F ← |0.1000 ⍢(F F F|1)
+F ← |0.1000 ⍢(F F F|1)
+
+┌─╴A
+  B ← A
+└─╴