lint: fix clippy::pedantic (1 entry)

Author: magistau

Cargo.toml

@@ -17,15 +17,6 @@ print_stdout = "warn"
 print_stderr = "allow"
 dbg_macro = "warn"
 pedantic = {level = "warn", priority = -1}
-flat_map_option = "allow"  # 1
-format_collect = "allow"  # 1
-inefficient_to_string = "allow"  # 1
-match_wild_err_arm = "allow"  # 1
-maybe_infinite_iter = "allow"  # 1
-missing_fields_in_debug = "allow"  # 1
-same_functions_in_if_condition = "allow"  # 1
-unnecessary_debug_formatting = "allow"  # 1
-unreadable_literal = "allow"  # 1
 implicit_clone = "allow"  # 2
 inconsistent_struct_constructor = "allow"  # 2
 match_bool = "allow"  # 2

pad/editor/src/lib.rs

@@ -77,7 +77,7 @@ pub fn Editor<'a>(
         id.set(i + 1);
         i
     });
-    let help: Vec<String> = help.iter().map(|s| s.to_string()).collect();
+    let help: Vec<String> = help.iter().copied().map(|s| s.to_string()).collect();
     // Initialize all the examples
     let examples = match mode {
         EditorMode::Example if !nonprogressive => progressive_strings(example),

parser/src/inputs.rs

@@ -48,7 +48,7 @@ impl Inputs {
             InputSrc::File(path) => self
                 .files
                 .get(&**path)
-                .unwrap_or_else(|| panic!("File {path:?} not found"))
+                .unwrap_or_else(|| panic!("File {} not found", path.display()))
                 .clone(),
             InputSrc::Str(index) => self
                 .strings

parser/src/parse.rs

@@ -1216,6 +1216,11 @@ impl Parser<'_> {
         if self.too_deep() {
             return None;
         }
+        #[expect(
+            clippy::same_functions_in_if_condition,
+            reason = "methods seem to mutate self, so the second if may or may not be needed",
+            // TODO
+        )]
         let mut word = if let Some(n) = self.num() {
             n.map(|(n, s)| Word::Number(n, s))
         } else if let Some(prim) = self.prim() {

site/src/markdown.rs

@@ -217,6 +217,7 @@ fn node_view<'a>(node: &'a AstNode<'a>) -> View {
 
 #[cfg(test)]
 fn node_html<'a>(node: &'a AstNode<'a>) -> String {
+    use std::fmt::Write;
     use uiua::{Compiler, PrimDoc, SafeSys, Uiua, UiuaErrorKind, Value};
     use uiua_editor::prim_class;
 
@@ -394,8 +395,10 @@ fn node_html<'a>(node: &'a AstNode<'a>) -> String {
         &NodeValue::TableRow(is_header) => {
             let tag = if is_header { "th" } else { "td" };
             children_iter
-                .map(|s| format!("<{tag}>{s}</{tag}>"))
-                .collect()
+                .try_fold(String::new(), |mut acc, cur| {
+                    write!(&mut acc, "<{tag}>{cur}</{tag}>").map(|_| acc)
+                })
+                .expect("write! on a String shouldn't fail")
         }
         _ => children(),
     }

src/algorithm/encode.rs

@@ -307,9 +307,9 @@ impl Value {
                                 &Data::Float(f) => f.into(),
                                 Data::String(s) => s.clone().into(),
                                 &Data::Bool(b) => b.into(),
-                                Data::DateTime(dt) => {
-                                    ((dt.as_f64() - 2.0) * 24.0 * 60.0 * 60.0 - 2208988800.0).into()
-                                }
+                                Data::DateTime(dt) => ((dt.as_f64() - 2.0) * 24.0 * 60.0 * 60.0
+                                    - 2_208_988_800.0)
+                                    .into(),
                                 Data::DateTimeIso(dt) => dt.clone().into(),
                                 Data::DurationIso(dur) => dur.clone().into(),
                                 Data::Error(e) => e.to_string().into(),

src/assembly.rs

@@ -648,6 +648,6 @@ impl fmt::Debug for Assembly {
         f.debug_struct("Assembly")
             .field("root", &self.root)
             .field("functions", &FmtFunctions(self))
-            .finish()
+            .finish_non_exhaustive() // TODO: maybe show all fields instead?
     }
 }

src/format.rs

@@ -1437,6 +1437,10 @@ impl Formatter<'_> {
 
             let mut values = env.rt.output_comments;
             if let Err(e) = res {
+                #[expect(
+                    clippy::maybe_infinite_iter,
+                    reason="values doesn't contain all possible keys,so this should terminate at some point",
+                )]
                 let next = (0..).take_while(|i| values.contains_key(i)).count();
                 values.insert(next, vec![vec![e.to_string().into()]]);
             }

src/main.rs

@@ -1176,7 +1176,7 @@ fn repl(mut env: Uiua, mut compiler: Compiler, color: bool, stack: bool, config:
                 code
             }
             Err(ReadlineError::Eof | ReadlineError::Interrupted) => break,
-            Err(_) => panic!("Failed to read from Stdin"),
+            Err(e) => panic!("Failed to read from Stdin: {e}"),
         };
         if code.is_empty() {
             continue;

src/run_prim.rs

@@ -1535,7 +1535,7 @@ fn regex(env: &mut Uiua) -> UiuaResult {
         for caps in regex.captures_iter(&target) {
             let row: EcoVec<Boxed> = caps
                 .iter()
-                .flat_map(|m| {
+                .filter_map(|m| {
                     m.map(|m| Boxed(Value::from(m.as_str()))).or_else(|| {
                         env.value_fill()
                             .map(|fv| fv.value.clone())