Orient duplicate axis bug (#723)

Omnikar · web-flow · commit c14536b6b853 · 2025-06-20T16:54:43.000-07:00
* Fix bug with `orient`'s duplicate axis checking

* Add a test to account for this case
diff --git a/src/algorithm/dyadic/mod.rs b/src/algorithm/dyadic/mod.rs
@@ -1442,8 +1442,8 @@ impl<T: ArrayValue> Array<T> {
         }
         if undices
             .iter()
-            .zip(undices.iter().skip(1))
-            .any(|(a, b)| a == b)
+            .enumerate()
+            .any(|(i, a)| undices[..i].contains(a))
         {
             return match env.scalar_fill() {
                 Ok(fill) => self.filled_orient(undices, fill.value, env),
diff --git a/tests/dyadic.ua b/tests/dyadic.ua
@@ -18,6 +18,7 @@
 ⍤⤙≍ ⬚0[1 0_2 0_0_3 0_0_0_4] ⬚0⤸ 0_0 [1 2 3 4]
 ⍤⤙≍ [[1_2 0_0] [0_0 3_4]] ⬚0⤸ 0_0 [1_2 3_4]
 ⍤⤙≍ [[1_0 0_0] [0_0 0_2]] ⬚0⤸ 0_0_0 [1 2]
+⍤⤙≍ [[1_2 0_0]_[3_4 0_0] [0_0 5_6]_[0_0 7_8]] ⬚0⤸ 0_1_0 +1°△2_2_2
 
 # Anti orient
 ⍤⤙≍ ⍉⟜(⌝⤸¯1) °△ 2_3_4

Original file line number	Diff line number	Diff line change
`@@ -1442,8 +1442,8 @@ impl<T: ArrayValue> Array<T> {`
`1442`	`1442`	`}`
`1443`	`1443`	`if undices`
`1444`	`1444`	`.iter()`
`1445`		`- .zip(undices.iter().skip(1))`
`1446`		`- .any(\|(a, b)\| a == b)`
	`1445`	`+ .enumerate()`
	`1446`	`+ .any(\|(i, a)\| undices[..i].contains(a))`
`1447`	`1447`	`{`
`1448`	`1448`	`return match env.scalar_fill() {`
`1449`	`1449`	`Ok(fill) => self.filled_orient(undices, fill.value, env),`