lint: use clippy instead of hand-written no_printlns/no_dbgs

magistau · magistau · commit ca5ffd1a149b · 2025-07-16T20:24:11.000+03:00
diff --git a/.clippy.toml b/.clippy.toml
@@ -0,0 +1 @@
+allow-print-in-tests = true
diff --git a/Cargo.toml b/Cargo.toml
@@ -169,5 +169,13 @@ name = "uiua"
 [workspace]
 members = ["site", "tests_ffi", "pad/editor", "parser"]
 
+[workspace.lints.clippy]
+print_stdout = "warn"
+print_stderr = "allow"
+dbg_macro = "warn"
+
+[lints]
+workspace = true
+
 [profile.dev]
 incremental = true
diff --git a/pad/editor/.clippy.toml b/pad/editor/.clippy.toml
@@ -0,0 +1 @@
+../../.clippy.toml
diff --git a/pad/editor/Cargo.toml b/pad/editor/Cargo.toml
@@ -6,6 +6,9 @@ edition = "2021"
 [lib]
 crate-type = ["cdylib", "rlib"]
 
+[lints]
+workspace = true
+
 [dependencies]
 leptos = { version = "0.6.10", features = ["csr"] }
 js-sys = "0.3.69"
diff --git a/parser/.clippy.toml b/parser/.clippy.toml
@@ -0,0 +1 @@
+../.clippy.toml
diff --git a/parser/Cargo.toml b/parser/Cargo.toml
@@ -10,6 +10,9 @@ repository = "https://github.com/uiua-lang/uiua"
 rust-version = "1.82.0"
 version = "0.17.0-dev.1"
 
+[lints]
+workspace = true
+
 [dependencies]
 bytemuck = {version = "1.17", features = ["must_cast", "derive", "extern_crate_alloc"]}
 colored = "2"
diff --git a/site/.clippy.toml b/site/.clippy.toml
@@ -0,0 +1 @@
+../.clippy.toml
diff --git a/site/Cargo.toml b/site/Cargo.toml
@@ -3,6 +3,9 @@ edition = "2021"
 name = "site"
 version = "0.1.0"
 
+[lints]
+workspace = true
+
 [dependencies]
 base64 = "0.22.0"
 comrak = "0.39.0"
diff --git a/src/compile/algebra.rs b/src/compile/algebra.rs
@@ -17,7 +17,7 @@ pub const DEBUG: bool = false;
 macro_rules! dbgln {
     ($($arg:tt)*) => {
         if DEBUG {
-            println!($($arg)*); // Allow println
+            println!($($arg)*);
         }
     }
 }
diff --git a/src/compile/invert/mod.rs b/src/compile/invert/mod.rs
@@ -32,7 +32,7 @@ pub(crate) const DEBUG: bool = false;
 macro_rules! dbgln {
     ($($arg:tt)*) => {
         if crate::compile::invert::DEBUG {
-            println!($($arg)*); // Allow println
+            println!($($arg)*);
         }
     }
 }
diff --git a/src/compile/mod.rs b/src/compile/mod.rs
@@ -2598,9 +2598,10 @@ impl Compiler {
         let inputs = self.asm.inputs.clone();
         self.emit_diagnostic_impl(Diagnostic::new(message.into(), span, kind, inputs));
     }
+    #[allow(clippy::print_stdout)]
     fn emit_diagnostic_impl(&mut self, diagnostic: Diagnostic) {
         if self.print_diagnostics {
-            println!("{}", diagnostic.report()); // Allow println
+            println!("{}", diagnostic.report());
         } else {
             self.diagnostics.insert(diagnostic);
         }
diff --git a/src/compile/optimize.rs b/src/compile/optimize.rs
@@ -7,7 +7,7 @@ pub(crate) const DEBUG: bool = false;
 macro_rules! dbgln {
     ($($arg:tt)*) => {
         if DEBUG {
-            println!($($arg)*); // Allow println
+            println!($($arg)*);
         }
     }
 }
diff --git a/src/ffi.rs b/src/ffi.rs
@@ -236,7 +236,7 @@ mod enabled {
     macro_rules! dbgln {
         ($($arg:tt)*) => {
             if DEBUG {
-                println!($($arg)*); // Allow println
+                println!($($arg)*);
             }
         }
     }
diff --git a/src/lib.rs b/src/lib.rs
@@ -356,37 +356,8 @@ mod tests {
         }
     }
 
-    fn recurse_dirs(dir: &std::path::Path, f: &impl Fn(&std::path::Path)) {
-        for entry in std::fs::read_dir(dir).unwrap() {
-            let entry = entry.unwrap();
-            let path = entry.path();
-            if path.to_string_lossy().contains("target") {
-                continue;
-            }
-            if path.is_dir() {
-                recurse_dirs(&path, f);
-            } else {
-                f(&path);
-            }
-        }
-    }
-
     #[test]
     fn no_dbgs() {
-        recurse_dirs(std::path::Path::new("."), &|path| {
-            if path.extension().is_none_or(|ext| ext != "rs")
-                || path.canonicalize().unwrap()
-                    == std::path::Path::new(file!()).canonicalize().unwrap()
-            {
-                return;
-            }
-            let contents = std::fs::read_to_string(path).unwrap();
-            for line in contents.lines() {
-                if line.contains("dbg!") && !line.trim().starts_with("//") {
-                    panic!("File {} contains a dbg! macro", path.display());
-                }
-            }
-        });
         if crate::compile::invert::DEBUG {
             panic!("compile::invert::DEBUG is true");
         }
@@ -401,31 +372,6 @@ mod tests {
         }
     }
 
-    #[test]
-    fn no_printlns() {
-        recurse_dirs(std::path::Path::new("."), &|path| {
-            if path.extension().is_none_or(|ext| ext != "rs")
-                || path.canonicalize().unwrap()
-                    == std::path::Path::new(file!()).canonicalize().unwrap()
-                || path
-                    .components()
-                    .any(|c| c.as_os_str() == "main.rs" || c.as_os_str() == "profile.rs")
-            {
-                return;
-            }
-            let contents = std::fs::read_to_string(path).unwrap();
-            for line in contents.lines() {
-                if line.contains("println!")
-                    && !(line.trim().starts_with("//")
-                        || line.contains("eprintln!")
-                        || line.contains("// Allow println"))
-                {
-                    panic!("File {} contains a println! macro", path.display());
-                }
-            }
-        });
-    }
-
     #[test]
     fn external_bind_before() {
         let mut comp = Compiler::new();
diff --git a/src/main.rs b/src/main.rs
@@ -1,3 +1,4 @@
+#![allow(clippy::print_stdout)]
 #[cfg(not(feature = "binary"))]
 compile_error!("To compile the uiua interpreter binary, you must enable the `binary` feature flag");
 
@@ -36,7 +37,7 @@ static PRESSED_CTRL_C: AtomicBool = AtomicBool::new(false);
 static WATCH_CHILD: Lazy<Mutex<Option<Child>>> = Lazy::new(Default::default);
 
 fn fail<T>(e: UiuaError) -> T {
-    println!("{}", e.report());
+    eprintln!("{}", e.report());
     exit(1)
 }
 
diff --git a/src/profile.rs b/src/profile.rs
@@ -1,3 +1,4 @@
+#![allow(clippy::print_stdout)]
 #[macro_export]
 #[doc(hidden)]
 macro_rules! profile_function {
diff --git a/src/run.rs b/src/run.rs
@@ -274,9 +274,10 @@ impl Uiua {
         take(&mut self.rt.reports)
     }
     /// Print all pending reports
+    #[allow(clippy::print_stdout)]
     pub fn print_reports(&mut self) {
         for report in self.take_reports() {
-            println!("{report}"); // Allow println
+            println!("{report}");
         }
     }
     /// Take the assembly
@@ -790,11 +791,11 @@ impl Uiua {
                 Ok(())
             }
         };
+        #[allow(clippy::print_stdout)]
         if self.rt.time_instrs {
             let end_time = self.rt.backend.now();
             let padding = self.rt.call_stack.len().saturating_sub(1) * 2;
-            #[rustfmt::skip]
-            println!( // Allow println
+            println!(
                 "  ⏲{:padding$}{:.2}ms - {}",
                 "",
                 end_time - self.rt.last_time,
diff --git a/src/run_prim.rs b/src/run_prim.rs
@@ -2052,7 +2052,7 @@ mod tests {
                     {
                         continue;
                     }
-                    println!("{prim} example:\n{}", ex.input); // Allow println
+                    println!("{prim} example:\n{}", ex.input);
                     let mut env = Uiua::with_backend(SafeSys::with_thread_spawning());
                     match env.run_str(&ex.input) {
                         Ok(mut comp) => {
diff --git a/src/sys/native.rs b/src/sys/native.rs
@@ -642,6 +642,7 @@ impl SysBackend for NativeSys {
     fn allow_thread_spawning(&self) -> bool {
         true
     }
+    #[allow(clippy::print_stdout)]
     #[cfg(all(feature = "terminal_image", feature = "image"))]
     fn show_image(&self, image: image::DynamicImage, _label: Option<&str>) -> Result<(), String> {
         let (_width, _height) = if let Some((w, h)) = terminal_size() {
@@ -1210,27 +1211,28 @@ impl SysBackend for NativeSys {
         NATIVE_SYS.git_paths.insert(url.to_string(), res.clone());
         res
     }
+    #[allow(clippy::print_stdout)]
     fn breakpoint(&self, env: &Uiua) -> Result<bool, String> {
         if !self.output_enabled() {
             return Ok(true);
         }
         match env.span() {
-            #[rustfmt::skip]
-            Span::Code(span) => println!( // Allow println
+            Span::Code(span) => println!(
                 "{} at {span} {}",
                 "&b".truecolor(237, 94, 106),
                 "(press enter to continue)".bright_black()
             ),
             Span::Builtin => {}
         }
-        println!(); // Allow println
+        println!();
         print_stack(env.stack(), true);
-        println!(); // Allow println
+        println!();
         _ = stdin().read_line(&mut String::new());
         Ok(true)
     }
 }
 
+#[allow(clippy::print_stdout)]
 #[doc(hidden)]
 pub fn print_stack(stack: &[Value], color: bool) {
     #[cfg(feature = "window")]
@@ -1244,8 +1246,7 @@ pub fn print_stack(stack: &[Value], color: bool) {
         )
         .send();
         _ = Request::ClearBeforeNext.send();
-        #[rustfmt::skip]
-        println!( // Allow println
+        println!(
             "{} value{} displayed in window",
             stack.len(),
             if stack.len() == 1 { "" } else { "s" }
@@ -1257,7 +1258,7 @@ pub fn print_stack(stack: &[Value], color: bool) {
     }
     if stack.len() == 1 || !color {
         for value in stack {
-            println!("{}", value.show()); // Allow println
+            println!("{}", value.show());
         }
         return;
     }
@@ -1276,6 +1277,6 @@ pub fn print_stack(stack: &[Value], color: bool) {
             5 => (w, b, w),
             _ => unreachable!(),
         };
-        println!("{}", value.show().truecolor(r, g, b)); // Allow println
+        println!("{}", value.show().truecolor(r, g, b));
     }
 }
diff --git a/tests_ffi/.clippy.toml b/tests_ffi/.clippy.toml
@@ -0,0 +1 @@
+../.clippy.toml
diff --git a/tests_ffi/Cargo.toml b/tests_ffi/Cargo.toml
@@ -7,5 +7,8 @@ version = "0.1.0"
 crate-type = ["cdylib"]
 name = "ffi_lib"
 
+[lints]
+workspace = true
+
 [dependencies]
 uiua.path = ".."

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ pub const DEBUG: bool = false;`
`17`	`17`	`macro_rules! dbgln {`
`18`	`18`	`($($arg:tt)*) => {`
`19`	`19`	`if DEBUG {`
`20`		`- println!($($arg)*); // Allow println`
	`20`	`+ println!($($arg)*);`
`21`	`21`	`}`
`22`	`22`	`}`
`23`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ pub(crate) const DEBUG: bool = false;`
`32`	`32`	`macro_rules! dbgln {`
`33`	`33`	`($($arg:tt)*) => {`
`34`	`34`	`if crate::compile::invert::DEBUG {`
`35`		`- println!($($arg)*); // Allow println`
	`35`	`+ println!($($arg)*);`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`}`