lint: fix clippy::pedantic (3 entries)

Author: magistau

Cargo.toml

@@ -17,10 +17,6 @@ print_stdout = "warn"
 print_stderr = "allow"
 dbg_macro = "warn"
 pedantic = {level = "warn", priority = -1}
-case_sensitive_file_extension_comparisons = "allow"  # 3
-cloned_instead_of_copied = "allow"  # 3
-ref_as_ptr = "allow"  # 3
-unsafe_derive_deserialize = "allow"  # 3
 doc_markdown = "allow"  # 5
 match_wildcard_for_single_variants = "allow"  # 5
 needless_continue = "allow"  # 5

pad/editor/src/backend.rs

@@ -491,7 +491,10 @@ impl SysBackend for WebBackend {
             .replace("github.com", "raw.githubusercontent.com")
             .replace("src/branch/master", "raw/branch/master");
 
-        if !url.ends_with(".ua") {
+        if !std::path::Path::new(&url)
+            .extension()
+            .is_some_and(|ext| ext.eq_ignore_ascii_case("ua"))
+        {
             url = format!("{url}/main/lib.ua");
         }
 
@@ -525,7 +528,10 @@ impl SysBackend for WebBackend {
                                 .iter()
                                 .filter_map(|entry| {
                                     let path = entry.get("path")?.as_str()?;
-                                    if path.ends_with(".ua") {
+                                    if Path::new(path)
+                                        .extension()
+                                        .is_some_and(|ext| ext.eq_ignore_ascii_case("ua"))
+                                    {
                                         Some(path.to_string())
                                     } else {
                                         None

parser/src/parse.rs

@@ -213,7 +213,7 @@ pub fn parse(
             errors,
             diagnostics,
             next_output_comment: 0,
-            start_addr: &base as *const u8 as usize,
+            start_addr: std::ptr::from_ref(&base) as usize,
         };
         let items = parser.items(ItemsKind::TopLevel);
         if parser.errors.is_empty() && parser.index < parser.tokens.len() {
@@ -1203,7 +1203,7 @@ impl Parser<'_> {
         #[cfg(target_arch = "wasm32")]
         const MAX_RECURSION_DEPTH: usize = 512 * 1024;
         let curr = 0u8;
-        let curr_addr = &curr as *const u8 as usize;
+        let curr_addr = std::ptr::from_ref(&curr) as usize;
         let diff = curr_addr.abs_diff(self.start_addr);
         let too_deep = diff > MAX_RECURSION_DEPTH;
         if too_deep {

src/algorithm/dyadic/search.rs

@@ -65,7 +65,7 @@ impl<T: ArrayValue> Array<T> {
                         result_data.push(is_member as u8);
                     }
                 }
-                let shape: Shape = elems.shape.iter().cloned().take(1).collect();
+                let shape: Shape = elems.shape.iter().copied().take(1).collect();
                 Array::new(shape, result_data)
             }
             Ordering::Greater => {

src/algorithm/table.rs

@@ -817,7 +817,7 @@ where
     let acc_slice = acc.make_mut();
     for a in a.data {
         let mut i = 0;
-        for b in b.data.iter().cloned() {
+        for b in b.data.iter().copied() {
             acc_slice[i] = f(acc_slice[i], a);
             i += 1;
             acc_slice[i] = f(acc_slice[i], b);

src/array.rs

@@ -24,6 +24,10 @@ use crate::{
 };
 
 /// Uiua's array type
+#[expect(
+    clippy::unsafe_derive_deserialize,
+    reason = "done through ArrayRep which is safe"
+)]
 #[derive(Clone, Serialize, Deserialize)]
 #[serde(
     from = "ArrayRep<T>",

src/compile/mod.rs

@@ -472,7 +472,7 @@ impl Compiler {
         }
 
         let base = 0u8;
-        self.start_addrs.push(&base as *const u8 as usize);
+        self.start_addrs.push(std::ptr::from_ref(&base) as usize);
         let res = self.catching_crash(input, |env| env.items(items, ItemCompMode::TopLevel));
         self.start_addrs.pop();
 
@@ -1206,7 +1206,7 @@ impl Compiler {
             };
         let start_addr = *self.start_addrs.first().unwrap();
         let curr = 0u8;
-        let curr_addr = &curr as *const u8 as usize;
+        let curr_addr = std::ptr::from_ref(&curr) as usize;
         let diff = curr_addr.abs_diff(start_addr);
         if diff > MAX_RECURSION_DEPTH {
             return Err(self.error(span.clone(), "Compilation recursion limit reached"));

src/ffi.rs

@@ -686,9 +686,13 @@ mod enabled {
                 (self.arg_data.last().unwrap().downcast_ref::<T>())
                     .unwrap_or_else(|| panic!("Value wasn't expected type {}", type_name::<T>())),
             ));
-            (self.arg_data.last().unwrap().downcast_ref::<T>())
-                .unwrap_or_else(|| panic!("Value wasn't expected type {}", type_name::<T>()))
-                as *const T as *mut ()
+            std::ptr::from_ref(
+                self.arg_data
+                    .last()
+                    .unwrap()
+                    .downcast_ref::<T>()
+                    .unwrap_or_else(|| panic!("Value wasn't expected type {}", type_name::<T>())),
+            ) as *mut ()
         }
         fn push_repr(&mut self, arg: Vec<u8>) -> *mut () {
             self.arg_data.push(Box::new(arg));
@@ -792,7 +796,7 @@ mod enabled {
                 .or_else(|| {
                     any.downcast_ref::<ListStorage<T>>().map(|(_, b)| {
                         dbgln!("  list type");
-                        (&b[0], Some(&b[0] as *const T as *mut T))
+                        (&b[0], Some(std::ptr::from_ref(&b[0]) as *mut T))
                     })
                 })
         }

src/main.rs

@@ -7,7 +7,7 @@ use std::{
     error::Error,
     fmt, fs,
     io::{self, stderr, stdin, stdout, BufRead, Write},
-    path::{is_separator, Path, PathBuf},
+    path::{Path, PathBuf},
     process::{exit, Child, Command, Stdio},
     sync::{
         atomic::{AtomicBool, Ordering},
@@ -123,12 +123,13 @@ fn main() {
         set_use_window(true);
         args.next();
     }
-    if let Some(path) = args
-        .next()
-        .filter(|arg| arg.ends_with(".ua") || arg.contains(is_separator))
-    {
+    if let Some(path) = args.next().map(PathBuf::from).filter(|arg| {
+        arg.extension()
+            .is_some_and(|ext| ext.eq_ignore_ascii_case("ua"))
+            || arg.components().count() > 1
+    }) {
         let args = args.collect();
-        run(path.as_ref(), args, false, None, None, None, false);
+        run(&path, args, false, None, None, None, false);
         return;
     }
 

src/shape.rs

@@ -9,6 +9,10 @@ use serde::*;
 use smallvec::SmallVec;
 
 /// Uiua's array shape type
+#[expect(
+    clippy::unsafe_derive_deserialize,
+    reason = "just a wrapper around SmallVec with no additional invariants"
+)]
 #[derive(Clone, PartialEq, Eq, PartialOrd, Ord, Hash, Default, Serialize, Deserialize)]
 #[serde(transparent)]
 pub struct Shape {