Skip to content

Commit 5990f88

Browse files
chore: Migrate to angular 20 (#527)
This pull request includes various updates across multiple files to streamline configurations, modernize dependencies, and remove unused code. Key changes include updates to Node.js versions in workflows, removal of the `ngu-carousel-e2e` project and its associated files, and improvements to Angular configurations. ### Workflow and Dependency Updates: * Updated Node.js versions in `.github/workflows/nodejs.yml` to include version `22` and in `.github/workflows/npm-publish.yml` to version `20`, ensuring compatibility with newer Node.js features. [[1]](diffhunk://#diff-e98936aa52a6dd7416e4296e9628456227d834f7245967383fd9ff80fd985dadL18-R18) [[2]](diffhunk://#diff-8a5ce8b612395836520d0655143f732d08e747af57f3cfe76b5e283600106240L24-R24) [[3]](diffhunk://#diff-8a5ce8b612395836520d0655143f732d08e747af57f3cfe76b5e283600106240L38-R38) ### Removal of `ngu-carousel-e2e` Project: * Completely removed the `ngu-carousel-e2e` project, including its Cypress configuration, ESLint rules, project schema, and all related test files. This cleanup eliminates unused testing infrastructure. [[1]](diffhunk://#diff-37b71680045a40a6d1b8544c18e461613afc6d1c7514665f45f347c22ac21688L1-L17) [[2]](diffhunk://#diff-15c991a824aa5dd87e56858c2d49ada2356dbb332f4e9f70ab64cf007098b140L1-L20) [[3]](diffhunk://#diff-51af146d79a69453ac935c521342f8639f9e4afd72b4232d1b8c556288166572L1-L16) [[4]](diffhunk://#diff-aa4b106d8326de265cb5f1770d7e3bd77fbe1db378d899ab67569a433c04f9e4L1-L13) [[5]](diffhunk://#diff-8ba266b996f5556bf6770d2f09aad160d445b476327f5d00fb9af4cb0118de92L1-L4) [[6]](diffhunk://#diff-045d43aa95b7835690f8cbe6fe195a53c71cad9365edc9c93da40371b3a8b167L1) [[7]](diffhunk://#diff-52fbee3faf4ff1495788ecc673ca75923e503ad25cd1b7ffdbe777d907716530L1-L31) [[8]](diffhunk://#diff-9cbedc07d1ac15a9bcc718d0e95fe084b84d69794d85832c33f3c493ad6b6b25L1-L17) [[9]](diffhunk://#diff-6a924783e1bc508219e16c8e2fa9e2aea2515dd5eb8f421f32b11e3f69d1aebfL1-L10) ### Angular Configuration Enhancements: * Updated `apps/ngu-carousel-example/project.json` to simplify JSON formatting and add a `continuous` flag for development configurations. [[1]](diffhunk://#diff-1c17283ee280f97c2f69cf7a48fd2d3afb3ecfb6514819b9aadb437c851c7eb7L35-R35) [[2]](diffhunk://#diff-1c17283ee280f97c2f69cf7a48fd2d3afb3ecfb6514819b9aadb437c851c7eb7L74-R73) [[3]](diffhunk://#diff-1c17283ee280f97c2f69cf7a48fd2d3afb3ecfb6514819b9aadb437c851c7eb7L94-R100) [[4]](diffhunk://#diff-1c17283ee280f97c2f69cf7a48fd2d3afb3ecfb6514819b9aadb437c851c7eb7L150-R150) * Replaced `provideExperimentalZonelessChangeDetection` with `provideZonelessChangeDetection` in `app.config.ts` to use the stable API. * Adjusted the import path for `provideServerRendering` in `app-server.config.ts` to reflect the latest Angular SSR module. ### Minor Improvements: * Simplified JSON formatting in `.all-contributorsrc` for better readability. [[1]](diffhunk://#diff-cb22095514d0cab1f755ae3a7902f7d64d10199da210fbd1eb2b29eb758b38d2L2-R2) [[2]](diffhunk://#diff-cb22095514d0cab1f755ae3a7902f7d64d10199da210fbd1eb2b29eb758b38d2L13-R137) * Added spacing in `README.md` for better badge alignment. * closes #525
1 parent 735c712 commit 5990f88

39 files changed

+14716
-7454
lines changed

.all-contributorsrc

Lines changed: 20 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
{
2-
"files": [
3-
"README.md"
4-
],
2+
"files": ["README.md"],
53
"imageSize": 100,
64
"commit": false,
75
"contributors": [
@@ -10,171 +8,133 @@
108
"name": "Code Veins",
119
"avatar_url": "https://avatars0.githubusercontent.com/u/47743769?v=4",
1210
"profile": "https://github.com/codeveins",
13-
"contributions": [
14-
"code"
15-
]
11+
"contributions": ["code"]
1612
},
1713
{
1814
"login": "mczachurski",
1915
"name": "Marcin Czachurski",
2016
"avatar_url": "https://avatars0.githubusercontent.com/u/6191974?v=4",
2117
"profile": "https://github.com/mczachurski",
22-
"contributions": [
23-
"code"
24-
]
18+
"contributions": ["code"]
2519
},
2620
{
2721
"login": "reed665",
2822
"name": "Alexander Buiko",
2923
"avatar_url": "https://avatars2.githubusercontent.com/u/4117678?v=4",
3024
"profile": "https://www.linkedin.com/in/alexander-buiko-16715282/",
31-
"contributions": [
32-
"code"
33-
]
25+
"contributions": ["code"]
3426
},
3527
{
3628
"login": "fridolin-koch",
3729
"name": "Frido Koch",
3830
"avatar_url": "https://avatars2.githubusercontent.com/u/1880828?v=4",
3931
"profile": "https://fkse.io",
40-
"contributions": [
41-
"code"
42-
]
32+
"contributions": ["code"]
4333
},
4434
{
4535
"login": "gimox",
4636
"name": "Giorgio Modoni",
4737
"avatar_url": "https://avatars3.githubusercontent.com/u/2871248?v=4",
4838
"profile": "https://github.com/gimox",
49-
"contributions": [
50-
"code"
51-
]
39+
"contributions": ["code"]
5240
},
5341
{
5442
"login": "faran312",
5543
"name": "faran312",
5644
"avatar_url": "https://avatars1.githubusercontent.com/u/27755518?v=4",
5745
"profile": "https://github.com/faran312",
58-
"contributions": [
59-
"code"
60-
]
46+
"contributions": ["code"]
6147
},
6248
{
6349
"login": "euangoddard",
6450
"name": "Euan Goddard",
6551
"avatar_url": "https://avatars1.githubusercontent.com/u/412672?v=4",
6652
"profile": "https://www.stockopedia.com/",
67-
"contributions": [
68-
"code"
69-
]
53+
"contributions": ["code"]
7054
},
7155
{
7256
"login": "santoshyadav198613",
7357
"name": "Santosh Yadav",
7458
"avatar_url": "https://avatars3.githubusercontent.com/u/11923975?v=4",
7559
"profile": "https://www.santoshyadav.dev",
76-
"contributions": [
77-
"code"
78-
]
60+
"contributions": ["code"]
7961
},
8062
{
8163
"login": "tiagomsmagalhaes",
8264
"name": "Tiago Magalhães",
8365
"avatar_url": "https://avatars1.githubusercontent.com/u/5302040?v=4",
8466
"profile": "http://tiagomagalha.es",
85-
"contributions": [
86-
"doc"
87-
]
67+
"contributions": ["doc"]
8868
},
8969
{
9070
"login": "samvloeberghs",
9171
"name": "Sam Vloeberghs",
9272
"avatar_url": "https://avatars3.githubusercontent.com/u/231618?v=4",
9373
"profile": "https://samvloeberghs.be",
94-
"contributions": [
95-
"doc"
96-
]
74+
"contributions": ["doc"]
9775
},
9876
{
9977
"login": "rat-matheson",
10078
"name": "rat-matheson",
10179
"avatar_url": "https://avatars0.githubusercontent.com/u/61026434?v=4",
10280
"profile": "https://github.com/rat-matheson",
103-
"contributions": [
104-
"code"
105-
]
81+
"contributions": ["code"]
10682
},
10783
{
10884
"login": "Yberion",
10985
"name": "Brandon Largeau",
11086
"avatar_url": "https://avatars.githubusercontent.com/u/4186385?v=4",
11187
"profile": "https://github.com/Yberion",
112-
"contributions": [
113-
"code"
114-
]
88+
"contributions": ["code"]
11589
},
11690
{
11791
"login": "arturovt",
11892
"name": "Artur Androsovych",
11993
"avatar_url": "https://avatars.githubusercontent.com/u/7337691?v=4",
12094
"profile": "http://ng-guru.io",
121-
"contributions": [
122-
"code"
123-
]
95+
"contributions": ["code"]
12496
},
12597
{
12698
"login": "chivesrs",
12799
"name": "chivesrs",
128100
"avatar_url": "https://avatars.githubusercontent.com/u/7110657?v=4",
129101
"profile": "https://github.com/chivesrs",
130-
"contributions": [
131-
"code"
132-
]
102+
"contributions": ["code"]
133103
},
134104
{
135105
"login": "luca-peruzzo",
136106
"name": "Luca Peruzzo",
137107
"avatar_url": "https://avatars.githubusercontent.com/u/69015314?v=4",
138108
"profile": "https://github.com/luca-peruzzo",
139-
"contributions": [
140-
"code"
141-
]
109+
"contributions": ["code"]
142110
},
143111
{
144112
"login": "va-stefanek",
145113
"name": "Mateusz Stefańczyk",
146114
"avatar_url": "https://avatars.githubusercontent.com/u/67691339?v=4",
147115
"profile": "https://houseofangular.io/",
148-
"contributions": [
149-
"code"
150-
]
116+
"contributions": ["code"]
151117
},
152118
{
153119
"login": "JeanMeche",
154120
"name": "Matthieu Riegler",
155121
"avatar_url": "https://avatars.githubusercontent.com/u/1300985?v=4",
156122
"profile": "http://riegler.fr",
157-
"contributions": [
158-
"review"
159-
]
123+
"contributions": ["review"]
160124
},
161125
{
162126
"login": "sasidharansd",
163127
"name": "Sasidharan SD",
164128
"avatar_url": "https://avatars.githubusercontent.com/u/47988127?v=4",
165129
"profile": "https://github.com/sasidharansd",
166-
"contributions": [
167-
"doc"
168-
]
130+
"contributions": ["doc"]
169131
},
170132
{
171133
"login": "jonplata",
172134
"name": "Jonatan Plata",
173135
"avatar_url": "https://avatars.githubusercontent.com/u/14810139?v=4",
174136
"profile": "https://github.com/jonplata",
175-
"contributions": [
176-
"code"
177-
]
137+
"contributions": ["code"]
178138
}
179139
],
180140
"contributorsPerLine": 7,

.github/workflows/nodejs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515

1616
strategy:
1717
matrix:
18-
node-version: ['20', '18.19.1']
18+
node-version: ['20', '22']
1919

2020
steps:
2121
- uses: actions/checkout@v4

.github/workflows/npm-publish.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
version: 9
2222
- uses: actions/setup-node@v4
2323
with:
24-
node-version: 18.13.0
24+
node-version: 20
2525
- run: pnpm install
2626

2727
publish-npm:
@@ -35,7 +35,7 @@ jobs:
3535
version: 9
3636
- uses: actions/setup-node@v4
3737
with:
38-
node-version: 18.13.0
38+
node-version: 20
3939
registry-url: https://registry.npmjs.org/
4040
scope: '@ngu'
4141
- name: Build and Publish

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,5 @@ testem.log
4747
.DS_Store
4848
Thumbs.db
4949
migrations.json
50+
.cursor/rules/nx-rules.mdc
51+
.github/instructions/nx.instructions.md

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
[![npm version](https://badge.fury.io/js/%40ngu%2Fcarousel.svg)](https://badge.fury.io/js/%40ngu%2Fcarousel)
66

77
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
8+
89
[![All Contributors](https://img.shields.io/badge/all_contributors-19-orange.svg?style=flat-square)](#contributors-)
10+
911
<!-- ALL-CONTRIBUTORS-BADGE:END -->
1012

1113
Angular Universal carousel

apps/ngu-carousel-e2e/.eslintrc.json

Lines changed: 0 additions & 17 deletions
This file was deleted.

apps/ngu-carousel-e2e/cypress.config.ts

Lines changed: 0 additions & 20 deletions
This file was deleted.

apps/ngu-carousel-e2e/project.json

Lines changed: 0 additions & 16 deletions
This file was deleted.

apps/ngu-carousel-e2e/src/e2e/app.cy.ts

Lines changed: 0 additions & 13 deletions
This file was deleted.

apps/ngu-carousel-e2e/src/fixtures/example.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

0 commit comments

Comments
 (0)