Sort release pull requests by merged time asc

Author: uiur

lib/github-client.js

@@ -161,6 +161,10 @@ GithubClient.prototype.collectReleasePRs = function (releasePR) {
         return result
       }, [])
 
+      prsToRelease.sort(function (a, b) {
+        return new Date(a.merged_at) - new Date(b.merged_at)
+      })
+
       return prsToRelease
     })
   })

test/github-client.js

@@ -143,16 +143,19 @@ describe('GithubClient', function () {
       .get('/repos/uiureo/awesome-app/pulls?state=closed&base=master&per_page=100&sort=updated&direction=desc')
       .reply(200, [
         { number: 10, head: { sha: '0' }, merged_at: null },
-        { number: 1, head: { sha: '1' }, merged_at: 'a' },
-        { number: 2, head: { sha: '2' }, merged_at: 'b' },
-        { number: 100, head: { sha: '100' }, merged_at: 'c' }
+        { number: 2, head: { sha: '2' }, merged_at: '2015-12-26T00:00:00Z' },
+        { number: 1, head: { sha: '1' }, merged_at: '2015-12-25T00:00:00Z' },
+        { number: 100, head: { sha: '100' }, merged_at: '2015-12-27T00:00:00Z' }
       ])
 
     it('returns prs that is going to be released', function (done) {
       this.client.collectReleasePRs({ number: 42 })
         .then(function (prs) {
           assert(prs.length === 2)
 
+          var numbers = prs.map(function (pr) { return pr.number })
+          assert.deepEqual(numbers, [1, 2], 'sorted by merged_at asc')
+
           done()
         }).catch(done)
     })