exclude bot account

Author: fmy

lib/github-client.js

@@ -173,7 +173,10 @@ GithubClient.prototype.collectReleasePRs = function (releasePR) {
 }
 
 GithubClient.prototype.assignReviewers = function (pr, prs) {
-  var reviewers = prs.map(pr => pr.assignee ? pr.assignee.login : pr.user.login)
+  var reviewers = prs
+    .map(pr => pr.assignee ? pr.assignee : pr.user)
+    .filter(user => user.type === 'User')
+    .map(user => user.login)
 
   return this.post(this.pullRequestEndpoint() + '/' + pr.number + '/requested_reviewers', { reviewers }).then(function (res) {
     return res.body

test/github-client.js

@@ -166,20 +166,23 @@ describe('GithubClient', function () {
   describe('#assignReviewers()', function () {
     const USER1 = 'pr1-owner'
     const USER2 = 'pr2-owner'
+    const BOT = 'bot'
     nock('https://api.github.com')
       .post('/repos/uiureo/awesome-app/pulls/42/requested_reviewers')
       .query(true)
-      .reply(200, {
-        requested_reviewers: [ { login: USER1 }, { login: USER2 } ]
-      })
+      .reply(200, (_, requestBody) => ({
+        requested_reviewers: requestBody.reviewers.map(login => ({ login }))
+      }))
 
     it('returns pr that has reviewers', function (done) {
       const prs = [
-        { assignee: { login: USER1 } },
-        { user: { login: USER2 } }
+        { assignee: { login: USER1, type: 'User' } },
+        { user: { login: USER2, type: 'User' } },
+        { user: { login: BOT, type: 'Bot' } }
       ]
       this.client.assignReviewers({ number: 42 }, prs)
         .then(function (pr) {
+          assert(pr.requested_reviewers.length === 2)
           assert(pr.requested_reviewers[0].login === USER1)
           assert(pr.requested_reviewers[1].login === USER2)