Skip to content

Commit beace39

Browse files
authored
Merge pull request #5 from shokai/squash-and-merge
support "squash and merge" PRs
2 parents ea8c7b4 + 14dd8ae commit beace39

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

lib/github-client.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,8 @@ GithubClient.prototype.collectReleasePRs = function (releasePR) {
155155
})
156156

157157
var prsToRelease = mergedPRs.reduce(function (result, pr) {
158-
if (shas.indexOf(pr.head.sha) !== -1) {
158+
if (shas.indexOf(pr.head.sha) > -1 ||
159+
shas.indexOf(pr.merge_commit_sha) > -1) {
159160
result.push(pr)
160161
}
161162

test/github-client.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,13 @@ describe('GithubClient', function () {
138138
.reply(200, [
139139
{ sha: '0' },
140140
{ sha: '1' },
141-
{ sha: '2' }
141+
{ sha: '2' },
142+
{ sha: '3' }
142143
])
143144
.get('/repos/uiureo/awesome-app/pulls?state=closed&base=master&per_page=100&sort=updated&direction=desc')
144145
.reply(200, [
145146
{ number: 10, head: { sha: '0' }, merged_at: null },
147+
{ number: 3, head: { sha: '_3' }, merged_at: '2015-12-27T00:00:00Z', merge_commit_sha: '3' },
146148
{ number: 2, head: { sha: '2' }, merged_at: '2015-12-26T00:00:00Z' },
147149
{ number: 1, head: { sha: '1' }, merged_at: '2015-12-25T00:00:00Z' },
148150
{ number: 100, head: { sha: '100' }, merged_at: '2015-12-27T00:00:00Z' }
@@ -151,10 +153,10 @@ describe('GithubClient', function () {
151153
it('returns prs that is going to be released', function (done) {
152154
this.client.collectReleasePRs({ number: 42 })
153155
.then(function (prs) {
154-
assert(prs.length === 2)
156+
assert(prs.length === 3)
155157

156158
var numbers = prs.map(function (pr) { return pr.number })
157-
assert.deepEqual(numbers, [1, 2], 'sorted by merged_at asc')
159+
assert.deepEqual(numbers, [1, 2, 3], 'sorted by merged_at asc')
158160

159161
done()
160162
}).catch(done)

0 commit comments

Comments
 (0)