Still can't figure out how to change aspect ratio!

[lectricas]

Hi. There are two options we have from camerax that allow us to change aspect ration:

Preview preview = new Preview.Builder()
            .setTargetAspectRatio(AspectRatio.RATIO_4_3)
            .build();
ImageCapture imageCapture = new ImageCapture.Builder()
            .setTargetAspectRatio(AspectRatio.RATIO_4_3)
            .build();

The first one change the viewfinder ration, the second one changes the output picture ratio.
Can I change aspect ratio only for ImageCapture and not for preview?

What code should I write to change aspect ration in both cases?

I haven't found any setTargetAspectRatio lines inside library code.

[lectricas]

Also, doing this:

CameraPreview(
        imageCaptureTargetSize = remember { ImageTargetSize(AspectRatio.RATIO_4_3) },

has no effect.

Output image ratio is still 2_1 as my phone screen is really long and thin.

[ravenfeld]

I'm also trying to make ratio and I can't find how to do it.
I see that modifying the CameraPreview Modifier works but the camera keeps focusing and is very slow.

CameraPreview(
                modifier = Modifier.aspectRatio(9/16f),
)

[ravenfeld]

So it works to play with the modifier and if you have a button to modify then you have to recompose CameraPreview.
It works if you use version 0.4.2 version 0.4.3 has a problem but related to cameraX according to my tests on the sample.

[sceneren]

When I use Modifier, the preview screen is very stuck. Device is Samsung S22

[ravenfeld]

We don't have a solution? I can't upgrade currently without removing the ratio functionality.

[ravenfeld]

I don't know why but if I delete the following line there is no more lag problem

     cameraState.isStreaming = state == PreviewView.StreamState.STREAMING          

For the moment, what I understand is that as soon as we set cameraState.isStreaming to true, it goes back to IDLE, then STREAMING, then IDLE in a loop.

[ravenfeld]

I found a fix, I'm trying to make a PR quickly. The problem is that with each recomposition we give back the scaleType which redraws and suddenly puts the camera back in idle then in streaming and suddenly we recompose and so on, we just must not set if it is already the right value.

                    if(this.scaleType != scaleType.type) {
                        this.scaleType = scaleType.type
                    }

[ujizin]

Hello! Sorry for the delay, it’s been a bit difficult to keep Camposer up to date, but I'll try to provide better support moving forward.

Unfortunately, Camposer doesn’t provide an API to preview the aspect ratio from CameraX. For now, using Modifier.aspectRatio might be the best approach

The imageCaptureTargetSize = remember { ImageTargetSize(AspectRatio.RATIO_4_3) } is supposed to work for output image capture, but I'll look into this further later

and @ravenfeld Nice catch! I’ll merge this and create a patch version with the performance fix, thanks for contributing to Camposer! 🙏

[ujizin]

This feature has been added in Camposer v1 through CamFormat.

You can find more details in the documentation: https://ujizin.github.io/Camposer/camera-format/

Although If the requirement is only related to the visual UI, it is also possible to configure it using the CameraPreview modifier.

I will close this ticket for now. If anything is missing or not working as expected, please feel free to reopen it.