Skip to content

Commit 88be68f

Browse files
Fix the navigation issue using history object
1 parent e74cfbf commit 88be68f

File tree

9 files changed

+4
-43
lines changed

9 files changed

+4
-43
lines changed

client/src/actions/index.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,9 @@ export const getDataViaAPI = (type, uri) => async dispatch => {
109109
{isLoading: false, data: JSON.parse(JSON.stringify(response.data))}
110110
});
111111
if (LOAD_FILTER_PRODUCTS.localeCompare(type) === 0) {
112-
window.history.pushState('', '', uri)
112+
if(window.location.search.localeCompare(uri.split("/products")[1]) !== 0) {
113+
history.push(uri)
114+
}
113115
}
114116
} else {
115117
dispatch({type: type, payload: {isLoading: false, statusCode: BAD_REQUEST_ERROR_CODE}});
@@ -146,4 +148,4 @@ export const loadFilterAttributes = filterQuery => async dispatch => {
146148
log.info(`[ACTION]: unable to fetch response for Filter API`)
147149
}
148150
}
149-
};
151+
};

client/src/components/routes/checkout/checkout.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {withStyles} from '@material-ui/core/styles';
88
import MuiAccordion from '@material-ui/core/Accordion';
99
import MuiAccordionSummary from '@material-ui/core/AccordionSummary';
1010
import MuiAccordionDetails from '@material-ui/core/AccordionDetails';
11-
import {useBackButton} from "../../../hooks/backButtonHook";
1211

1312
const checkoutBgColor = "#80808033"
1413

@@ -58,8 +57,6 @@ const AccordionDetails = withStyles((theme) => ({
5857
function Checkout() {
5958
const [expanded, setExpanded] = React.useState('panel1');
6059

61-
useBackButton()
62-
6360
const handleChange = (panel) => (event, newExpanded) => {
6461
setExpanded(newExpanded ? panel : false);
6562
};

client/src/components/routes/detail/productDetails.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {makeStyles} from "@material-ui/core/styles";
1818
import Spinner from "../../ui/spinner";
1919
import {InternalServerError} from "../../ui/error/internalServerError";
2020
import {BadRequest} from "../../ui/error/badRequest";
21-
import {useBackButton} from "../../../hooks/backButtonHook";
2221

2322
export const useButtonStyles = makeStyles(() => ({
2423
buttonStartIcon: {
@@ -37,8 +36,6 @@ function ProductDetails(props) {
3736
const addToCart = useSelector(state => state.addToCartReducer)
3837
const [productQuantity, setProductQuantity] = useState(1)
3938

40-
useBackButton()
41-
4239
useEffect(() => {
4340
log.info(`[Product Detail] Component did mount selectProductDetail = ${JSON.stringify(selectProductDetail)}`)
4441
log.info(`[Product Detail] Component did mount selectedProduct = ${JSON.stringify(selectedProduct)}`)

client/src/components/routes/home/home.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,11 @@ import Spinner from "../../ui/spinner";
1414
import {HTTPError} from "../../ui/error/httpError";
1515
import {LOAD_HOME_PAGE, HOME_PAGE_DATA_API, HOME_PAGE_API_OBJECT_LEN} from "../../../actions/types";
1616
import {BadRequest} from "../../ui/error/badRequest";
17-
import {useBackButton} from "../../../hooks/backButtonHook";
1817

1918
const Home = props => {
2019
const {hover} = useSelector(state => state.tabHoverEventReducer)
2120
const homeAPIData = useSelector(state => state.homePageDataReducer)
2221

23-
useBackButton()
24-
2522
// Main screen API is loaded during Component Did mount
2623
useEffect(() => {
2724
log.info("[Home]: component did mount and home API is called.")

client/src/components/routes/login.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,9 @@ import Icon from "semantic-ui-react/dist/commonjs/elements/Icon";
88
import {Typography} from "@material-ui/core";
99
import {Link} from "react-router-dom";
1010
import log from "loglevel";
11-
import {useBackButton} from "../../hooks/backButtonHook";
1211

1312
const Login = (props) => {
1413

15-
useBackButton()
16-
1714
const onSubmit = formValues => {
1815
log.debug(`[LoginScreen]: formValues = ${JSON.stringify(formValues)}`)
1916
props.signIn(formValues)

client/src/components/routes/product/product.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import BottomNavBar from "./bottomNavBar";
1414
import history from "../../../history";
1515
import BreadcrumbsSection from "../../ui/breadcrumbs";
1616
import {SearchMatchesNotFound} from "../../ui/error/searchMatchesNotFound";
17-
import {useBackButton} from "../../../hooks/backButtonHook";
1817
import {useDispatch} from "react-redux";
1918
import {SAVE_QUERY_STATUS} from "../../../actions/types";
2019

@@ -53,8 +52,6 @@ function Product() {
5352
}
5453
}, [])
5554

56-
useBackButton()
57-
5855
if (history.location.pathname.localeCompare('/products') !== 0
5956
|| !history.location.search.startsWith('?q=')) {
6057
return <SearchMatchesNotFound/>

client/src/components/routes/shoppingBag.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import PriceDetails from "./priceDetails";
2525
import Modal from "../../components/ui/modal";
2626
import _ from 'lodash';
2727
import Hidden from "@material-ui/core/Hidden";
28-
import {useBackButton} from "../../hooks/backButtonHook";
2928

3029
const modalWidth = 430
3130

@@ -45,8 +44,6 @@ function ShoppingBag(props) {
4544
return idList
4645
}
4746

48-
useBackButton()
49-
5047
useEffect(() => {
5148
log.info("[ShoppingBag] Component will mount... addToCart = " + JSON.stringify(addToCart))
5249

client/src/components/routes/signUp.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,13 @@ import {signUp} from "../../actions";
55
import {Grid} from "semantic-ui-react";
66
import {StyledLoginScreenGrid} from "../../styles/semanticUI/customStyles";
77
import log from "loglevel";
8-
import {useBackButton} from "../../hooks/backButtonHook";
98

109
const SignUp = (props) => {
1110
const onSubmit = formValues => {
1211
log.debug(`[SignUpScreen]: onSubmit formValues = ${JSON.stringify(formValues)}`)
1312
props.signUp(formValues)
1413
};
1514

16-
useBackButton()
17-
1815
log.info(`[SignUpScreen]: Rendering SignUpScreen Component`)
1916
return (
2017
<StyledLoginScreenGrid centered>

client/src/hooks/backButtonHook.js

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)