[ISSUE] custom script regression with 4.0.x

[lolorc]

custom script doesn't work anymore.
=> W AFWall : Rejecting non-iptables rule: /data/local/afwall-custom.sh

my custom script does generate dynamic rules, adding them one by one in the UI is not a solution.

I've read #1433 and the CHANGELOG, I don't see the custom script changes are a breaking change.
is it a bug or regression that won't be fixed ?
I've also downgraded to 3.6.

Cheers,

[ukanth]

Custom script will work if you make follow this format

. /data/local/afwall-custom.sh

dot space <script>

[lolorc]

ok, thanks for the syntax detail.

that's weird, when there's an error with the custom script, killing afwall is not enough, you have to remove the ". script.sh" from the UI, then restart afwall and enable firewall again, then try again.

for now I've not been able to make it work at all, the only script that works is an empty one.
if I use

#!/bin/sh
exit 0

if fails with no detail in the log.

to be honest I haven't checked the changes in the source, do you parse the custom script, is it really evaluated, is the shebang useful, or do you expect to parse its output ?

cheers

[de-es]

@lolorc My - now working - custom script is at /data/local/afwall-custom.sh made executable. It doesn't have a shebang.

that's weird, when there's an error with the custom script, killing afwall is not enough, you have to remove the ". script.sh" from the UI, then restart afwall and enable firewall again, then try again.

Sometimes it helps to disable the firewall, flush the rules in "Show Rules" and enable the firewall again.

[lolorc]

I've managed to make it work by running my complex afwall-custom.sh from a simple script I'm now using with afwall.
funny it does pass "-w 5" to my script :-)