Skip to content

Commit 23adfd3

Browse files
committed
Need spaces around bash subs
1 parent 3dfcfe2 commit 23adfd3

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.github/workflows/distribute_package.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,11 @@ jobs:
7171
if: ${{ startsWith(github.ref, 'refs/tags') }}
7272
run: |
7373
# Set tag from GitHub: using git describe for tags inside the run script
74-
# seems not working
75-
echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
74+
# seems not working - I think this because you need _annotated_ tags
75+
# for git describe i.e. you need to tag the release as so:
76+
# 'git tag vX.Y.Z -a -m "YOUR MESSAGE HERE"'
77+
# echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
78+
echo "VERSION=${ git describe }" >> $GITHUB_ENV
7679
7780
- name: Install dependencies
7881
run: |
@@ -134,7 +137,7 @@ jobs:
134137
# for git describe i.e. you need to tag the release as so:
135138
# 'git tag vX.Y.Z -a -m "YOUR MESSAGE HERE"'
136139
# echo "VERSION=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
137-
echo "VERSION=${git describe}" >> $GITHUB_ENV
140+
echo "VERSION=${ git describe }" >> $GITHUB_ENV
138141
139142
# setuptools_scm workaround for https://github.com/pypa/setuptools_scm/issues/455
140143
- name: Disable local version identifier on develop CI

0 commit comments

Comments
 (0)