Skip to content

Commit 188915d

Browse files
marc-hbnashif
authored andcommitted
check_compliance.py: add comment explaining why Kconfig prints twice
Also explain why we can't just "warn_to_stderr=False" our way out of it. Signed-off-by: Marc Herbert <[email protected]>
1 parent c5db6d7 commit 188915d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

scripts/ci/check_compliance.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,10 @@ def parse_kconfig(self):
253253
os.environ["KCONFIG_WARN_UNDEF"] = "y"
254254

255255
try:
256+
# Note this will both print warnings to stderr _and_ return
257+
# them: so some warnings might get printed
258+
# twice. "warn_to_stderr=False" could unfortunately cause
259+
# some (other) warnings to never be printed.
256260
return kconfiglib.Kconfig()
257261
except kconfiglib.KconfigError as e:
258262
self.add_failure(str(e))

0 commit comments

Comments
 (0)