Skip to content

Commit 321203a

Browse files
ulfalizernashif
authored andcommitted
check_compliance: Put the undef. symbol checks next to each other
Makes more sense. Signed-off-by: Ulf Magnusson <[email protected]>
1 parent 7fa749f commit 321203a

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

scripts/ci/check_compliance.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,8 @@ def run(self):
194194

195195
kconf = self.parse_kconfig()
196196

197-
self.check_no_undef_within_kconfig(kconf)
198197
self.check_top_menu_not_too_long(kconf)
198+
self.check_no_undef_within_kconfig(kconf)
199199
self.check_no_undef_outside_kconfig(kconf)
200200

201201
def get_modules(self, modules_file):
@@ -262,18 +262,6 @@ def parse_kconfig(self):
262262
self.add_failure(str(e))
263263
raise EndTest
264264

265-
def check_no_undef_within_kconfig(self, kconf):
266-
"""
267-
Checks that there are no references to undefined Kconfig symbols within
268-
the Kconfig files
269-
"""
270-
undef_ref_warnings = "\n\n\n".join(warning for warning in kconf.warnings
271-
if "undefined symbol" in warning)
272-
273-
if undef_ref_warnings:
274-
self.add_failure("Undefined Kconfig symbols:\n\n"
275-
+ undef_ref_warnings)
276-
277265
def check_top_menu_not_too_long(self, kconf):
278266
"""
279267
Checks that there aren't too many items in the top-level menu (which
@@ -297,6 +285,18 @@ def check_top_menu_not_too_long(self, kconf):
297285
entries, then bump the 'max_top_items' variable in {}.
298286
""".format(max_top_items, n_top_items, __file__))
299287

288+
def check_no_undef_within_kconfig(self, kconf):
289+
"""
290+
Checks that there are no references to undefined Kconfig symbols within
291+
the Kconfig files
292+
"""
293+
undef_ref_warnings = "\n\n\n".join(warning for warning in kconf.warnings
294+
if "undefined symbol" in warning)
295+
296+
if undef_ref_warnings:
297+
self.add_failure("Undefined Kconfig symbols:\n\n"
298+
+ undef_ref_warnings)
299+
300300
def check_no_undef_outside_kconfig(self, kconf):
301301
"""
302302
Checks that there are no references to undefined Kconfig symbols

0 commit comments

Comments
 (0)