Merge pull request #365 from n0tlikethatplz/fix-ipage-evaluate-signature

Update IPage/IFrame evaluate function signature to match Page

Author: blakebyrnes

specification/agent/browser/IFrame.ts

@@ -53,6 +53,7 @@ export interface IFrame extends ITypedEventEmitter<IFrameEvents> {
       retriesWaitingForLoad?: number;
       returnByValue?: boolean;
       includeCommandLineAPI?: boolean;
+      timeoutMs?: number;
     },
   ): Promise<T>;
 

specification/agent/browser/IPage.ts

@@ -38,7 +38,7 @@ export interface IPage extends ITypedEventEmitter<IPageEvents> {
 
   setJavaScriptEnabled(enabled: boolean): Promise<void>;
 
-  evaluate<T>(expression: string): Promise<T>;
+  evaluate<T>(expression: string, options?: { timeoutMs?: number; isolatedFromWebPageEnvironment?: boolean }): Promise<T>;
   addNewDocumentScript(
     script: string,
     isolateFromWebPageEnvironment: boolean,