Chunk downloads seem not very useful for common users and it's confusing our users. Disable it.

Author: chusopr

core/src/plugins/access.fs/class.fsAccessDriver.php

@@ -258,51 +258,6 @@ public function switchAction($action, $httpVars, $fileVars)
 
                 break;
 
-            case "prepare_chunk_dl" :
-
-                $chunkCount = intval($httpVars["chunk_count"]);
-                $fileId = $this->urlBase.$selection->getUniqueFile();
-                $sessionKey = "chunk_file_".md5($fileId.time());
-                $totalSize = $this->filesystemFileSize($fileId);
-                $chunkSize = intval ( $totalSize / $chunkCount );
-                $realFile  = call_user_func(array($this->wrapperClassName, "getRealFSReference"), $fileId, true);
-                $chunkData = array(
-                    "localname"	  => basename($fileId),
-                    "chunk_count" => $chunkCount,
-                    "chunk_size"  => $chunkSize,
-                    "total_size"  => $totalSize,
-                    "file_id"	  => $sessionKey
-                );
-
-                $_SESSION[$sessionKey] = array_merge($chunkData, array("file"=>$realFile));
-                HTMLWriter::charsetHeader("application/json");
-                print(json_encode($chunkData));
-
-                $node = $selection->getUniqueNode($this);
-                AJXP_Controller::applyHook("node.read", array(&$node));
-
-                break;
-
-            case "download_chunk" :
-
-                $chunkIndex = intval($httpVars["chunk_index"]);
-                $chunkKey = $httpVars["file_id"];
-                $sessData = $_SESSION[$chunkKey];
-                $realFile = $sessData["file"];
-                $chunkSize = $sessData["chunk_size"];
-                $offset = $chunkSize * $chunkIndex;
-                if ($chunkIndex == $sessData["chunk_count"]-1) {
-                    // Compute the last chunk real length
-                    $chunkSize = $sessData["total_size"] - ($chunkSize * ($sessData["chunk_count"]-1));
-                    if (call_user_func(array($this->wrapperClassName, "isRemote"))) {
-                        register_shutdown_function("unlink", $realFile);
-                    }
-                }
-                $this->readFile($realFile, "force-download", $sessData["localname"].".".sprintf("%03d", $chunkIndex+1), false, false, true, $offset, $chunkSize);
-
-
-            break;
-
             case "compress" :
                     // Make a temp zip and send it as download
                     $loggedUser = AuthService::getLoggedUser();
@@ -1912,4 +1867,4 @@ function staticExtractArchiveItemPostCallback($status, $data){
     function staticExtractArchiveItemPreCallback($status, $data){
         return fsAccessDriver::$currentZipOperationHandler->extractArchiveItemPreCallback($status, $data);
     }
-}
+}

core/src/plugins/access.fs/fsActions.xml

@@ -857,83 +857,6 @@
                 </serverCallback>
                 </processing>
         </action>
-        <action name="prepare_chunk_dl">
-            <rightsContext noUser="true" userLogged="only" read="true" write="false" adminOnly="false"/>
-            <processing>
-                <serverCallback methodName="switchAction" developerComment="Use the filesize of the file to generate an list of pieces to be downloaded using {download_chunk} action. Will generate a unique file_id to be used later.">
-                    <input_param description="Selected node" name="node" type="path" mandatory="true"/>
-                    <input_param description="Number of pieces to create for the file" name="chunk_count" type="integer"/>
-                    <output type="application/json"/>
-                </serverCallback>
-            </processing>
-        </action>
-        <action name="download_chunk">
-            <gui text="397" title="398" src="download_manager.png" iconClass="icon-cloud-download" hasAccessKey="false">
-                <context selection="true" dir="" recycle="false"
-                         actionBar="true" contextMenu="false" infoPanel="true" actionBarGroup="change">
-                </context>
-                <selectionContext dir="false" file="true" recycle="false" unique="true"/>
-            </gui>
-            <rightsContext noUser="true" userLogged="only" read="true" write="false" adminOnly=""/>
-            <processing>
-                <clientCallback prepareModal="true"><![CDATA[
-					var userSelection = ajaxplorer.getUserSelection();
-
-					var loadFunc = function(oForm){
-						var dObject = oForm.down('div[id="multiple_download_container"]');
-						var legendDiv = oForm.down('div.dialogLegend');
-						legendDiv.next("br").remove();
-						legendDiv.update(MessageHash[399]+'<br>'+MessageHash[401]+'<a href="'+MessageHash[402]+'" target="_blank">'+MessageHash[402]+'</a>');
-						dObject.insert({before:'\
-							<div class="dialogButtons" id="chunk_dl_form" style="height:36px;"> \
-								<span style="display:inline-block;float:left;margin-top: 11px;margin-left: 4px;margin-right: 4px;">'+MessageHash[400]+'</span> <input type="text" style="float:left;margin-top:5px; text-align:right; width:30px;height:24px;" name="chunk_count" id="chunk_count" value="4"> \
-								<input type="image" style="float:left;" id="dl_form_submit" src="AJXP_THEME_FOLDER/images/actions/22/dialog_ok_apply.png" height="22" width="22" title="OK" class="dialogButton dialogFocus">\
-							</div> \
-						'});
-						$("dl_form_submit").observe("click", function(e){
-							Event.stop(e);
-							var conn = new Connexion();
-							conn.addParameter("get_action", "prepare_chunk_dl");
-							conn.addParameter("chunk_count", $("chunk_count").value );
-							conn.addParameter("file", userSelection.getUniqueNode().getPath());
-							var downloader = new MultiDownloader(dObject, '');
-							conn.onComplete = function(transp){
-								var chunkData = transp.responseJSON;
-								downloader.setDownloadUrl(ajxpServerAccessPath+'&action=download_chunk&file_id='+chunkData.file_id);
-								downloader.triggerEnd = function(){hideLightBox();};
-								for(var i=0; i<chunkData.chunk_count;i++){
-									downloader.addListRow("&chunk_index=" + i, chunkData.localname + " (part " + (i + 1) + ")");
-								}
-								downloader.removeOnLoad();
-							};
-							downloader.setOnLoad();
-							conn.sendAsync();
-						});
-					};
-					var closeFunc = function(){
-						hideLightBox();
-						return false;
-					};
-					modal.showDialogForm('Download Multiple', 'multi_download_form', loadFunc, closeFunc, null, true);
-
-					]]></clientCallback>
-                <clientForm id="multi_download_form"><![CDATA[
-					<div id="multi_download_form" title="AJXP_MESSAGE[118]"  box_width="345">
-					<div class="dialogLegend">AJXP_MESSAGE[119]</div><br/>
-					<div id="multiple_download_container"></div>
-					<form style="display:inline;" action="index.php" method="GET" id="download_form" target="download_iframe">
-						<input type="hidden" name="get_action" value="download">
-						<input type="hidden" name="secure_token" value="">
-					</form>
-					<iframe id="download_iframe" name="download_iframe" style="display:none"></iframe>
-					</div>]]>
-                </clientForm>
-                <serverCallback methodName="switchAction" developerComment="Chunk file into pieces before downloading the pieces. Can be handy for problematic and limited servers.">
-                    <input_param description="Unique key generated during the {prepare_chunk_dl} action." name="file_id" type="string"/>
-                    <input_param description="Position of the file to download" name="chunk_index" type="integer"/>
-                </serverCallback>
-            </processing>
-        </action>
         <action name="purge">
             <processing>
                 <serverCallback methodName="switchAction" developerComment="If the workspace has a PURGE configured parameter, finds the expired files and delete them. Can be typically called from command line."></serverCallback>