Skip to content

Commit 27c3428

Browse files
committed
Added label to PageHeader. Style fixes.
1 parent 8115709 commit 27c3428

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

package.components.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@umami/components",
3-
"version": "0.125.0",
3+
"version": "0.127.0",
44
"description": "Umami React components.",
55
"author": "Mike Cao <mike@mikecao.com>",
66
"license": "MIT",

src/app/(main)/SideNav.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ export function SideNav(props: SidebarProps) {
6969
<SidebarItem
7070
label={label}
7171
icon={icon}
72-
isSelected={pathname.endsWith(path)}
72+
isSelected={pathname.includes(path)}
7373
role="button"
7474
/>
7575
</Link>

src/app/(main)/links/[linkId]/LinkHeader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export function LinkHeader() {
1010
const link = useLink();
1111

1212
return (
13-
<PageHeader title={link.name} description={link.url} icon={<Link />}>
13+
<PageHeader title={link.name} description={link.url} icon={<Link />} marginBottom="3">
1414
<LinkButton href={getSlugUrl(link.slug)} target="_blank">
1515
<Icon>
1616
<ExternalLink />

src/app/(main)/pixels/[pixelId]/PixelHeader.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export function PixelHeader() {
1010
const pixel = usePixel();
1111

1212
return (
13-
<PageHeader title={pixel.name} description={pixel.slug} icon={<Grid2x2 />}>
13+
<PageHeader title={pixel.name} icon={<Grid2x2 />} marginBottom="3">
1414
<LinkButton href={getSlugUrl(pixel.slug)} target="_blank">
1515
<Icon>
1616
<ExternalLink />

src/app/(main)/websites/WebsitesPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export function WebsitesPage() {
1414
return (
1515
<PageBody>
1616
<Column gap="6" margin="2">
17-
<PageHeader title={formatMessage(labels.websites)} label={'back'} description={'Websites'}>
17+
<PageHeader title={formatMessage(labels.websites)}>
1818
<WebsiteAddButton teamId={teamId} />
1919
</PageHeader>
2020
<Panel>

src/components/common/PageHeader.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@ export function PageHeader({
3838
)}
3939
{title && <Heading size="4">{title}</Heading>}
4040
</Row>
41-
{description && <Text color="muted">{description}</Text>}
41+
{description && (
42+
<Text color="muted" truncate style={{ maxWidth: 600 }} title={description}>
43+
{description}
44+
</Text>
45+
)}
4246
</Column>
4347
<Row justifyContent="flex-end">{children}</Row>
4448
</Row>

0 commit comments

Comments
 (0)