Skip to content

Commit 2f5e692

Browse files
committed
Merge remote-tracking branch 'origin/dev' into dev
2 parents 805b3ec + 5bbc1a9 commit 2f5e692

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

src/app/(main)/websites/[websiteId]/(reports)/attribution/AttributionPage.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ export function AttributionPage({ websiteId }: { websiteId: string }) {
3636
defaultValue={type}
3737
onChange={setType}
3838
>
39-
<ListItem id="path">{formatMessage(labels.page)}</ListItem>
40-
<ListItem id="event">{formatMessage(labels.event)}</ListItem>
39+
<ListItem id="path">{formatMessage(labels.viewedPage)}</ListItem>
40+
<ListItem id="event">{formatMessage(labels.triggeredEvent)}</ListItem>
4141
</Select>
4242
</Column>
4343
<Column>

src/components/input/FilterEditForm.tsx

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { useState } from 'react';
2-
import { Column, Tabs, TabList, Tab, TabPanel, Row, Button } from '@umami/react-zen';
31
import { useFilters, useMessages, useNavigation } from '@/components/hooks';
42
import { FieldFilters } from '@/components/input/FieldFilters';
53
import { SegmentFilters } from '@/components/input/SegmentFilters';
4+
import { Button, Column, Row, Tab, TabList, TabPanel, Tabs } from '@umami/react-zen';
5+
import { useState } from 'react';
66

77
export interface FilterEditFormProps {
88
websiteId?: string;
@@ -13,6 +13,7 @@ export interface FilterEditFormProps {
1313
export function FilterEditForm({ websiteId, onChange, onClose }: FilterEditFormProps) {
1414
const {
1515
query: { segment, cohort },
16+
pathname,
1617
} = useNavigation();
1718
const { filters } = useFilters();
1819
const { formatMessage, labels } = useMessages();
@@ -22,6 +23,7 @@ export function FilterEditForm({ websiteId, onChange, onClose }: FilterEditFormP
2223
const panelProps = {
2324
style: { height: 500 },
2425
};
26+
const excludeFilters = pathname.includes('/pixels') || pathname.includes('/links');
2527

2628
const handleReset = () => {
2729
setCurrentFilters([]);
@@ -48,11 +50,20 @@ export function FilterEditForm({ websiteId, onChange, onClose }: FilterEditFormP
4850
<Tabs>
4951
<TabList>
5052
<Tab id="fields">{formatMessage(labels.fields)}</Tab>
51-
<Tab id="segments">{formatMessage(labels.segments)}</Tab>
52-
<Tab id="cohorts">{formatMessage(labels.cohorts)}</Tab>
53+
{!excludeFilters && (
54+
<>
55+
<Tab id="segments">{formatMessage(labels.segments)}</Tab>
56+
<Tab id="cohorts">{formatMessage(labels.cohorts)}</Tab>
57+
</>
58+
)}
5359
</TabList>
5460
<TabPanel id="fields" {...panelProps}>
55-
<FieldFilters websiteId={websiteId} value={currentFilters} onChange={setCurrentFilters} />
61+
<FieldFilters
62+
websiteId={websiteId}
63+
value={currentFilters}
64+
onChange={setCurrentFilters}
65+
exclude={excludeFilters ? ['path', 'title', 'hostname', 'tag', 'event'] : []}
66+
/>
5667
</TabPanel>
5768
<TabPanel id="segments" {...panelProps}>
5869
<SegmentFilters

0 commit comments

Comments
 (0)