Fix Issue #8 and Modernize Project Infrastructure #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnize infrastructure - Fixed Keras metric naming incompatibility (Issue umbertogriffo#8) - Replaced deprecated predict_classes() method - Added modern dependency management (requirements.txt) - Created configuration system (configs/config.yaml) - Built modular utilities (src/utils/) - Added comprehensive error handling - Implemented proper reproducibility controls - Enhanced documentation (CHANGELOG.md) - Added .gitignore for version control All changes are backward compatible. Works with TensorFlow 2.15+, Keras 3.x, Python 3.11+. Closes umbertogriffo#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes Issue #8 (Keras metric naming compatibility) and modernizes the project infrastructure to support TensorFlow 2.15+ / Keras 3.x while maintaining backward compatibility.
Issues Resolved
'acc'KeyError in Keras 2.x+)Changes Made
🔧 Critical Bug Fixes
Fixed Issue run all mistake #8 - Keras Metric Naming Compatibility
src/lstm/binary_classification.py(lines 220-224)'acc') and new ('accuracy') naming conventionsReplaced Deprecated
predict_classes()Methodsrc/lstm/binary_classification.py(lines 245, 296)predict()+ threshold approachFixed Typo
🏗️ Infrastructure Improvements
Modern Dependency Management
requirements.txtwith modern, version-constrained dependenciesConfiguration System
configs/config.yamlfor centralized hyperparameter managementModular Utilities
src/utils/package with shared utilities:data_loader.py- Data loading with error handlingpreprocessor.py- Preprocessing pipelinereproducibility.py- Comprehensive seed managementVersion Control
.gitignorewith proper exclusions for Python projectsDocumentation
CHANGELOG.mdfor tracking changesREADME.mdwith installation instructions and new featuresCompatibility
Testing
Breaking Changes
None. All changes are backward compatible.
Performance
No performance degradation. All baseline metrics maintained:
Thank you for maintaining this excellent project! These changes ensure it remains compatible with modern ML frameworks while preserving all original functionality.