Just use a getter only - some feedback from CMS core team Nikolaj L

Warren Buckley · Warren Buckley · commit 9c48ccd0d861 · 2022-08-23T15:39:32.000+01:00
diff --git a/Our.Umbraco.TagHelpers/Services/IUmbracoTagHelperCacheKeys.cs b/Our.Umbraco.TagHelpers/Services/IUmbracoTagHelperCacheKeys.cs
@@ -5,6 +5,6 @@ namespace Our.Umbraco.TagHelpers.Services
 {
 	public interface IUmbracoTagHelperCacheKeys
 	{
-		Dictionary<string, CacheTagKey> CacheKeys { get; set; }
+		Dictionary<string, CacheTagKey> CacheKeys { get; }
 	}
 }
diff --git a/Our.Umbraco.TagHelpers/Services/UmbracoTagHelperCacheKeys.cs b/Our.Umbraco.TagHelpers/Services/UmbracoTagHelperCacheKeys.cs
@@ -5,6 +5,6 @@ namespace Our.Umbraco.TagHelpers.Services
 {
 	public class UmbracoTagHelperCacheKeys : IUmbracoTagHelperCacheKeys
 	{
-		public Dictionary<string,CacheTagKey> CacheKeys { get; set; } = new Dictionary<string,CacheTagKey>();
+		public Dictionary<string,CacheTagKey> CacheKeys { get; } = new Dictionary<string,CacheTagKey>();
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,6 @@ namespace Our.Umbraco.TagHelpers.Services`
`5`	`5`	`{`
`6`	`6`	`public interface IUmbracoTagHelperCacheKeys`
`7`	`7`	`{`
`8`		`- Dictionary<string, CacheTagKey> CacheKeys { get; set; }`
	`8`	`+ Dictionary<string, CacheTagKey> CacheKeys { get; }`
`9`	`9`	`}`
`10`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,6 @@ namespace Our.Umbraco.TagHelpers.Services`
`5`	`5`	`{`
`6`	`6`	`public class UmbracoTagHelperCacheKeys : IUmbracoTagHelperCacheKeys`
`7`	`7`	`{`
`8`		`- public Dictionary<string,CacheTagKey> CacheKeys { get; set; } = new Dictionary<string,CacheTagKey>();`
	`8`	`+ public Dictionary<string,CacheTagKey> CacheKeys { get; } = new Dictionary<string,CacheTagKey>();`
`9`	`9`	`}`
`10`	`10`	`}`