Minor changes needed after a bit of manual testing

Warren Buckley · Warren Buckley · commit d30dfb1f7d2f · 2022-08-05T13:50:35.000+01:00
diff --git a/Our.Umbraco.TagHelpers/LinkTagHelper.cs b/Our.Umbraco.TagHelpers/LinkTagHelper.cs
@@ -19,12 +19,16 @@ public override async Task ProcessAsync(TagHelperContext context, TagHelperOutpu
                 return;
             }
 
+            // If the <our-link /> is self closing
+            // Ensure that our <a></a> always has a matching end tag
+            output.TagMode = TagMode.StartTagAndEndTag;
+
             output.TagName = "a";
             var childContent = await output.GetChildContentAsync();
 
             // If we use the TagHelper <umb-link></umb-link>
             // Without child DOM elements then it will use the Link Name property inside the <a> it generates
-            if (childContent == null)
+            if (childContent.IsEmptyOrWhiteSpace)
             {
                 output.Content.SetContent(Link.Name);
             }

Original file line number	Diff line number	Diff line change
`@@ -19,12 +19,16 @@ public override async Task ProcessAsync(TagHelperContext context, TagHelperOutpu`
`19`	`19`	`return;`
`20`	`20`	`}`
`21`	`21`
	`22`	`+ // If the <our-link /> is self closing`
	`23`	`+ // Ensure that our <a></a> always has a matching end tag`
	`24`	`+ output.TagMode = TagMode.StartTagAndEndTag;`
	`25`	`+`
`22`	`26`	`output.TagName = "a";`
`23`	`27`	`var childContent = await output.GetChildContentAsync();`
`24`	`28`
`25`	`29`	`// If we use the TagHelper <umb-link></umb-link>`
`26`	`30`	`// Without child DOM elements then it will use the Link Name property inside the <a> it generates`
`27`		`- if (childContent == null)`
	`31`	`+ if (childContent.IsEmptyOrWhiteSpace)`
`28`	`32`	`{`
`29`	`33`	`output.Content.SetContent(Link.Name);`
`30`	`34`	`}`