Skip to content

Commit 2967033

Browse files
Merge remote-tracking branch 'refs/remotes/origin/develop'
2 parents 073b9f3 + 2bcd2f6 commit 2967033

26 files changed

+183
-114
lines changed

README.md

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,15 @@ Update `~/Config/FileSystemProviders.config` replacing the default provider with
5858
Defaults to 365 days.
5959
-->
6060
<add key="maxDays" value="365" />
61+
<!--
62+
When true this allows the VirtualPathProvider to use the default "media" route prefix regardless
63+
of the container name.
64+
-->
65+
<add key="useDefaultRoute" value="true" />
66+
<!--
67+
When true blob containers will be private instead of public what means that you can't access the original blob file directly from its blob url.
68+
-->
69+
<add key="usePrivateContainer" value="false" />
6170
</Parameters>
6271
</Provider>
6372
</FileSystemProviders>
@@ -124,6 +133,7 @@ In `Web.config` create the new application keys and post fix each key with the `
124133
<add key="AzureBlobFileSystem.RootUrl:media" value="http://[myAccountName].blob.core.windows.net/" />
125134
<add key="AzureBlobFileSystem.MaxDays:media" value="365" />
126135
<add key="AzureBlobFileSystem.UseDefaultRoute:media" value="true" />
136+
<add key="AzureBlobFileSystem.UsePrivateContainer" value="false" />
127137
```
128138

129139
## Virtual Path Provider
@@ -164,7 +174,8 @@ For **Umbraco v7.5+ you must add the the StaticFileHandler** to the new Web.conf
164174

165175
## Combining with ImageProcessor
166176

167-
As of ImageProcessor.Web version [4.3.2](https://www.nuget.org/packages/ImageProcessor.Web/4.3.2) a new [`IImageService`](http://imageprocessor.org/imageprocessor-web/extending/#iimageservice) implementation has been available called `CloudImageService`. To enable that service and pull images directly from the cloud simply install the [configuration package](https://www.nuget.org/packages/ImageProcessor.Web.Config/) and replace the `CloudImageService`setting with the following:
177+
As of ImageProcessor.Web version [4.3.2](https://www.nuget.org/packages/ImageProcessor.Web/4.3.2) a new [`IImageService`](http://imageprocessor.org/imageprocessor-web/extending/#iimageservice) implementation has been available called `CloudImageService`. To enable that service and pull images directly from
178+
the cloud simply install the [configuration package](https://www.nuget.org/packages/ImageProcessor.Web.Config/) and replace the `CloudImageService`setting with the following:
168179

169180
```xml
170181
<?xml version="1.0"?>
@@ -181,6 +192,8 @@ As of ImageProcessor.Web version [4.3.2](https://www.nuget.org/packages/ImagePro
181192
</services>
182193
</security>
183194
```
195+
**Note** The `CloudImageService`is not compatible with the FileSystemProvider when using private storage. You will have to build your own `IImageService` implementation.
196+
184197
If using a version of ImageProcessor.Web version [4.5.0](https://www.nuget.org/packages/ImageProcessor.Web/4.5.0) the configuration details will need to be configured as follows:
185198

186199
```xml

appveyor.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
os: Visual Studio 2015
22

33
# Version format
4-
version: 0.5.7.{build}
4+
version: 0.5.8.{build}
55

66
cache:
77
- src\packages -> **\packages.config # preserve "packages" directory in the root of build folder but will reset it if packages.config is modified

build/transforms/FileSystemProviders.config.install.xdt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222
of the container name.
2323
-->
2424
<add key="useDefaultRoute" value="true" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
25+
<!--
26+
When true blob containers will be private instead of public what means that you can't access the original blob file directly from its blob url.
27+
-->
28+
<add key="usePrivateContainer" value="false" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
2529
</Parameters>
2630
</Provider>
2731
<!--

src/.nuget/packages.config

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<packages>
3+
<package id="StyleCop.Analyzers" version="1.0.0" />
4+
</packages>

src/UmbracoFileSystemProviders.Azure.Installer/Configurator/Controllers/Configure.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ configApp.controller("Loader", function ($scope, $http, $log) {
3838
};
3939

4040
$scope.getInputType = function (param) {
41-
return param.toUpperCase() === "USEDEFAULTROUTE" ? "checkbox" : "text";
41+
return param.toUpperCase() === "USEDEFAULTROUTE" || param.toUpperCase() === "USEPRIVATECONTAINER" ? "checkbox" : "text";
4242
};
4343
});

src/UmbracoFileSystemProviders.Azure.Installer/InstallerController.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ public InstallerStatus PostParameters(IEnumerable<Parameter> parameters)
7777
string connection = newParameters.SingleOrDefault(k => k.Key == "connectionString").Value;
7878
string containerName = newParameters.SingleOrDefault(k => k.Key == "containerName").Value;
7979
bool useDefaultRoute = bool.Parse(newParameters.SingleOrDefault(k => k.Key == "useDefaultRoute").Value);
80+
bool usePrivateContainer = bool.Parse(newParameters.SingleOrDefault(k => k.Key == "usePrivateContainer").Value);
8081
string rootUrl = newParameters.SingleOrDefault(k => k.Key == "rootUrl").Value;
8182

8283
if (!TestAzureCredentials(connection, containerName))

src/UmbracoFileSystemProviders.Azure.Installer/Models/Parameter.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ namespace Our.Umbraco.FileSystemProviders.Azure.Installer.Models
1313
public class Parameter
1414
{
1515
/// <summary>
16-
/// The key.
16+
/// Gets or sets the key.
1717
/// </summary>
1818
[JsonProperty("key")]
1919
public string Key { get; set; }
2020

2121
/// <summary>
22-
/// The value.
22+
/// Gets or sets the value.
2323
/// </summary>
2424
[JsonProperty("value")]
2525
public string Value { get; set; }

src/UmbracoFileSystemProviders.Azure.Installer/PackageActions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ private bool Transform(string packageName, XmlNode xmlData, bool uninstall = fal
6767

6868
string sourceDocFileName = VirtualPathUtility.ToAbsolute(file);
6969

70-
// The xdt file used for tranformation
70+
// The xdt file used for tranformation
7171
string fileEnd = "install.xdt";
7272
if (uninstall)
7373
{

src/UmbracoFileSystemProviders.Azure.Installer/Properties/AssemblyInfo.cs

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,13 @@
1-
using System.Reflection;
1+
// <copyright file="AssemblyInfo.cs" company="James Jackson-South, Jeavon Leopold, and contributors">
2+
// Copyright (c) James Jackson-South, Jeavon Leopold, and contributors. All rights reserved.
3+
// Licensed under the Apache License, Version 2.0.
4+
// </copyright>
5+
6+
using System.Reflection;
27
using System.Runtime.CompilerServices;
38
using System.Runtime.InteropServices;
49

5-
// General Information about an assembly is controlled through the following
10+
// General Information about an assembly is controlled through the following
611
// set of attributes. Change these attribute values to modify the information
712
// associated with an assembly.
813
[assembly: AssemblyTitle("UmbracoFileSystemProviders.Azure.Installer")]
@@ -14,8 +19,8 @@
1419
[assembly: AssemblyTrademark("")]
1520
[assembly: AssemblyCulture("")]
1621

17-
// Setting ComVisible to false makes the types in this assembly not visible
18-
// to COM components. If you need to access a type in this assembly from
22+
// Setting ComVisible to false makes the types in this assembly not visible
23+
// to COM components. If you need to access a type in this assembly from
1924
// COM, set the ComVisible attribute to true on that type.
2025
[assembly: ComVisible(false)]
2126

src/UmbracoFileSystemProviders.Azure.Installer/Properties/VersionInfo.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
// <copyright file="VersionInfo.cs" company="James Jackson-South">
2-
// Copyright (c) James Jackson-South. All rights reserved.
1+
// <copyright file="VersionInfo.cs" company="James Jackson-South, Jeavon Leopold, and contributors">
2+
// Copyright (c) James Jackson-South, Jeavon Leopold, and contributors. All rights reserved.
33
// Licensed under the Apache License, Version 2.0.
44
// </copyright>
55

@@ -8,11 +8,11 @@
88
// Version information for an assembly consists of the following four values:
99
//
1010
// Major Version
11-
// Minor Version
11+
// Minor Version
1212
// Build Number
1313
// Revision
1414
//
15-
// You can specify all the values or you can default the Build and Revision Numbers
15+
// You can specify all the values or you can default the Build and Revision Numbers
1616
// by using the '*' as shown below:
1717
// [assembly: AssemblyVersion("0.5.0.10")]
1818
[assembly: AssemblyVersion("0.5.0.0")]

0 commit comments

Comments
 (0)