Fix issue with useDefaultRoute parsing to bool

Author: Jeavon

src/UmbracoFileSystemProviders.Azure.Tests/AzureBlobFileSystemTestsBase.cs

@@ -41,11 +41,12 @@ public AzureBlobFileSystem CreateAzureBlobFileSystem(bool disableVirtualPathProv
             string rootUrl = "http://127.0.0.1:10000/devstoreaccount1/";
             string connectionString = "UseDevelopmentStorage=true";
             string maxDays = "30";
+            string useDefaultRoute = "true";
 
             Mock<ILogHelper> logHelper = new Mock<ILogHelper>();
             Mock<IMimeTypeResolver> mimeTypeHelper = new Mock<IMimeTypeResolver>();
 
-            return new AzureBlobFileSystem(containerName, rootUrl, connectionString, maxDays, true)
+            return new AzureBlobFileSystem(containerName, rootUrl, connectionString, maxDays, useDefaultRoute)
             {
                 FileSystem =
                 {

src/UmbracoFileSystemProviders.Azure/AzureBlobFileSystem.cs

@@ -25,7 +25,7 @@ public class AzureBlobFileSystem : IFileSystem
         /// <param name="rootUrl">The root url.</param>
         /// <param name="connectionString">The connection string.</param>
         public AzureBlobFileSystem(string containerName, string rootUrl, string connectionString)
-            : this(containerName, rootUrl, connectionString, "365", true)
+            : this(containerName, rootUrl, connectionString, "365", "true")
         {
         }
 
@@ -37,7 +37,7 @@ public AzureBlobFileSystem(string containerName, string rootUrl, string connecti
         /// <param name="connectionString">The connection string.</param>
         /// <param name="maxDays">The maximum number of days to cache blob items for in the browser.</param>
         /// <param name="useDefaultRoute">Whether to use the default "media" route in the url independent of the blob container.</param>
-        public AzureBlobFileSystem(string containerName, string rootUrl, string connectionString, string maxDays, bool useDefaultRoute)
+        public AzureBlobFileSystem(string containerName, string rootUrl, string connectionString, string maxDays, string useDefaultRoute)
         {
             this.FileSystem = AzureFileSystem.GetInstance(containerName, rootUrl, connectionString, maxDays, useDefaultRoute);
         }

src/UmbracoFileSystemProviders.Azure/AzureFileSystem.cs

@@ -156,7 +156,7 @@ private AzureFileSystem(string containerName, string rootUrl, string connectionS
         /// <param name="maxDays">The maximum number of days to cache blob items for in the browser.</param>
         /// <param name="useDefaultRoute">Whether to use the default "media" route in the url independent of the blob container.</param>
         /// <returns>The <see cref="AzureFileSystem"/></returns>
-        public static AzureFileSystem GetInstance(string containerName, string rootUrl, string connectionString, string maxDays, bool useDefaultRoute)
+        public static AzureFileSystem GetInstance(string containerName, string rootUrl, string connectionString, string maxDays, string useDefaultRoute)
         {
             lock (Locker)
             {
@@ -168,7 +168,13 @@ public static AzureFileSystem GetInstance(string containerName, string rootUrl,
                         max = 365;
                     }
 
-                    fileSystem = new AzureFileSystem(containerName, rootUrl, connectionString, max, useDefaultRoute);
+                    bool defaultRoute;
+                    if (!bool.TryParse(useDefaultRoute, out defaultRoute))
+                    {
+                        defaultRoute = true;
+                    }
+
+                    fileSystem = new AzureFileSystem(containerName, rootUrl, connectionString, max, defaultRoute);
                 }
 
                 return fileSystem;