Skip to content

Commit 4ba3aa6

Browse files
authored
Merge pull request #146 from callumbwhyte/blob-hostname-https-v8
[V8] Setting blob hostnames to use HTTPS by default
2 parents 175a8ae + ccce39b commit 4ba3aa6

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ In `Web.config` create the new application keys
5050
```xml
5151
<add key="AzureBlobFileSystem.ConnectionString:media" value="DefaultEndpointsProtocol=https;AccountName=[myAccountName];AccountKey=[myAccountKey]" />
5252
<add key="AzureBlobFileSystem.ContainerName:media" value="media" />
53-
<add key="AzureBlobFileSystem.RootUrl:media" value="http://[myAccountName].blob.core.windows.net/" />
53+
<add key="AzureBlobFileSystem.RootUrl:media" value="https://[myAccountName].blob.core.windows.net/" />
5454
<add key="AzureBlobFileSystem.MaxDays:media" value="365" />
5555
<add key="AzureBlobFileSystem.UseDefaultRoute:media" value="true" />
5656
<add key="AzureBlobFileSystem.UsePrivateContainer:media" value="false" />
@@ -123,7 +123,7 @@ the cloud replace the `CloudImageService`setting with the following:
123123
<setting key="Container" value="media"/>
124124
<setting key="MaxBytes" value="8194304"/>
125125
<setting key="Timeout" value="30000"/>
126-
<setting key="Host" value="http://[myAccountName].blob.core.windows.net/media"/>
126+
<setting key="Host" value="https://[myAccountName].blob.core.windows.net/media"/>
127127
</settings>
128128
</service>
129129
</services>

build/transforms/security.config.install.xdt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
<settings xdt:Transform="InsertIfMissing">
77
<setting key="Container" value="media" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
88
<setting key="MaxBytes" value="8194304" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
9-
<setting key="Timeout" value="30000" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing"/>
10-
<setting key="Host" value="http://[myAccountName].blob.core.windows.net" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing"/>
9+
<setting key="Timeout" value="30000" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
10+
<setting key="Host" value="https://[myAccountName].blob.core.windows.net" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
1111
</settings>
1212
</service>
1313
</services>

src/UmbracoFileSystemProviders.Azure.Installer/config/imageprocessor/security.config

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
<!--Disable the LocalFileImageService and enable this one when using virtual paths. -->
66
<!--<service name="CloudImageService" type="ImageProcessor.Web.Services.CloudImageService, ImageProcessor.Web">
77
<settings>
8-
<setting key="Container" value=""/>
9-
<setting key="MaxBytes" value="8194304"/>
10-
<setting key="Timeout" value="30000"/>
11-
<setting key="Host" value="http://yourhost.com/"/>
8+
<setting key="Container" value="" />
9+
<setting key="MaxBytes" value="8194304" />
10+
<setting key="Timeout" value="30000" />
11+
<setting key="Host" value="https://yourhost.com/" />
1212
</settings>
1313
</service>-->
1414
<service prefix="remote.axd" name="RemoteImageService" type="ImageProcessor.Web.Services.RemoteImageService, ImageProcessor.Web">

src/UmbracoFileSystemProviders.Azure.Tests/FileSystemProviders.upgrade.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<Provider alias="media" type="Our.Umbraco.FileSystemProviders.Azure.AzureBlobFileSystem, Our.Umbraco.FileSystemProviders.Azure">
66
<Parameters>
77
<add key="containerName" value="media"/>
8-
<add key="rootUrl" value="http://existing123456789.blob.core.windows.net/"/>
8+
<add key="rootUrl" value="https://existing123456789.blob.core.windows.net/"/>
99
<add key="connectionString"
1010
value="DefaultEndpointsProtocol=https;AccountName=existing123456789;AccountKey=existingKey"/>
1111
<!--

0 commit comments

Comments
 (0)