Skip to content

Commit eced146

Browse files
committed
Setting blob hostnames to use HTTPS by default
1 parent d994a5a commit eced146

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ Update `~/Config/FileSystemProviders.config` replacing the default provider with
5353
<Provider alias="media" type="Our.Umbraco.FileSystemProviders.Azure.AzureBlobFileSystem, Our.Umbraco.FileSystemProviders.Azure">
5454
<Parameters>
5555
<add key="containerName" value="media" />
56-
<add key="rootUrl" value="http://[myAccountName].blob.core.windows.net/" />
56+
<add key="rootUrl" value="https://[myAccountName].blob.core.windows.net/" />
5757
<add key="connectionString" value="DefaultEndpointsProtocol=https;AccountName=[myAccountName];AccountKey=[myAccountKey]"/>
5858
<!--
5959
Optional configuration value determining the maximum number of days to cache items in the browser.
@@ -132,7 +132,7 @@ In `Web.config` create the new application keys and post fix each key with the `
132132
```xml
133133
<add key="AzureBlobFileSystem.ConnectionString:media" value="DefaultEndpointsProtocol=https;AccountName=[myAccountName];AccountKey=[myAccountKey]" />
134134
<add key="AzureBlobFileSystem.ContainerName:media" value="media" />
135-
<add key="AzureBlobFileSystem.RootUrl:media" value="http://[myAccountName].blob.core.windows.net/" />
135+
<add key="AzureBlobFileSystem.RootUrl:media" value="https://[myAccountName].blob.core.windows.net/" />
136136
<add key="AzureBlobFileSystem.MaxDays:media" value="365" />
137137
<add key="AzureBlobFileSystem.UseDefaultRoute:media" value="true" />
138138
<add key="AzureBlobFileSystem.UsePrivateContainer:media" value="false" />
@@ -188,7 +188,7 @@ the cloud simply install the [configuration package](https://www.nuget.org/packa
188188
<settings>
189189
<setting key="MaxBytes" value="8194304"/>
190190
<setting key="Timeout" value="30000"/>
191-
<setting key="Host" value="http://[myAccountName].blob.core.windows.net/media/"/>
191+
<setting key="Host" value="https://[myAccountName].blob.core.windows.net/media/"/>
192192
</settings>
193193
</service>
194194
</services>
@@ -208,7 +208,7 @@ If using a version of ImageProcessor.Web version [4.5.0](https://www.nuget.org/p
208208
<setting key="Container" value="media"/>
209209
<setting key="MaxBytes" value="8194304"/>
210210
<setting key="Timeout" value="30000"/>
211-
<setting key="Host" value="http://[myAccountName].blob.core.windows.net/media"/>
211+
<setting key="Host" value="https://[myAccountName].blob.core.windows.net/media"/>
212212
</settings>
213213
</service>
214214
</services>

build/transforms/FileSystemProviders.config.install.xdt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<Provider alias="media" type="Our.Umbraco.FileSystemProviders.Azure.AzureBlobFileSystem, Our.Umbraco.FileSystemProviders.Azure" xdt:Locator="Match(type)" xdt:Transform="InsertIfMissing">
1111
<Parameters xdt:Transform="InsertIfMissing">
1212
<add key="containerName" value="media" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
13-
<add key="rootUrl" value="http://[myAccountName].blob.core.windows.net/" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
13+
<add key="rootUrl" value="https://[myAccountName].blob.core.windows.net/" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
1414
<add key="connectionString" value="DefaultEndpointsProtocol=https;AccountName=[myAccountName];AccountKey=[myAccountKey]" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
1515
<!--
1616
Optional configuration value determining the maximum number of days to cache items in the browser.

build/transforms/security.config.install.xdt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<setting key="Container" value="media" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
88
<setting key="MaxBytes" value="8194304" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing" />
99
<setting key="Timeout" value="30000" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing"/>
10-
<setting key="Host" value="http://[myAccountName].blob.core.windows.net" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing"/>
10+
<setting key="Host" value="https://[myAccountName].blob.core.windows.net" xdt:Locator="Match(key)" xdt:Transform="InsertIfMissing"/>
1111
</settings>
1212
</service>
1313
</services>

src/UmbracoFileSystemProviders.Azure.Installer/config/imageprocessor/security.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<setting key="Container" value=""/>
99
<setting key="MaxBytes" value="8194304"/>
1010
<setting key="Timeout" value="30000"/>
11-
<setting key="Host" value="http://yourhost.com/"/>
11+
<setting key="Host" value="https://yourhost.com/"/>
1212
</settings>
1313
</service>-->
1414
<service prefix="remote.axd" name="RemoteImageService" type="ImageProcessor.Web.Services.RemoteImageService, ImageProcessor.Web">

src/UmbracoFileSystemProviders.Azure.Tests/FileSystemProviders.upgrade.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<Provider alias="media" type="Our.Umbraco.FileSystemProviders.Azure.AzureBlobFileSystem, Our.Umbraco.FileSystemProviders.Azure">
66
<Parameters>
77
<add key="containerName" value="media"/>
8-
<add key="rootUrl" value="http://existing123456789.blob.core.windows.net/"/>
8+
<add key="rootUrl" value="https://existing123456789.blob.core.windows.net/"/>
99
<add key="connectionString"
1010
value="DefaultEndpointsProtocol=https;AccountName=existing123456789;AccountKey=existingKey"/>
1111
<!--

src/UmbracoFileSystemProviders.Azure.Tests/InstallerTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public void CheckXdtNumberOfParameters()
4444
public void CheckUpgradeRootUrlParameter()
4545
{
4646
IEnumerable<Parameter> parameters = InstallerController.GetParametersFromXdt("..\\..\\build\\transforms\\FileSystemProviders.config.install.xdt", "FileSystemProviders.upgrade.config");
47-
Assert.AreEqual("http://existing123456789.blob.core.windows.net/", parameters.Single(k => k.Key == "rootUrl").Value);
47+
Assert.AreEqual("https://existing123456789.blob.core.windows.net/", parameters.Single(k => k.Key == "rootUrl").Value);
4848
}
4949

5050
/// <summary>
@@ -54,7 +54,7 @@ public void CheckUpgradeRootUrlParameter()
5454
public void CheckNewInstallDefaultConfig()
5555
{
5656
IEnumerable<Parameter> parameters = InstallerController.GetParametersFromXdt("..\\..\\build\\transforms\\FileSystemProviders.config.install.xdt", "FileSystemProviders.default.config");
57-
Assert.AreEqual("http://[myAccountName].blob.core.windows.net/", parameters.Single(k => k.Key == "rootUrl").Value);
57+
Assert.AreEqual("https://[myAccountName].blob.core.windows.net/", parameters.Single(k => k.Key == "rootUrl").Value);
5858
}
5959
}
6060
}

0 commit comments

Comments
 (0)