Skip to content

Commit d3d789f

Browse files
committed
Add metadata constants
1 parent 627d37e commit d3d789f

7 files changed

+19
-12
lines changed

src/Our.Umbraco.GraphQL/Constants.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,12 @@ namespace Our.Umbraco.GraphQL
33
public class Constants
44
{
55
public const string ProductName = "Our.Umbraco.GraphQL";
6+
7+
public class Metadata
8+
{
9+
public const string AllowedAtRoot = "allowedAtRoot";
10+
public const string AllowedChildren = "allowedChildren";
11+
public const string ContentTypeAlias = "contentTypeAlias";
12+
}
613
}
714
}

src/Our.Umbraco.GraphQL/GraphQLAuthenticationExtensions.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,17 @@ public static void SetPermissions(this FieldType type, string documentTypeAlias,
8080
public static void SetPermissions(this FieldType type, GraphType graphType, bool isBuiltInProperty = false)
8181
{
8282
// The graph type should have the doc type alias set in the meta data so we're accessing it from that
83-
var doctypeAlias = graphType.GetMetadata<string>("documentTypeAlias");
83+
var doctypeAlias = graphType.GetMetadata<string>(Constants.Metadata.ContentTypeAlias);
8484
type.SetPermissions(doctypeAlias, isBuiltInProperty);
8585
}
8686

8787
public static void SetDoctypeMetadata(this FieldType type, string doctypeAlias)
8888
{
89-
var currentAlias = type.GetMetadata<List<string>>("documentTypeAlias");
89+
var currentAlias = type.GetMetadata<List<string>>(Constants.Metadata.ContentTypeAlias);
9090

9191
if (currentAlias == null)
9292
{
93-
type.Metadata["documentTypeAlias"] = doctypeAlias;
93+
type.Metadata[Constants.Metadata.ContentTypeAlias] = doctypeAlias;
9494
}
9595
}
9696

src/Our.Umbraco.GraphQL/Types/PublishedContentAtRootQueryGraphType.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ public PublishedContentAtRootQueryGraphType(IEnumerable<IGraphType> documentGrap
1919
return userContext.Umbraco.TypedContentAtRoot();
2020
});
2121

22-
foreach (var type in documentGraphTypes.Where(x => x.GetMetadata<bool>("allowedAtRoot")))
22+
foreach (var type in documentGraphTypes.Where(x => x.GetMetadata<bool>(Constants.Metadata.AllowedAtRoot)))
2323
{
24-
string documentTypeAlias = type.GetMetadata<string>("documentTypeAlias");
24+
string documentTypeAlias = type.GetMetadata<string>(Constants.Metadata.ContentTypeAlias);
2525

2626
this.AddField(
2727
new FieldType

src/Our.Umbraco.GraphQL/Types/PublishedContentByTypeQueryGraphType.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public PublishedContentByTypeQueryGraphType(IEnumerable<IGraphType> documentGrap
1111

1212
foreach (var type in documentGraphTypes)
1313
{
14-
string documentTypeAlias = type.GetMetadata<string>("documentTypeAlias");
14+
string documentTypeAlias = type.GetMetadata<string>(Constants.Metadata.ContentTypeAlias);
1515

1616
Field<PublishedContentInterfaceGraphType>()
1717
.Name(type.Name)

src/Our.Umbraco.GraphQL/Types/PublishedContentGraphType.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ public PublishedContentGraphType(IContentTypeComposition contentType, PublishedI
1515
IsTypeOf = content => ((IPublishedContent)content).ContentType.Alias == contentType.Alias;
1616
Metadata = new Dictionary<string, object>
1717
{
18-
["contentTypeAlias"] = contentType.Alias,
19-
["allowedAtRoot"] = contentType.AllowedAsRoot,
20-
["allowedChildren"] = contentType.AllowedContentTypes.Select(x => x.Alias).ToArray(),
18+
[Constants.Metadata.ContentTypeAlias] = contentType.Alias,
19+
[Constants.Metadata.AllowedAtRoot] = contentType.AllowedAsRoot,
20+
[Constants.Metadata.AllowedChildren] = contentType.AllowedContentTypes.Select(x => x.Alias).ToArray(),
2121
};
2222

2323
Interface<PublishedContentInterfaceGraphType>();
@@ -35,7 +35,7 @@ public PublishedContentGraphType(IContentTypeComposition contentType, PublishedI
3535
.Name("_contentData")
3636
.Description("Built in published content data.")
3737
.Resolve(context => context.Source)
38-
.SetDoctypeMetadata(GetMetadata<string>("documentTypeAlias"));
38+
.SetDoctypeMetadata(GetMetadata<string>(Constants.Metadata.ContentTypeAlias));
3939

4040
this.AddUmbracoContentPropeties(contentType, itemType);
4141
}

src/Our.Umbraco.GraphQL/Types/PublishedContentInterfaceGraphType.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public PublishedContentInterfaceGraphType()
1616
.Name("_contentData")
1717
.Description("Built in published content data.")
1818
.Resolve(context => context.Source)
19-
.SetDoctypeMetadata(GetMetadata<string>("documentTypeAlias"));
19+
.SetDoctypeMetadata(GetMetadata<string>(Constants.Metadata.ContentTypeAlias));
2020
}
2121
}
2222
}

src/Our.Umbraco.GraphQL/ValidationRules/RequiresAuthValidationRule.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public INodeVisitor Validate(ValidationContext context)
3131
// As a workaround this is set on the parent _conentData field and we use that when working out permissions
3232
if (fieldDef.Name == "_contentData")
3333
{
34-
var doctype = fieldDef.GetMetadata<string>("documentTypeAlias");
34+
var doctype = fieldDef.GetMetadata<string>(Constants.Metadata.ContentTypeAlias);
3535
if (!string.IsNullOrEmpty(doctype))
3636
{
3737
currentDoctype = doctype;

0 commit comments

Comments
 (0)