Fix Umbraco.Tests.Common warnings. (#17172)

* Fix async warning.

* Fix MediaFileManager warning.

* Fix TypeLoader warning.

* Fix CodeBase warning.

* Fix ContentTypeEditingBuilder warning.

* Fix _containerKey warning.

* Fix _key warning.

* Fix issues due to merge with contrib

---------

Co-authored-by: Laura Neto <[email protected]>

Author: jbreuer

tests/Umbraco.Tests.Common/Builders/ContentTypeEditingBuilder.cs

@@ -192,7 +192,7 @@ public static ContentTypeCreateModel CreateContentTypeWithContentPicker(string a
             .Build();
     }
 
-        public static ContentTypeCreateModel CreateContentTypeWithTwoPropertiesOneVariantAndOneInvariant(string alias = "test", string name = "TestName", string variantPropertyAlias = "variant", string variantPropertyName = "Variant", string invariantAlias = "invariant", string invariantName = "Invariant")
+    public static ContentTypeCreateModel CreateContentTypeWithTwoPropertiesOneVariantAndOneInvariant(string alias = "test", string name = "TestName", string variantPropertyAlias = "variant", string variantPropertyName = "Variant", string invariantAlias = "invariant", string invariantName = "Invariant")
     {
         var containerKey = Guid.NewGuid();
         var builder = new ContentTypeEditingBuilder();

tests/Umbraco.Tests.Common/TestHelperBase.cs

@@ -96,8 +96,7 @@ public IScopeProvider ScopeProvider
                 Mock.Of<IMediaPathScheme>(),
                 loggerFactory.CreateLogger<MediaFileManager>(),
                 Mock.Of<IShortStringHelper>(),
-                Mock.Of<IServiceProvider>(),
-                Options.Create(new ContentSettings()));
+                Mock.Of<IServiceProvider>());
             var databaseFactory = new Mock<IUmbracoDatabaseFactory>();
             var database = new Mock<IUmbracoDatabase>();
             var sqlContext = new Mock<ISqlContext>();
@@ -207,7 +206,7 @@ public virtual string MapPathForTestFiles(string relativePath)
             throw new ArgumentException("relativePath must start with '~/'", nameof(relativePath));
         }
 
-        var codeBase = typeof(TestHelperBase).Assembly.CodeBase;
+        var codeBase = typeof(TestHelperBase).Assembly.Location;
         var uri = new Uri(codeBase);
         var path = uri.LocalPath;
         var bin = Path.GetDirectoryName(path);

tests/Umbraco.Tests.Common/TestLastChanceFinder.cs

@@ -8,5 +8,5 @@ namespace Umbraco.Cms.Tests.Common;
 
 public class TestLastChanceFinder : IContentLastChanceFinder
 {
-    public async Task<bool> TryFindContent(IPublishedRequestBuilder frequest) => false;
+    public Task<bool> TryFindContent(IPublishedRequestBuilder frequest) => Task.FromResult(false);
 }