Skip to content

Commit 0a626c6

Browse files
Replace .first() with localize (#11341)
Replaced usage of first() with localize to target specific action in context menu
1 parent cabc303 commit 0a626c6

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Settings/mediaTypes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ context('Media Types', () => {
1616
cy.umbracoTreeItem("settings", ["Media Types"]).rightclick();
1717

1818
cy.umbracoContextMenuAction("action-create").click();
19-
cy.get('.menu-label').first().click(); // TODO: Fucked we cant use something like cy.umbracoContextMenuAction("action-mediaType").click();
19+
cy.get('.menu-label localize[key="content_mediatype"]').click();
2020

2121

2222
//Type name

tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Settings/partialsViewMacroFiles.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ context('Partial View Macro Files', () => {
2929

3030
openPartialViewMacroCreatePanel();
3131

32-
cy.get('.menu-label').first().click(); // TODO: Fucked we cant use something like cy.umbracoContextMenuAction("action-label").click();
32+
cy.get('.menu-label localize[key="create_newPartialViewMacro"]').click();
3333

3434
//Type name
3535
cy.umbracoEditorHeaderName(name);

tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Settings/partialsViews.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ context('Partial Views', () => {
2626
openPartialViewsCreatePanel();
2727

2828
cy.umbracoContextMenuAction("action-create").click();
29-
cy.get('.menu-label').first().click(); // TODO: Fucked we cant use something like cy.umbracoContextMenuAction("action-mediaType").click();
29+
cy.get('.menu-label localize[key="create_newEmptyPartialView"]').click();
3030

3131
//Type name
3232
cy.umbracoEditorHeaderName(name);
@@ -73,7 +73,7 @@ context('Partial Views', () => {
7373
openPartialViewsCreatePanel();
7474

7575
cy.umbracoContextMenuAction("action-create").click();
76-
cy.get('.menu-label').first().click();
76+
cy.get('.menu-label localize[key="create_newEmptyPartialView"]').click();
7777

7878
// The test would fail intermittently, most likely because the editor didn't have time to load
7979
// This should ensure that the editor is loaded and the test should no longer fail unexpectedly.

tests/Umbraco.Tests.AcceptanceTest/cypress/integration/Settings/scripts.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ context('Scripts', () => {
2323
cy.umbracoTreeItem("settings", ["Scripts"]).rightclick();
2424

2525
cy.umbracoContextMenuAction("action-create").click();
26-
cy.get('.menu-label').first().click(); // TODO: Fucked we cant use something like cy.umbracoContextMenuAction("action-mediaType").click();
26+
cy.get('.menu-label localize[key="create_newJavascriptFile"]').click();
2727
//We have to wait here till everything is loaded, or worker will throw error
2828
cy.intercept('/umbraco/lib/ace-builds/src-min-noconflict/worker-javascript.js').as('aceWorker');
2929
cy.wait('@aceWorker');

0 commit comments

Comments
 (0)