Fix to management API models reverting addition of read-only property (#19951)

* Removed readonly Signs property to re-align client models.

* Regenerate client types.

* Applied changes from code review.

Author: AndyButland

src/Umbraco.Cms.Api.Management/Mapping/DocumentType/DocumentTypeMapDefinition.cs

@@ -118,7 +118,7 @@ private void Map(ISimpleContentType source, DocumentTypeCollectionReferenceRespo
         target.Collection = ReferenceByIdModel.ReferenceOrNull(source.ListView);
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private void Map(IContent source, DocumentTypeBlueprintItemResponseModel target, MapperContext context)
     {
         target.Id = source.Key;

src/Umbraco.Cms.Api.Management/Mapping/Item/ItemTypeMapDefinition.cs

@@ -42,7 +42,7 @@ private static void Map(ILanguage source, LanguageItemResponseModel target, Mapp
         target.IsoCode = source.IsoCode;
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IDataType source, DataTypeItemResponseModel target, MapperContext context)
     {
         target.Name = source.Name ?? string.Empty;
@@ -52,14 +52,14 @@ private static void Map(IDataType source, DataTypeItemResponseModel target, Mapp
         target.IsDeletable = source.IsDeletableDataType();
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IDictionaryItem source, DictionaryItemItemResponseModel target, MapperContext context)
     {
         target.Name = source.ItemKey;
         target.Id = source.Key;
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IContentType source, DocumentTypeItemResponseModel target, MapperContext context)
     {
         target.Name = source.Name ?? string.Empty;
@@ -69,46 +69,46 @@ private static void Map(IContentType source, DocumentTypeItemResponseModel targe
         target.Description = source.Description;
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IMediaType source, MediaTypeItemResponseModel target, MapperContext context)
     {
         target.Name = source.Name ?? string.Empty;
         target.Id = source.Key;
         target.Icon = source.Icon;
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IEntitySlim source, MemberGroupItemResponseModel target, MapperContext context)
     {
         target.Name = source.Name ?? string.Empty;
         target.Id = source.Key;
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(ITemplate source, TemplateItemResponseModel target, MapperContext context)
     {
         target.Name = source.Name ?? string.Empty;
         target.Id = source.Key;
         target.Alias = source.Alias;
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IMemberType source, MemberTypeItemResponseModel target, MapperContext context)
     {
         target.Name = source.Name ?? string.Empty;
         target.Id = source.Key;
         target.Icon = source.Icon;
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IRelationType source, RelationTypeItemResponseModel target, MapperContext context)
     {
         target.Id = source.Key;
         target.Name = source.Name ?? string.Empty;
         target.IsDeletable = source.IsDeletableRelationType();
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IUserGroup source, UserGroupItemResponseModel target, MapperContext context)
     {
         target.Id = source.Key;
@@ -117,7 +117,7 @@ private static void Map(IUserGroup source, UserGroupItemResponseModel target, Ma
         target.Alias = source.Alias;
     }
 
-    // Umbraco.Code.MapAll
+    // Umbraco.Code.MapAll -Signs
     private static void Map(IWebhook source, WebhookItemResponseModel target, MapperContext context)
     {
         target.Id = source.Key;