Fixed issue with max validation using default 0 value. (#18616)

Author: AndyButland

src/Umbraco.Infrastructure/PropertyEditors/SliderPropertyEditor.cs

@@ -10,7 +10,6 @@
 using Umbraco.Cms.Core.Models.Editors;
 using Umbraco.Cms.Core.Models.Validation;
 using Umbraco.Cms.Core.PropertyEditors.Validation;
-using Umbraco.Cms.Core.PropertyEditors.Validators;
 using Umbraco.Cms.Core.Serialization;
 using Umbraco.Cms.Core.Services;
 using Umbraco.Cms.Core.Strings;
@@ -261,7 +260,7 @@ public IEnumerable<ValidationResult> Validate(object? value, string? valueType,
                         ["value"]);
                 }
 
-                if (sliderRange.To > sliderConfiguration.MaximumValue)
+                if (sliderConfiguration.MaximumValue != 0 && sliderRange.To > sliderConfiguration.MaximumValue)
                 {
                     yield return new ValidationResult(
                         LocalizedTextService.Localize("validation", "outOfRangeMaximum", [sliderRange.To.ToString(), sliderConfiguration.MaximumValue.ToString()]),

tests/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/SliderValueEditorTests.cs

@@ -205,6 +205,21 @@ public void Validates_Is_Less_Than_Or_Equal_To_Configured_Max(decimal from, deci
         }
     }
 
+    [Test]
+    public void Max_Item_Validation_Respects_0_As_Unlimited()
+    {
+        var value = new JsonObject
+        {
+            { "from", 1.0m },
+            { "to", 1.0m },
+        };
+        var editor = CreateValueEditor();
+        editor.ConfigurationObject = new SliderConfiguration();
+
+        var result = editor.Validate(value, false, null, PropertyValidationContext.Empty());
+        Assert.IsEmpty(result);
+    }
+
     [TestCase(0.2, 1.3, 1.7, true)]
     [TestCase(0.2, 1.4, 1.7, false)]
     [TestCase(0.2, 1.3, 1.6, false)]