Added unit tests for ContentVersionService (#11597)

* Added unit tests for ContentVersionService

* Clean up

* Fixed tests after using ConfigureMembers = true

* Fixed tests after using ConfigureMembers = true

Author: bergmania

src/Umbraco.Infrastructure/Services/Implement/ContentVersionService.cs

@@ -41,11 +41,14 @@ public ContentVersionService(
         ///     In v9 this can live in another class as we publish the notifications via IEventAggregator.
         ///     But for v8 must be here for access to the static events.
         /// </remarks>
-        public IReadOnlyCollection<HistoricContentVersionMeta> PerformContentVersionCleanup(DateTime asAtDate) =>
-            CleanupDocumentVersions(asAtDate);
+        public IReadOnlyCollection<HistoricContentVersionMeta> PerformContentVersionCleanup(DateTime asAtDate)
+        {
+            // Media - ignored
+            // Members - ignored
+            return CleanupDocumentVersions(asAtDate);
+        }
+
 
-        // Media - ignored
-        // Members - ignored
         /// <remarks>
         ///     v9 - move to another class
         /// </remarks>

tests/Umbraco.Tests.UnitTests/AutoFixture/AutoMoqDataAttribute.cs

@@ -21,10 +21,12 @@
 using Umbraco.Cms.Web.BackOffice.Controllers;
 using Umbraco.Cms.Web.BackOffice.Install;
 using Umbraco.Cms.Web.BackOffice.Routing;
+using Umbraco.Cms.Web.Common.AspNetCore;
 using Umbraco.Cms.Web.Common.Security;
 
 namespace Umbraco.Cms.Tests.UnitTests.AutoFixture
 {
+
     [AttributeUsage(AttributeTargets.Method | AttributeTargets.Constructor)]
     public class AutoMoqDataAttribute : AutoDataAttribute
     {
@@ -40,6 +42,7 @@ public AutoMoqDataAttribute()
 
         internal static class AutoMockCustomizations
         {
+
             public static IFixture Default => new Fixture().Customize(new UmbracoCustomization());
 
             private class UmbracoCustomization : ICustomization
@@ -58,7 +61,7 @@ public void Customize(IFixture fixture)
                         .Customize(new ConstructorCustomization(typeof(BackOfficeUserManager), new GreedyConstructorQuery()))
                         .Customize(new ConstructorCustomization(typeof(MemberManager), new GreedyConstructorQuery()));
 
-                    fixture.Customize(new AutoMoqCustomization());
+                    fixture.Customize(new AutoMoqCustomization(){ConfigureMembers = true});
 
                     // When requesting an IUserStore ensure we actually uses a IUserLockoutStore
                     fixture.Customize<IUserStore<BackOfficeIdentityUser>>(cc => cc.FromFactory(() => Mock.Of<IUserLockoutStore<BackOfficeIdentityUser>>()));
@@ -71,6 +74,8 @@ public void Customize(IFixture fixture)
                         u => u.FromFactory(
                             () => new UmbracoVersion()));
 
+                    fixture.Customize<HostingSettings>(x =>
+                        x.With(settings => settings.ApplicationVirtualPath, string.Empty));
                     fixture.Customize<BackOfficeAreaRoutes>(u => u.FromFactory(
                         () => new BackOfficeAreaRoutes(
                             Options.Create(new GlobalSettings()),
@@ -84,12 +89,18 @@ public void Customize(IFixture fixture)
                             Mock.Of<IHostingEnvironment>(x => x.ToAbsolute(It.IsAny<string>()) == "/umbraco" && x.ApplicationVirtualPath == string.Empty),
                             Mock.Of<IRuntimeState>(x => x.Level == RuntimeLevel.Run))));
 
-                    var connectionStrings = new ConnectionStrings();
-                    fixture.Customize<ConnectionStrings>(x => x.FromFactory(() => connectionStrings));
+                    var configConnectionString = new ConfigConnectionString("ss",
+                        "Data Source=(localdb)\\MSSQLLocalDB;AttachDbFilename=|DataDirectory|\\Umbraco.mdf;Integrated Security=True");
+                    fixture.Customize<ConfigConnectionString>(x => x.FromFactory(() => configConnectionString));
+
 
                     var httpContextAccessor = new HttpContextAccessor { HttpContext = new DefaultHttpContext() };
                     fixture.Customize<HttpContext>(x => x.FromFactory(() => httpContextAccessor.HttpContext));
                     fixture.Customize<IHttpContextAccessor>(x => x.FromFactory(() => httpContextAccessor));
+
+                    fixture.Customize<WebRoutingSettings>(x => x.With(settings => settings.UmbracoApplicationUrl, "http://localhost:5000"));
+
+                    fixture.Behaviors.Add(new OmitOnRecursionBehavior());
                 }
             }
         }