Skip to content

Commit 1fedaa3

Browse files
Removes npm commands from MSBuild of the CSPROJ for umbraco-extension dotnet new template (#20839)
* Removes npm commands from the MSBuild of the CSPROJ of the umbraco-extension dotnet new template Was agreed by the community package team to remove this, as this DX can cause more issues than actually help users in our opinion * Removed the unused value - good catch by Copilot
1 parent ba7d550 commit 1fedaa3

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

templates/UmbracoExtension/Umbraco.Extension.csproj

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@
2626
</ItemGroup>
2727

2828
<ItemGroup>
29-
<ClientAssetsInputs Include="Client\**" Exclude="$(DefaultItemExcludes)" />
30-
3129
<!-- Dont include the client folder as part of packaging nuget build -->
3230
<Content Remove="Client\**" />
3331

@@ -39,19 +37,4 @@
3937
<Folder Include="wwwroot\" />
4038
</ItemGroup>
4139

42-
<!-- Restore and build Client files -->
43-
<Target Name="RestoreClient" Inputs="Client\package.json;Client\package-lock.json" Outputs="Client\node_modules\.package-lock.json">
44-
<Message Importance="high" Text="Restoring Client NPM packages..." />
45-
<Exec Command="npm i" WorkingDirectory="Client" />
46-
</Target>
47-
48-
<Target Name="BuildClient" BeforeTargets="AssignTargetPaths" DependsOnTargets="RestoreClient" Inputs="@(ClientAssetsInputs)" Outputs="$(IntermediateOutputPath)client.complete.txt">
49-
<Message Importance="high" Text="Executing Client NPM build script..." />
50-
<Exec Command="npm run build" WorkingDirectory="Client" />
51-
<ItemGroup>
52-
<_ClientAssetsBuildOutput Include="wwwroot\App_Plugins\**" />
53-
</ItemGroup>
54-
<WriteLinesToFile File="$(IntermediateOutputPath)client.complete.txt" Lines="@(_ClientAssetsBuildOutput)" Overwrite="true" />
55-
</Target>
56-
5740
</Project>

0 commit comments

Comments
 (0)