Merge pull request #11126 from An0d/v9/9.0-rc003

Fix: AllowAnonymous attribute on Action is ignored when UmbracoMember…

Author: bergmania

src/Umbraco.Web.Common/Filters/UmbracoMemberAuthorizeFilter.cs

@@ -1,7 +1,11 @@
 using System.Collections.Generic;
 using System.Globalization;
 using System.Threading.Tasks;
+
+using Microsoft.AspNetCore.Authorization;
+using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Mvc;
+using Microsoft.AspNetCore.Mvc.Authorization;
 using Microsoft.AspNetCore.Mvc.Filters;
 using Microsoft.Extensions.DependencyInjection;
 using Umbraco.Cms.Core.Security;
@@ -43,6 +47,12 @@ public  UmbracoMemberAuthorizeFilter(string allowType, string allowGroup, string
 
         public async Task OnAuthorizationAsync(AuthorizationFilterContext context)
         {
+            // Allow Anonymous skips all authorization
+            if (HasAllowAnonymous(context))
+            {
+                return;
+            }
+
             IMemberManager memberManager = context.HttpContext.RequestServices.GetRequiredService<IMemberManager>();
 
             if (!await IsAuthorizedAsync(memberManager))
@@ -52,6 +62,32 @@ public async Task OnAuthorizationAsync(AuthorizationFilterContext context)
             }
         }
 
+        /// <summary>
+        /// Copied from https://github.com/dotnet/aspnetcore/blob/main/src/Mvc/Mvc.Core/src/Authorization/AuthorizeFilter.cs
+        /// </summary>
+        private bool HasAllowAnonymous(AuthorizationFilterContext context)
+        {
+            var filters = context.Filters;
+            for (var i = 0; i < filters.Count; i++)
+            {
+                if (filters[i] is IAllowAnonymousFilter)
+                {
+                    return true;
+                }
+            }
+
+            // When doing endpoint routing, MVC does not add AllowAnonymousFilters for AllowAnonymousAttributes that
+            // were discovered on controllers and actions. To maintain compat with 2.x,
+            // we'll check for the presence of IAllowAnonymous in endpoint metadata.
+            var endpoint = context.HttpContext.GetEndpoint();
+            if (endpoint?.Metadata?.GetMetadata<IAllowAnonymous>() != null)
+            {
+                return true;
+            }
+
+            return false;
+        }
+
         private async Task<bool> IsAuthorizedAsync(IMemberManager memberManager)
         {
             if (AllowMembers.IsNullOrWhiteSpace())