Skip to content

Commit 2903d58

Browse files
ZeegaaniOvergaardnikolajlauridsenelit0451andr317c
authored
V10: 13125 don't return "null" (#13163)
* Add null check * Fix for potential race condition in packages search (#13153) * search on input allowing to wait for copy/paste etc * invoke resourcePromise() with correct parameters * return the xhrStatus allowing the caller to check if the request was aborted * fix: send in canceler.promise to allow the timeout to work * catch any errors and ignore aborts if they happen * move the logic to handle cancellations outside Angulars $scope.$apply * remove file accidentally committed * V10: Fix request accessor memory leak (#13152) * Dispose OnChange event registration when disposing the notification handler * Ensure that the ApplicationUrl is only initialized once Since notifications handlers are transient,_hasAppUrl and _isInit defaults to false on every request causing it to always be called. * Make notification handler and EnsureApplicationUrl internal * Add missing ForceLeft and ForceRight (#13190) * Fix tags with CSV storage type (#13188) * Fixing null check as default(NRT) is null => default(configuration?.Delimiter) is also null and we were counting on it being the same as default(char) * Adding tests to check cases with multiple tags (or tag made of comma separated values) * Add data-element to umb property so we can find it (#13199) Co-authored-by: Zeegaan <[email protected]> * V10/bugfix/create simple package test (#13162) * Fixed assert to hopefully find the package each time so it isnt flaky anymore * Updated so it retries 5 times instead of 2 * Dont submit html-report * Dont have output defined in npm run * Copy over playwright trace.zip files before publishing * Updated assert so it looks after the package in the table * updated so we get the first fail as the trace file * Bumped version for testhelpers * Updated so the test checks if the package actually exists. Added a wait that checks if the created packages button is visible * Updated package lock * Fixed so it now calls the correct testhelper Co-authored-by: Zeegaan <[email protected]> * Update src/Umbraco.Core/PropertyEditors/DataValueEditor.cs Co-authored-by: Elitsa Marinovska <[email protected]> Co-authored-by: Zeegaan <[email protected]> Co-authored-by: Jacob Overgaard <[email protected]> Co-authored-by: Mole <[email protected]> Co-authored-by: Elitsa Marinovska <[email protected]> Co-authored-by: Andreas Zerbst <[email protected]> Co-authored-by: Elitsa Marinovska <[email protected]>
1 parent b1cbc92 commit 2903d58

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/Umbraco.Core/PropertyEditors/DataValueEditor.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,11 @@ public virtual string ConvertDbToString(IPropertyType propertyType, object? valu
386386
/// <exception cref="System.ArgumentOutOfRangeException">ValueType was out of range.</exception>
387387
internal Attempt<object?> TryConvertValueToCrlType(object? value)
388388
{
389+
if (value is null)
390+
{
391+
return Attempt.Succeed<object?>(null);
392+
}
393+
389394
// Ensure empty string and JSON values are converted to null
390395
if (value is string stringValue && string.IsNullOrWhiteSpace(stringValue))
391396
{

0 commit comments

Comments
 (0)