V17 - Properties and validators, removing obsoleted code (#19961)

* Removing obsoleted code from ApiMediaQueryService.cs

* Removing obsoleted code from ApiRichTextMarkupParserTests.cs

* Removing obsoleted code from ContentCacheRefresher.cs

* Removing obsoleted code from ContentFinderByUrlAlias.cs and adjusting its tests to use the new logic

* Removing obsoleted code from ContentFinderByUrl.cs & its dependencies

* Removing obsoleted code from ApiRichTextMarkupParserTests.cs

* Removing obsoleted code from DocumentCache.cs & its dependencies

* Removing obsoleted code from MediaCache.cs & its dependencies

* Removing obsoleted code from PublishedCacheBase.cs & its dependencies

* Removing obsoleted code from RenderNoContentController.cs and its tests

* Removing obsoleted code from UmbracoRouteValueTransformer.cs

* Removing obsoleted constructors from DefaultUrlProvider.cs

* Removing the RadioValueEditor.cs & RadioValueValidator.cs obsoleted classes.

* Removing obsolete constructor from MultipleValueValidator.cs

* Removing obsolete constructor from EmailValidator.cs

* Removing obsoleted code from DataValueReferenceFactoryCollection.cs

* Removing obsoleted code from ApiContentBuilderBase.cs

* Fixing constructor missing attribute

* Making use of the TryGet result

* Fixing use of obsoleted constructor

* Removing silly bookmark comment

* Fixing deleted code and restructuring to use new cache

* Making use of TryGetRootKeys bool, to return null if false.

* Extending code to use new constructor

* Updated PublishedContentQuery.cs to return empty array

Co-authored-by: Nikolaj Geisle <[email protected]>

---------

Co-authored-by: Nikolaj Geisle <[email protected]>

Author: NillasKA

src/Umbraco.Cms.Api.Delivery/Services/ApiMediaQueryService.cs

@@ -66,7 +66,12 @@ private IPublishedMediaCache GetRequiredPublishedMediaCache()
     private IPublishedContent? TryGetByPath(string path, IPublishedMediaCache mediaCache)
     {
         var segments = path.Split(Constants.CharArrays.ForwardSlash, StringSplitOptions.RemoveEmptyEntries);
-        IEnumerable<IPublishedContent> currentChildren = mediaCache.GetAtRoot();
+        if (_mediaNavigationQueryService.TryGetRootKeys(out IEnumerable<Guid> rootKeys) is false)
+        {
+            return null;
+        }
+
+        IEnumerable<IPublishedContent> currentChildren = rootKeys.Select(x => mediaCache.GetById(false, x)).WhereNotNull();
         IPublishedContent? resolvedMedia = null;
 
         foreach (var segment in segments)
@@ -101,9 +106,9 @@ private IPublishedMediaCache GetRequiredPublishedMediaCache()
         }
 
         IPublishedMediaCache mediaCache = GetRequiredPublishedMediaCache();
-        if (childrenOf.Trim(Constants.CharArrays.ForwardSlash).Length == 0)
+        if (childrenOf.Trim(Constants.CharArrays.ForwardSlash).Length == 0 && _mediaNavigationQueryService.TryGetRootKeys(out IEnumerable<Guid> rootKeys))
         {
-            return mediaCache.GetAtRoot();
+            return rootKeys.Select(x => mediaCache.GetById(false, x)).WhereNotNull();
         }
 
         IPublishedContent? parent = Guid.TryParse(childrenOf, out Guid parentKey)

src/Umbraco.Core/Cache/Refreshers/Implement/ContentCacheRefresher.cs

@@ -27,39 +27,6 @@ public sealed class ContentCacheRefresher : PayloadCacheRefresherBase<ContentCac
     private readonly IPublishStatusManagementService _publishStatusManagementService;
     private readonly IIdKeyMap _idKeyMap;
 
-    [Obsolete("Use the constructor with ICacheManager instead, scheduled for removal in V17.")]
-    public ContentCacheRefresher(
-        AppCaches appCaches,
-        IJsonSerializer serializer,
-        IIdKeyMap idKeyMap,
-        IDomainService domainService,
-        IEventAggregator eventAggregator,
-        ICacheRefresherNotificationFactory factory,
-        IDocumentUrlService documentUrlService,
-        IDomainCacheService domainCacheService,
-        IDocumentNavigationQueryService documentNavigationQueryService,
-        IDocumentNavigationManagementService documentNavigationManagementService,
-        IContentService contentService,
-        IPublishStatusManagementService publishStatusManagementService,
-        IDocumentCacheService documentCacheService)
-        : this(
-            appCaches,
-            serializer,
-            idKeyMap,
-            domainService,
-            eventAggregator,
-            factory,
-            documentUrlService,
-            domainCacheService,
-            documentNavigationQueryService,
-            documentNavigationManagementService,
-            contentService,
-            publishStatusManagementService,
-            documentCacheService,
-            StaticServiceProvider.Instance.GetRequiredService<ICacheManager>())
-    {
-    }
-
     public ContentCacheRefresher(
         AppCaches appCaches,
         IJsonSerializer serializer,

src/Umbraco.Core/Cache/Refreshers/Implement/MediaCacheRefresher.cs

@@ -22,31 +22,6 @@ public sealed class MediaCacheRefresher : PayloadCacheRefresherBase<MediaCacheRe
     private readonly IMediaCacheService _mediaCacheService;
     private readonly ICacheManager _cacheManager;
 
-    [Obsolete("Use the constructor with ICacheManager instead, scheduled for removal in V17.")]
-    public MediaCacheRefresher(
-        AppCaches appCaches,
-        IJsonSerializer serializer,
-        IIdKeyMap idKeyMap,
-        IEventAggregator eventAggregator,
-        ICacheRefresherNotificationFactory factory,
-        IMediaNavigationQueryService mediaNavigationQueryService,
-        IMediaNavigationManagementService mediaNavigationManagementService,
-        IMediaService mediaService,
-        IMediaCacheService mediaCacheService)
-        : this(
-            appCaches,
-            serializer,
-            idKeyMap,
-            eventAggregator,
-            factory,
-            mediaNavigationQueryService,
-            mediaNavigationManagementService,
-            mediaService,
-            mediaCacheService,
-            StaticServiceProvider.Instance.GetRequiredService<ICacheManager>())
-    {
-    }
-
     public MediaCacheRefresher(
         AppCaches appCaches,
         IJsonSerializer serializer,

src/Umbraco.Core/DeliveryApi/ApiContentBuilderBase.cs

@@ -1,6 +1,4 @@
-using Microsoft.Extensions.DependencyInjection;
-using Umbraco.Cms.Core.DependencyInjection;
-using Umbraco.Cms.Core.Models.DeliveryApi;
+using Umbraco.Cms.Core.Models.DeliveryApi;
 using Umbraco.Cms.Core.Models.PublishedContent;
 using Umbraco.Extensions;
 
@@ -12,19 +10,6 @@ public abstract class ApiContentBuilderBase<T>
     private readonly IApiContentNameProvider _apiContentNameProvider;
     private readonly IOutputExpansionStrategyAccessor _outputExpansionStrategyAccessor;
 
-    [Obsolete("Please use the constructor that takes all parameters. Scheduled for removal in Umbraco 17.")]
-    protected ApiContentBuilderBase(
-        IApiContentNameProvider apiContentNameProvider,
-        IApiContentRouteBuilder apiContentRouteBuilder,
-        IOutputExpansionStrategyAccessor outputExpansionStrategyAccessor)
-        : this(
-              apiContentNameProvider,
-              apiContentRouteBuilder,
-              outputExpansionStrategyAccessor,
-              StaticServiceProvider.Instance.GetRequiredService<IVariationContextAccessor>())
-    {
-    }
-
     protected ApiContentBuilderBase(
         IApiContentNameProvider apiContentNameProvider,
         IApiContentRouteBuilder apiContentRouteBuilder,

src/Umbraco.Core/PropertyEditors/DataValueReferenceFactoryCollection.cs

@@ -1,7 +1,5 @@
-using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Umbraco.Cms.Core.Composing;
-using Umbraco.Cms.Core.DependencyInjection;
 using Umbraco.Cms.Core.Models;
 using Umbraco.Cms.Core.Models.Editors;
 
@@ -17,17 +15,6 @@ public class DataValueReferenceFactoryCollection : BuilderCollectionBase<IDataVa
 
     private readonly ILogger<DataValueReferenceFactoryCollection> _logger;
 
-    /// <summary>
-    /// Initializes a new instance of the <see cref="DataValueReferenceFactoryCollection" /> class.
-    /// </summary>
-    /// <param name="items">The items.</param>
-    [Obsolete("Please use the constructor taking all parameters. Scheduled for removal in Umbraco 17.")]
-    public DataValueReferenceFactoryCollection(Func<IEnumerable<IDataValueReferenceFactory>> items)
-        : this(
-              items,
-              StaticServiceProvider.Instance.GetRequiredService<ILogger<DataValueReferenceFactoryCollection>>())
-    { }
-
     /// <summary>
     /// Initializes a new instance of the <see cref="DataValueReferenceFactoryCollection" /> class.
     /// </summary>
@@ -159,17 +146,6 @@ private IEnumerable<UmbracoEntityReference> GetReferencesFromPropertyValues(IEnu
         return result;
     }
 
-    /// <summary>
-    /// Gets all relation type aliases that are automatically tracked.
-    /// </summary>
-    /// <param name="propertyEditors">The property editors.</param>
-    /// <returns>
-    /// All relation type aliases that are automatically tracked.
-    /// </returns>
-    [Obsolete("Use GetAllAutomaticRelationTypesAliases. This will be removed in Umbraco 15.")]
-    public ISet<string> GetAutomaticRelationTypesAliases(PropertyEditorCollection propertyEditors) =>
-        GetAllAutomaticRelationTypesAliases(propertyEditors);
-
     public ISet<string> GetAllAutomaticRelationTypesAliases(PropertyEditorCollection propertyEditors)
     {
         // Always add default automatic relation types

src/Umbraco.Core/PropertyEditors/RadioValueEditor.cs

@@ -14,15 +14,6 @@ public sealed class EmailValidator : IValueValidator
 {
     private readonly ILocalizedTextService _localizedTextService;
 
-    /// <summary>
-    /// Initializes a new instance of the <see cref="EmailValidator"/> class.
-    /// </summary>
-    [Obsolete("Please use the constructor taking all parameters. Scheduled for removal in Umbraco 17.")]
-    public EmailValidator()
-        : this(StaticServiceProvider.Instance.GetRequiredService<ILocalizedTextService>())
-    {
-    }
-
     /// <summary>
     /// Initializes a new instance of the <see cref="EmailValidator"/> class.
     /// </summary>

src/Umbraco.Core/PropertyEditors/Validators/EmailValidator.cs

@@ -14,15 +14,6 @@ public class MultipleValueValidator : IValueValidator
 {
     private readonly ILocalizedTextService _localizedTextService;
 
-    /// <summary>
-    /// Initializes a new instance of the <see cref="MultipleValueValidator"/> class.
-    /// </summary>
-    [Obsolete("Please use the constructor that takes all parameters. Scheduled for removal in Umbraco 17.")]
-    public MultipleValueValidator()
-        : this(StaticServiceProvider.Instance.GetRequiredService<ILocalizedTextService>())
-    {
-    }
-
     /// <summary>
     /// Initializes a new instance of the <see cref="MultipleValueValidator"/> class.
     /// </summary>

src/Umbraco.Core/PropertyEditors/Validators/MultipleValueValidator.cs

@@ -25,16 +25,6 @@ public interface IPublishedCache
     /// <remarks>The value of <paramref name="preview" /> overrides defaults.</remarks>
     IPublishedContent? GetById(bool preview, Guid contentId);
 
-    /// <summary>
-    ///     Gets a content identified by its Udi identifier.
-    /// </summary>
-    /// <param name="preview">A value indicating whether to consider unpublished content.</param>
-    /// <param name="contentId">The content Udi identifier.</param>
-    /// <returns>The content, or null.</returns>
-    /// <remarks>The value of <paramref name="preview" /> overrides defaults.</remarks>
-    [Obsolete] // FIXME: Remove when replacing nucache
-    IPublishedContent? GetById(bool preview, Udi contentId);
-
     /// <summary>
     ///     Gets a content identified by its unique identifier.
     /// </summary>
@@ -50,49 +40,4 @@ public interface IPublishedCache
     /// <returns>The content, or null.</returns>
     /// <remarks>Considers published or unpublished content depending on defaults.</remarks>
     IPublishedContent? GetById(Guid contentId);
-
-    /// <summary>
-    ///     Gets a content identified by its unique identifier.
-    /// </summary>
-    /// <param name="contentId">The content unique identifier.</param>
-    /// <returns>The content, or null.</returns>
-    /// <remarks>Considers published or unpublished content depending on defaults.</remarks>
-    [Obsolete] // FIXME: Remove when replacing nucache
-    IPublishedContent? GetById(Udi contentId);
-
-    /// <summary>
-    ///     Gets contents at root.
-    /// </summary>
-    /// <param name="preview">A value indicating whether to consider unpublished content.</param>
-    /// <param name="culture">A culture.</param>
-    /// <returns>The contents.</returns>
-    /// <remarks>The value of <paramref name="preview" /> overrides defaults.</remarks>
-    [Obsolete("Scheduled for removal, use IDocumentNavigationQueryService instead in v17")]
-    IEnumerable<IPublishedContent> GetAtRoot(bool preview, string? culture = null);
-
-    /// <summary>
-    ///     Gets contents at root.
-    /// </summary>
-    /// <param name="culture">A culture.</param>
-    /// <returns>The contents.</returns>
-    /// <remarks>Considers published or unpublished content depending on defaults.</remarks>
-    [Obsolete("Scheduled for removal, use IDocumentNavigationQueryService instead in v17")]
-    IEnumerable<IPublishedContent> GetAtRoot(string? culture = null);
-
-    /// <summary>
-    ///     Gets a value indicating whether the cache contains published content.
-    /// </summary>
-    /// <param name="preview">A value indicating whether to consider unpublished content.</param>
-    /// <returns>A value indicating whether the cache contains published content.</returns>
-    /// <remarks>The value of <paramref name="preview" /> overrides defaults.</remarks>
-    [Obsolete("Scheduled for removal in v17")]
-    bool HasContent(bool preview);
-
-    /// <summary>
-    ///     Gets a value indicating whether the cache contains published content.
-    /// </summary>
-    /// <returns>A value indicating whether the cache contains published content.</returns>
-    /// <remarks>Considers published or unpublished content depending on defaults.</remarks>
-    [Obsolete("Scheduled for removal in v17")]
-    bool HasContent();
 }