Skip to content

Commit 348f1f2

Browse files
committed
Change webhook permissions to require webhook tree access for all endpoints
1 parent d57d12d commit 348f1f2

File tree

4 files changed

+3
-9
lines changed

4 files changed

+3
-9
lines changed

src/Umbraco.Cms.Api.Management/Controllers/Webhook/CreateWebhookController.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using Asp.Versioning;
2-
using Microsoft.AspNetCore.Authorization;
32
using Microsoft.AspNetCore.Http;
43
using Microsoft.AspNetCore.Mvc;
54
using Umbraco.Cms.Api.Management.Factories;
@@ -8,12 +7,10 @@
87
using Umbraco.Cms.Core.Models;
98
using Umbraco.Cms.Core.Services;
109
using Umbraco.Cms.Core.Services.OperationStatus;
11-
using Umbraco.Cms.Web.Common.Authorization;
1210

1311
namespace Umbraco.Cms.Api.Management.Controllers.Webhook;
1412

1513
[ApiVersion("1.0")]
16-
[Authorize(Policy = AuthorizationPolicies.TreeAccessWebhooks)]
1714
public class CreateWebhookController : WebhookControllerBase
1815
{
1916
private readonly IWebhookService _webhookService;

src/Umbraco.Cms.Api.Management/Controllers/Webhook/DeleteWebhookController.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
11
using Asp.Versioning;
2-
using Microsoft.AspNetCore.Authorization;
32
using Microsoft.AspNetCore.Http;
43
using Microsoft.AspNetCore.Mvc;
54
using Umbraco.Cms.Core;
65
using Umbraco.Cms.Core.Models;
76
using Umbraco.Cms.Core.Security;
87
using Umbraco.Cms.Core.Services;
98
using Umbraco.Cms.Core.Services.OperationStatus;
10-
using Umbraco.Cms.Web.Common.Authorization;
119

1210
namespace Umbraco.Cms.Api.Management.Controllers.Webhook;
1311

1412
[ApiVersion("1.0")]
15-
[Authorize(Policy = AuthorizationPolicies.TreeAccessWebhooks)]
1613
public class DeleteWebhookController : WebhookControllerBase
1714
{
1815
private readonly IWebhookService _webhookService;

src/Umbraco.Cms.Api.Management/Controllers/Webhook/UpdateWebhookController.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using Asp.Versioning;
2-
using Microsoft.AspNetCore.Authorization;
32
using Microsoft.AspNetCore.Http;
43
using Microsoft.AspNetCore.Mvc;
54
using Umbraco.Cms.Api.Management.Factories;
@@ -8,12 +7,10 @@
87
using Umbraco.Cms.Core.Models;
98
using Umbraco.Cms.Core.Services;
109
using Umbraco.Cms.Core.Services.OperationStatus;
11-
using Umbraco.Cms.Web.Common.Authorization;
1210

1311
namespace Umbraco.Cms.Api.Management.Controllers.Webhook;
1412

1513
[ApiVersion("1.0")]
16-
[Authorize(Policy = AuthorizationPolicies.TreeAccessWebhooks)]
1714
public class UpdateWebhookController : WebhookControllerBase
1815
{
1916
private readonly IWebhookService _webhookService;

src/Umbraco.Cms.Api.Management/Controllers/Webhook/WebhookControllerBase.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
1+
using Microsoft.AspNetCore.Authorization;
12
using Microsoft.AspNetCore.Http;
23
using Microsoft.AspNetCore.Mvc;
34
using Umbraco.Cms.Api.Common.Builders;
45
using Umbraco.Cms.Api.Management.Routing;
56
using Umbraco.Cms.Core.Services.OperationStatus;
7+
using Umbraco.Cms.Web.Common.Authorization;
68

79
namespace Umbraco.Cms.Api.Management.Controllers.Webhook;
810

911
[VersionedApiBackOfficeRoute("webhook")]
1012
[ApiExplorerSettings(GroupName = "Webhook")]
13+
[Authorize(Policy = AuthorizationPolicies.TreeAccessWebhooks)]
1114
public abstract class WebhookControllerBase : ManagementApiControllerBase
1215
{
1316
protected IActionResult WebhookOperationStatusResult(WebhookOperationStatus status) =>

0 commit comments

Comments
 (0)