no need to redirect when removing tab. router handles this fine

nielslyngsoe · iOvergaard · commit 5f291bab22bb · 2024-12-11T16:16:14.000+01:00
diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/content-type/workspace/views/design/content-type-design-editor.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/content-type/workspace/views/design/content-type-design-editor.element.ts
@@ -269,9 +269,8 @@ export class UmbContentTypeDesignEditorElement extends UmbLitElement implements
 	#deleteTab(tabId?: string) {
 		if (!tabId) return;
 		this.#workspaceContext?.structure.removeContainer(null, tabId);
-		// TODO: We should only navigate away if it was the last tab and if it was the active one... [NL]
-		if (this.#tabsStructureHelper?.isOwnerChildContainer(tabId)) {
-			window.history.replaceState(null, '', this._routerPath + (this._routes[0]?.path ?? '/root'));
+		if (this._activeTabId === tabId) {
+			this._activeTabId = undefined;
 		}
 	}
 	async #addTab() {

Original file line number	Diff line number	Diff line change
`@@ -269,9 +269,8 @@ export class UmbContentTypeDesignEditorElement extends UmbLitElement implements`
`269`	`269`	`#deleteTab(tabId?: string) {`
`270`	`270`	`if (!tabId) return;`
`271`	`271`	`this.#workspaceContext?.structure.removeContainer(null, tabId);`
`272`		`- // TODO: We should only navigate away if it was the last tab and if it was the active one... [NL]`
`273`		`- if (this.#tabsStructureHelper?.isOwnerChildContainer(tabId)) {`
`274`		`- window.history.replaceState(null, '', this._routerPath + (this._routes[0]?.path ?? '/root'));`
	`272`	`+ if (this._activeTabId === tabId) {`
	`273`	`+ this._activeTabId = undefined;`
`275`	`274`	`}`
`276`	`275`	`}`
`277`	`276`	`async #addTab() {`