V16 QA Updated acceptance tests with skip() and fixme() tag (#19397)

* Updated nightly E2E pipeline

* Fixed failing E2E tests

* Skipped content tests wirh list view content due to an issue

* Updated tests due to UI changes

* Updated fixme and skip tests - part 1

* Removed this file because the tests are already covered elsewhere

* Updated fixme() tests

* Updated skip() tests

* Bumped version

* Bumped version

* Bumped version

* Removed notification verification

* Removed the step to verify the notification for save action

* Fixed the failing tests

* Updated name of permission

* Bumped version

* Fixed failing tests

* Bumped testHelpers

* Removed tests related to tiptap toolbar as they are covered in another class

* Cleaned up

* Added more waits

* Cleaned up

* Added step to ensure redirect URL is created when renaming content.

* Restructured the tests

* Removed unnecessary steps

* Fixed isItemVisibleInRecycleBin

* Fixed isItemVisibleInRecycleBin

* Bumped version

* Added more wait for the deletion to complete

* Added waits for the deletion to complete

* Added more waits

* Removed unnecessary waits

* Added more waits to improve test stability

* Added skip for the flaky test

* Added test for removing a stylesheet in a block grid editor

* Updated test due to api helper changes

* Bumped version

* Fixed failing smoke test

---------

Co-authored-by: Andreas Zerbst <[email protected]>

Author: nhudinh0309

build/nightly-E2E-test-pipelines.yml

@@ -9,7 +9,6 @@ schedules:
     branches:
       include:
         - v15/dev
-        - release/16.0
         - main
 
 parameters:
@@ -483,4 +482,4 @@ stages:
               testResultsFormat: 'JUnit'
               testResultsFiles: '*.xml'
               searchFolder: "tests/Umbraco.Tests.AcceptanceTest/results"
-              testRunTitle: "$(Agent.JobName)"
+              testRunTitle: "$(Agent.JobName)"

tests/Umbraco.Tests.AcceptanceTest/package-lock.json

@@ -155,8 +155,7 @@ test('can create content with block grid area with row span', async ({umbracoApi
   await umbracoUi.content.doesBlockAreaContainRowSpan(firstElementTypeName, firstAreaName, rowSpan, 0);
 });
 
-// Remove fixme when this issue is fixed https://github.com/umbraco/Umbraco-CMS/issues/18639
-test.fixme('can create content with block grid area with min allowed', async ({umbracoApi, umbracoUi}) => {
+test('can create content with block grid area with min allowed', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   firstElementTypeId = await umbracoApi.documentType.createEmptyElementType(firstElementTypeName);
   const secondElementTypeId = await umbracoApi.documentType.createEmptyElementType(secondElementTypeName);
@@ -169,7 +168,7 @@ test.fixme('can create content with block grid area with min allowed', async ({u
   await umbracoUi.content.goToContentWithName(contentName);
 
   // Act
-  await umbracoUi.content.clickAddBlockGridElementWithName(firstElementTypeName);
+  await umbracoUi.content.clickAddBlockGridElementWithName('content');
   await umbracoUi.content.clickSelectBlockElementWithName(firstElementTypeName);
   await umbracoUi.content.clickLinkWithName(areaCreateLabel);
   await umbracoUi.content.clickSelectBlockElementInAreaWithName(secondElementTypeName);
@@ -187,8 +186,7 @@ test.fixme('can create content with block grid area with min allowed', async ({u
   await umbracoApi.documentType.ensureNameNotExists(secondElementTypeName);
 });
 
-// Remove fixme when this issue is fixed https://github.com/umbraco/Umbraco-CMS/issues/18639
-test.fixme('can create content with block grid area with max allowed', async ({umbracoApi, umbracoUi}) => {
+test('can create content with block grid area with max allowed', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   firstElementTypeId = await umbracoApi.documentType.createEmptyElementType(firstElementTypeName);
   const secondElementTypeId = await umbracoApi.documentType.createEmptyElementType(secondElementTypeName);
@@ -201,11 +199,11 @@ test.fixme('can create content with block grid area with max allowed', async ({u
   await umbracoUi.content.goToContentWithName(contentName);
 
   // Act
-  await umbracoUi.content.clickAddBlockGridElementWithName(firstElementTypeName);
+  await umbracoUi.content.clickAddBlockGridElementWithName('content');
   await umbracoUi.content.clickSelectBlockElementWithName(firstElementTypeName);
   await umbracoUi.content.clickLinkWithName(areaCreateLabel);
   await umbracoUi.content.clickSelectBlockElementInAreaWithName(secondElementTypeName);
-  await umbracoUi.content.isTextWithExactNameVisible('Maximum 0 entries, 1 too many.');
+  await umbracoUi.content.isTextWithExactNameVisible('Maximum 0 entries, you have entered 1 too many.');
   await umbracoUi.content.clickSaveAndPublishButton();
   await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished);
   await umbracoUi.content.removeBlockFromArea(firstElementTypeName, firstAreaName, secondElementTypeName);

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/BlockGridArea.spec.ts

@@ -95,7 +95,7 @@ test('can update property value nested in a block grid area with an RTE with a b
   await umbracoUi.content.clickAddBlockGridElementWithName(richTextEditorElementTypeName);
   await umbracoUi.content.clickExactLinkWithName(richTextEditorElementTypeName);
   await umbracoUi.content.clickInsertBlockButton();
-  await umbracoUi.content.clickExactLinkWithName(blockListElementTypeName);
+  await umbracoUi.content.clickExactLinkWithName(blockListElementTypeName, true);
   await umbracoUi.content.clickAddBlockGridElementWithName(textStringElementTypeName);
   await umbracoUi.content.clickExactLinkWithName(textStringElementTypeName);
   // Enter text in the textstring block that won't match regex

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/ComplexBlockGridTest.spec.ts

@@ -227,8 +227,7 @@ test('can set the number of columns for the layout in the content', async ({umbr
   expect(layoutValue[0].columnSpan).toBe(gridColumns);
 });
 
-// TODO: Remove skip when front-end is ready. Currently, it is impossible to create content with blockgrid that has a setting model
-test.skip('can add settings model for the block in the content', async ({umbracoApi, umbracoUi}) => {
+test('can add settings model for the block in the content', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   const contentBlockInputText = 'This is textstring';
   const settingBlockInputText = 'This is textarea';

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/ContentWithBlockGrid.spec.ts

@@ -80,7 +80,6 @@ test('can not create unsupported invariant document type with invariant block gr
 
   // Assert
   await umbracoUi.content.isFailedStateButtonVisible();
-  await umbracoUi.content.isErrorNotificationVisible();
   await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished);
   expect(await umbracoApi.document.isDocumentPublished(contentId)).toBeFalsy();
 });
@@ -101,7 +100,6 @@ test('can not create unsupported invariant document type with invariant block gr
 
   // Assert
   await umbracoUi.content.isFailedStateButtonVisible();
-  await umbracoUi.content.isErrorNotificationVisible();
   await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished);
   expect(await umbracoApi.document.isDocumentPublished(contentId)).toBeFalsy();
 });

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockGrid/VariantBlockGrid.spec.ts

@@ -178,8 +178,7 @@ test('can set the label of block element in the content', async ({umbracoApi, um
   await umbracoUi.content.doesBlockElementHaveName(blockLabel);
 });
 
-// TODO: Remove skip when front-end is ready. Currently, it is impossible to create content with blocklist that has a setting model
-test.skip('can add settings model for the block in the content', async ({umbracoApi, umbracoUi}) => {
+test('can add settings model for the block in the content', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   const contentBlockInputText = 'This is textstring';
   const settingBlockInputText = 'This is textarea';

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/ContentWithBlockList.spec.ts

@@ -80,7 +80,6 @@ test('can not create unsupported invariant document type with invariant block li
 
   // Assert
   await umbracoUi.content.isFailedStateButtonVisible();
-  await umbracoUi.content.isErrorNotificationVisible();
   await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished);
   expect(await umbracoApi.document.isDocumentPublished(contentId)).toBeFalsy();
 });
@@ -100,7 +99,6 @@ test('can not create unsupported invariant document type with invariant block li
 
   // Assert
   await umbracoUi.content.isFailedStateButtonVisible();
-  await umbracoUi.content.isErrorNotificationVisible();
   await umbracoUi.content.doesErrorNotificationHaveText(NotificationConstantHelper.error.documentCouldNotBePublished);
   expect(await umbracoApi.document.isDocumentPublished(contentId)).toBeFalsy();
 });

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/BlockList/VariantBlockList.spec.ts

@@ -1,4 +1,4 @@
-import {ConstantHelper, test} from '@umbraco/playwright-testhelpers';
+import {ConstantHelper, NotificationConstantHelper, test} from '@umbraco/playwright-testhelpers';
 import {expect} from "@playwright/test";
 
 const contentName = 'TestContent';
@@ -92,7 +92,7 @@ test('can open content picker in the content', async ({umbracoApi, umbracoUi}) =
   await umbracoApi.dataType.ensureNameNotExists(customDataTypeName);
 });
 
-test('can choose start node for the content picker in the content', async ({umbracoApi, umbracoUi}) => {
+test('can create content with content picker without ignore start node', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   const customDataTypeName = 'CustomContentPicker';
   const childContentPickerDocumentTypeName = 'ChildDocumentTypeForContentPicker';
@@ -111,19 +111,19 @@ test('can choose start node for the content picker in the content', async ({umbr
 
   // Act
   await umbracoUi.content.goToContentWithName(contentName);
-  await umbracoUi.content.clickChooseButton();
+  await umbracoUi.content.addContentPicker(childContentPickerName);
+  await umbracoUi.content.clickSaveAndPublishButton();
 
   // Assert
-  await umbracoUi.content.isContentNameVisible(childContentPickerName);
-  await umbracoUi.content.isContentNameVisible(contentPickerName, false);
+  await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published);
 
   // Clean
   await umbracoApi.dataType.ensureNameNotExists(customDataTypeName);
   await umbracoApi.document.ensureNameNotExists(childContentPickerName);
   await umbracoApi.documentType.ensureNameNotExists(childContentPickerDocumentTypeName);
 });
 
-test.skip('can ignore user start node for the content picker in the content', async ({umbracoApi, umbracoUi}) => {
+test('can create content with content picker with ignore start node', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   const customDataTypeName = 'CustomContentPicker';
   const childContentPickerDocumentTypeName = 'ChildDocumentTypeForContentPicker';
@@ -142,11 +142,11 @@ test.skip('can ignore user start node for the content picker in the content', as
 
   // Act
   await umbracoUi.content.goToContentWithName(contentName);
-  await umbracoUi.content.clickChooseButton();
+  await umbracoUi.content.addContentPicker(childContentPickerName);
+  await umbracoUi.content.clickSaveAndPublishButton();
 
   // Assert
-  await umbracoUi.content.isContentNameVisible(childContentPickerName);
-  await umbracoUi.content.isContentNameVisible(contentPickerName);
+  await umbracoUi.content.doesSuccessNotificationHaveText(NotificationConstantHelper.success.published);
 
   // Clean
   await umbracoApi.dataType.ensureNameNotExists(customDataTypeName);

tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithContentPicker.spec.ts

@@ -107,8 +107,7 @@ test('can add decimal number to the decimal in the content section', async ({umb
   expect(contentData.values[0].value).toEqual(decimal);
 });
 
-// Skip this test as currently there is no code editor property editor available.
-test.skip('can create content with the custom data type with code editor property editor', async ({umbracoApi, umbracoUi}) => {
+test('can create content with the custom data type with code editor property editor', async ({umbracoApi, umbracoUi}) => {
   // Arrange
   customDataTypeName = 'Code Editor';
   const customDataTypeId = await umbracoApi.dataType.createCodeEditorDataType(customDataTypeName);