Add a backing field for EditorUIAlias and track changes when its set. (#19733)

* Add a backing field for EditorUIAlias and track changes when its set.

* Add previously failing unit test to verify fix.

* Aligned backing field casing with property name.

---------

Co-authored-by: Andy Butland <[email protected]>

Author: KevinJump

src/Umbraco.Core/Models/DataType.cs

@@ -17,6 +17,7 @@ public class DataType : TreeEntityBase, IDataType
     private IDictionary<string, object> _configurationData;
     private ValueStorageType _databaseType;
     private IDataEditor? _editor;
+    private string? _editorUiAlias;
     private bool _hasConfigurationObject;
 
     /// <summary>
@@ -60,7 +61,11 @@ public IDataEditor? Editor
 
     /// <inheritdoc />
     [DataMember]
-    public string? EditorUiAlias { get; set; }
+    public string? EditorUiAlias
+    {
+        get => _editorUiAlias;
+        set => SetPropertyValueAndDetectChanges(value, ref _editorUiAlias, nameof(EditorUiAlias));
+    }
 
     /// <inheritdoc />
     [DataMember]

tests/Umbraco.Tests.UnitTests/Umbraco.Core/Models/DataTypeTests.cs

@@ -0,0 +1,35 @@
+// Copyright (c) Umbraco.
+// See LICENSE for more details.
+
+using NUnit.Framework;
+using Umbraco.Cms.Core.Models;
+using Umbraco.Cms.Tests.Common.Builders;
+using Umbraco.Cms.Tests.Common.Builders.Extensions;
+
+namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.Models;
+
+[TestFixture]
+public class DataTypeTests
+{
+    [Test]
+    public void Can_Update_And_Verify_Dirty_Properties()
+    {
+        var dataType = new DataTypeBuilder()
+            .WithName("Test Data Type")
+            .WithDatabaseType(ValueStorageType.Ntext)
+            .Build();
+
+        dataType.ResetDirtyProperties();
+
+        dataType.DatabaseType = ValueStorageType.Nvarchar;
+        dataType.EditorUiAlias = "Test.EditorUiAlias";
+
+        var dirtyProperties = dataType.GetDirtyProperties().OrderBy(x => x).ToList();
+
+        Assert.IsTrue(dataType.IsPropertyDirty(nameof(dataType.DatabaseType)));
+        Assert.IsTrue(dataType.IsPropertyDirty(nameof(dataType.EditorUiAlias)));
+
+        Assert.AreEqual(2, dirtyProperties.Count);
+        Assert.AreEqual($"{nameof(dataType.DatabaseType)},{nameof(dataType.EditorUiAlias)}", string.Join(",", dirtyProperties));
+    }
+}