#19775 fixed get user data by applying OrderBy after counting (#19776)

* #19775 fixed get user data by applying OrderBy after counting

* Apply suggestions from code review

---------

Co-authored-by: Andy Butland <[email protected]>

Author: enkelmedia

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserDataRepository.cs

@@ -44,13 +44,14 @@ public async Task<PagedModel<IUserData>> GetAsync(int skip, int take, IUserDataF
             sql = ApplyFilter(sql, filter);
         }
 
+        // Fetching the total before applying OrderBy to avoid issue with count subquery.
+        var totalItems = _scopeAccessor.AmbientScope?.Database.Count(sql!) ?? 0;
+
         sql = sql.OrderBy<UserDataDto>(dto => dto.Identifier); // need to order to skiptake
 
         List<UserDataDto>? userDataDtos =
             await _scopeAccessor.AmbientScope?.Database.SkipTakeAsync<UserDataDto>(skip, take, sql)!;
 
-        var totalItems = _scopeAccessor.AmbientScope?.Database.Count(sql!) ?? 0;
-
         return new PagedModel<IUserData> { Total = totalItems, Items = DtosToModels(userDataDtos) };
     }