Skip to content

Commit 789a908

Browse files
authored
Adjust z-index of notifications (#11634)
* Store notification z-index in variable * Only show unordered list if any notifications * Move notificaion layers to same parent as overlays so layers can be controlled via z-index
1 parent 336f2c2 commit 789a908

File tree

4 files changed

+6
-4
lines changed

4 files changed

+6
-4
lines changed

src/Umbraco.Web.UI.Client/src/less/components/notifications/umb-notifications.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.umb-notifications {
2-
z-index: 999999;
2+
z-index: @zindexNotification;
33
position: absolute;
44
bottom: @editorFooterHeight;
55
left: 0;

src/Umbraco.Web.UI.Client/src/less/variables.less

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,8 @@
362362
@zindexUmbOverlay: 7500;
363363
@zindexOverlayBackdrop: 2000;
364364

365+
@zindexNotification: 8000;
366+
365367
// these are used for the tour which should be on top of everything else
366368
@zindexTourBackdrop: 9999;
367369
@zindexTourModal: 10000;

src/Umbraco.Web.UI.Client/src/views/components/notifications/umb-notifications.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div class="umb-notifications" id="umb-notifications-wrapper" ng-cloak>
2-
<ul class="umb-notifications__notifications" aria-live="assertive" aria-relevant="additions">
2+
<ul ng-if="notifications" class="umb-notifications__notifications" aria-live="assertive" aria-relevant="additions">
33
<li ng-repeat="notification in notifications"
44
class="alert alert-block alert-{{notification.type}} umb-notifications__notification animated -half-second fadeIn"
55
ng-class="{'-no-border -extra-padding': notification.type === 'form'}">

src/Umbraco.Web.UI/umbraco/UmbracoBackOffice/Default.cshtml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,6 @@
7979

8080
</div>
8181

82-
<umb-notifications></umb-notifications>
83-
8482
</div>
8583

8684
<umb-tour ng-if="tour.show"
@@ -94,6 +92,8 @@
9492

9593
</div>
9694

95+
<umb-notifications></umb-notifications>
96+
9797
<umb-backdrop ng-if="backdrop.show || infiniteMode"
9898
backdrop-opacity="backdrop.opacity"
9999
highlight-element="backdrop.element"

0 commit comments

Comments
 (0)